From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E145C4332F for ; Fri, 16 Dec 2022 23:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DF698E0002; Fri, 16 Dec 2022 18:09:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98F3E8E0001; Fri, 16 Dec 2022 18:09:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87E238E0002; Fri, 16 Dec 2022 18:09:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 74E978E0001 for ; Fri, 16 Dec 2022 18:09:18 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 433CDC09A8 for ; Fri, 16 Dec 2022 23:09:18 +0000 (UTC) X-FDA: 80249712396.09.2D394FA Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id 247FC1A0005 for ; Fri, 16 Dec 2022 23:09:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RMCI3gRq; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671232156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C1SUClIfiJ5CV7WbNOAt1JlAm9mQF27ConHjB6ErJ9k=; b=fKJJyhzApC4UJ249uD7RXABPIVbLVcqLHmDGbJK67NrYai0XD2+mKjQMMpEAzXhX4j4NE8 o1Y848ZfKt9k7Aepq2OffrTjLy57iiMZao5c5iNS9AsCjmlipKDeQx1CcYka6xeAGvUmWe L/fyZ/SCYtHoHjJIgvvCXpjs+SLKYig= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RMCI3gRq; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671232156; a=rsa-sha256; cv=none; b=BMHuQTu4hhw32KVM+tD7bLychyb/ch8tm5PDgiBw5mnfmOiDge6wAYi8ExCSCcIfxH9Lo/ vgM9fzXYqjCs1TVNfu7N+VnVmRVFghe2qLBLkdGoUPLn5ItGSHu4nakKBavfW/PXUjTB48 er79IPpFYte9tFQsPs2sKfkCCdDGWY8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3AEC3B81DC2; Fri, 16 Dec 2022 23:09:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96989C433D2; Fri, 16 Dec 2022 23:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671232152; bh=y3Y1ARip08drTXfIeo2kOoxaCl3cE/sJu7Coe2bVKec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RMCI3gRqtUCRSLqE1s9cOrcrcFNQeJxUINER1fOh4TZrDedqk/C5yE7uGW9VmpXeS 3n1KkJsKazMvmhlp0C/QIvB6kWKXl4saqYo5wbd0WJOENEThDKoa3V9Mffs2eoqcp0 yFt2aqiKGrpI1HncfJIOVjTTtyth5xxluXqfbZRI= Date: Fri, 16 Dec 2022 15:09:11 -0800 From: Andrew Morton To: John Hubbard Cc: Sidhartha Kumar , , , , , Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h Message-Id: <20221216150911.a99fe2079a6ba5c880989449@linux-foundation.org> In-Reply-To: <963ba9b4-6ddf-39bc-85cf-2feef542029d@nvidia.com> References: <20221213212053.106058-1-sidhartha.kumar@oracle.com> <20221216142733.e2a716a4cd7ea55240d98391@linux-foundation.org> <963ba9b4-6ddf-39bc-85cf-2feef542029d@nvidia.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 247FC1A0005 X-Stat-Signature: g16s6j1cay1nepe3dgwnj8otoqusndrn X-HE-Tag: 1671232155-180778 X-HE-Meta: U2FsdGVkX1/34jy/J/UU7vU5jKewcMsfOQIQNyv6nwgygH9UoUjS3vw+VCfPw5q4lOi25UsVyQFs/y2jZ13WggZyaCtgXgfgExXZVhXHppQwk5rwQI6uPMsbonmmuaXlk6Q2lRvv3B3QsF+nculpUKGxW6l2LISvoMOWbh30XhY0HziFQUnI7Fn4IpVF8AM1tXQIFFPE0TAmRcT63qvMPjxegBEjSB3YAXu/E4zx6coDKhCKWtJmQ8KQjKM8QpwXaaqARxyqCDRkSrvsIrAXaLj5ZSe2hFl9PUc2IoLcRnzdoDViO0d9vHRrQg7YadedZXxp/OzOMBFJuPszi6zDiAxlM5pA9vSP8PrFhjge70e8f8kQjT2LuubDgZhj2IjNRUnM6Q8Ug3BbPCrE1wTQ4Oi5sHtrUP8WWE+pDzaLoua5AHZUDZ/0dhr/pFjd7RNC4pyDwkq4hItuHibO5fUqmXQ6UoOF1uV/Q6I+i3zigXAL0hRMfL6LFfIgCeNuRrO1nNKMiMz6wmG8gGFVSmxKo6ZQRa75d5DaamOrM/VXYptir8MImYspt8UYwRAZCH3wzI3aJ8bJvBECvjr29PuWEJyCa4GQcbhyIiIJnEXfvD6+a6ka4U6qv/JFS9clJn+Gf2Zuzyr1QFgxOz1TnbhNmtjqELABe3x2kpENsKNXfT67eUcqqxU8FlBZCkflzMDFHpR1NrqejeTlwsUioOwduQ8TOBQBYmgaairKFACEiH4aDxGtl5R854BUOuD/+aNHN2QAiwepjBaaCCZ0Njhwf7nu55d2PTqKTvhJ67BTZxNJl3i4W1j0pHWh3ikE0dh1QaVGXDWjYd7Ax5DIlVeXjUEdDZOSVDNRXoY4Fwj1d+ZT+mCZT1qVc4szbtll7Lrkp5mHBTxfPR6W7f/hTeHvtsGghJFpS5pDUj7n4P6vYj2meZcgUVFoh7HnlpjulYSwxTn0M819sil40baJunF mN3bWLNu a2LWAYg4bp/+dtrE3+LTBYvnZBH5WcfwEWrpkFkC5Mw90ERQ/VN3Bh5g/8zLo9byxp9+RNCEdtAq4/xNTYO1CG4fMNFUJM+2cjTnqdRFDLtovMp9duSnLXQiccg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 16 Dec 2022 14:56:47 -0800 John Hubbard wrote: > On 12/16/22 14:27, Andrew Morton wrote: > > On Tue, 13 Dec 2022 13:20:53 -0800 Sidhartha Kumar wrote: > > > >> folio_set_compound_order() is moved to an mm-internal location so external > >> folio users cannot misuse this function. Change the name of the function > >> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also, > >> handle the case if a non-large folio is passed and add clarifying comments > >> to the function. > >> > > > > This differs from the version I previously merged: > > > > --- a/mm/internal.h~mm-move-folio_set_compound_order-to-mm-internalh-update > > +++ a/mm/internal.h > > @@ -384,8 +384,10 @@ int split_free_page(struct page *free_pa > > */ > > static inline void folio_set_order(struct folio *folio, unsigned int order) > > { > > - if (WARN_ON_ONCE(!folio_test_large(folio))) > > + if (!folio_test_large(folio)) { > > + WARN_ON_ONCE(order); > > return; > > + } > > I think that's out of date? Yes thanks, I'm looking at patches in the wrong order. I'll drop the above delta.