From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06555C4332F for ; Fri, 16 Dec 2022 20:35:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 664708E0003; Fri, 16 Dec 2022 15:35:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 614338E0002; Fri, 16 Dec 2022 15:35:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DBD68E0003; Fri, 16 Dec 2022 15:35:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 402258E0002 for ; Fri, 16 Dec 2022 15:35:15 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1971040334 for ; Fri, 16 Dec 2022 20:35:15 +0000 (UTC) X-FDA: 80249324190.05.04DF9DD Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf13.hostedemail.com (Postfix) with ESMTP id 552462000B for ; Fri, 16 Dec 2022 20:35:13 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HvYgLvzK; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671222913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r/hPsvfVFhvh9haGKLunftTxDivO3JDSv2xgcZcDsPA=; b=31XLBreyrre6wTr27/9tJLAPeSYHpwPiba/MPX1IHqexCtJzA/VPc8rFI776wCCn6dSjfc OPUfxPkrLw9OsMzz/1scUfOzRf+QmGi+RoyBL+s1fp/LUyU7cYSEOT60AxgTVEYuEEOASf C28hgwkwPLkjssVPQ2TyuGEhGPfmqx4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HvYgLvzK; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671222913; a=rsa-sha256; cv=none; b=yaP5RRtAd6f2PfeRJ7boP/ahBk7rzG6cq7+hK97ktTFa7Igobq72S5FqjIUbwYakOcgdK6 UeNb7jelonw0ocSB1i0KK4klvHuFwkQwWmNsGmhtCm1b2wgLWivcvpzegXh+LkeGRflYbz dNaGvY3NeiOoeAWzPymEzUZZdQ67oDg= Received: by mail-pl1-f169.google.com with SMTP id n4so3460724plp.1 for ; Fri, 16 Dec 2022 12:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r/hPsvfVFhvh9haGKLunftTxDivO3JDSv2xgcZcDsPA=; b=HvYgLvzKyB+qontqJaRxw4JCx5keeHG+fJkK4euqza/veNJBrv8ioB2lE6IXO0VI3n esNkVZN37PeYArveZqKULuIZn7F1HgLhZ7ZOg+3+Q1JX2YF8qc0w9Jp9AkLmPCAxaHXq 9NQKhQSoi5qpbGUeWi2a7tg62N+alAyY5VjrQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r/hPsvfVFhvh9haGKLunftTxDivO3JDSv2xgcZcDsPA=; b=VOuGfqGZ1T/O8I704OULUFJpr/sO2xWBxsjZsX1Rl86yYRPJL5i32dKHrX3V4vSQck Nv2aDFAuOGb8bLQ60CglR6H3IsUOicwrMWoUnRZHCSvSJ5QgDy0OcrNLJZA/nq0IbmPu qXTmF8aB/d0SlKYHno/Z621ln+kdl0kKacNKtgK/BbQCPboQu/tKMnfQaiLQDu27eTow EB86CjWjMRnx6vDyUGYRIPjYSih4G8WPzlTqSKY494AifKuW57ae0S4oFXFtTe/abWFD xBTVVJh6NWoDtgDhv5W5W9KWXaU4olGAxNTlDK6tX/vxwJCa27rZQ/Z9wijHOEHA2+nG O0mg== X-Gm-Message-State: AFqh2koDsBSwespHHtiINOcC266oxRXOqVhkP2De47S3fd9iJC6gJ+vF oPmGHavNCEsXos7dJoqrbTqK1A== X-Google-Smtp-Source: AMrXdXt8w3fEbmDbvTVO1Z+Z3U9o6ttyQJonRnCieP1HRMjM8XxbOprdtKK2Ib64+zi1S8WdDE+mjA== X-Received: by 2002:a17:902:d4c6:b0:191:a19:e768 with SMTP id o6-20020a170902d4c600b001910a19e768mr1842628plg.48.1671222912139; Fri, 16 Dec 2022 12:35:12 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i4-20020a17090332c400b0018913417ba2sm2039045plr.130.2022.12.16.12.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 12:35:11 -0800 (PST) Date: Fri, 16 Dec 2022 12:35:10 -0800 From: Kees Cook To: Jeff Xu Cc: Andrew Morton , Peter Xu , jeffxu@chromium.org, skhan@linuxfoundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, kernel test robot Subject: Re: [PATCH v6 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC Message-ID: <202212161233.85C9783FB@keescook> References: <20221207154939.2532830-1-jeffxu@google.com> <20221207154939.2532830-4-jeffxu@google.com> <202212080821.5AE7EE99@keescook> <20221216094259.bec91e4abd6cf54a05ce2813@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 552462000B X-Stat-Signature: u6x8nq99kbo4ejckkeu51ek3skqkfogj X-HE-Tag: 1671222913-329118 X-HE-Meta: U2FsdGVkX196HJ+TiBb2COfwHNWurGC8lxffp2FpMKCBgJDHTT9ZKh/3ngauka1GcBMLTvBaOAfhVLLcGaQjK+33JBwEhUS4SlvGrV+YZWvH8pnGholjCW4aGAw+5EPMZE+Rm9VaMuDEXsLX6A1o0h9gATUq7Rsn41SefeTjUlwNxPsj+cPOoR22cu8Or/DzrzlJkDY0wQvJV24mRWrPLQS5m0qRBEewIIHsL2WvwXG7IFpI6sD6QiUwbkx7r3fCxgFXlXUMwgNTlt2E4P6ji/ZfW/kSOVjuUR0Wbjyq+h1C4NYwhlpawWzQtlibBOdDIKY+z9BswdmbTUaLWJUvQ16XYB0VuwLYqq+W4m2HIrtBZZEbnZ9lyRe8N8+ZSHsU7v+y3DOhzhJuzTNBoQmKXLoXJpsYPHQjTv07yMESQOLgOz/6QbMi14iiqaw62ZAu9KgDPkR2efzrLVoxZ7undWLwj3nZLst6pxqsm2xhx44wWt1VfzYjjd4DhXPLNWBDsdgeSnjMQnXaxq3KAosdsac73PSGQVII8Pzy5RY6A/p0CgVYUJcw/vmN+3xQ51jPjjZCTxbRVJ+EwdbomM/QIXAPa5/Ng4xE1EgAPH3LfeVOAuzEQWocMrilXZHutAhWB5owAlFwmwFShWK2lxYG4cA5q8jct4/JHydatVOG2ANMZy/jjTUE08MCEhGYUvXV9S4Q34LF48YR4wdDuGbum+cGM5clYEap+oYM4UsCPsmAVKo6K98+ZTihCmJf1md3MOn0yMaMREaKyPDu5SeRNw0lK9Lt3/5qzfMk1wrAKkAxXiX7WDlXmxtMEJ77+JhxwMfQX91cS7+AS2FigDMJ7bvnMoycYK2ujlYiGVNxJnOlo559uhGe201UMmRJ8g2Hz5jwyeLiGVOmcYPQd9Cx92Y6FoH+zrLKYQqGNkRLU1p6gnyetegdi4U5AejfFSit43+m05Z2dYY1ZuO/pnb YURQIbqH Vxyiu2FLJ3KEq5ARkpP8kc+P/H20RwWX9UqC/QZsnrOlDEaaxZS+Ys9XFjn+tE3rV7g819GJqPjIfsl+jjmpMCqoHYoKYaFzLRNNxcFYIfvGfBknyi38g5pORS56GcE43MAipZ5NPATNMHH86eeEtI0fJ9QBVj4vvFQFtU580WcPCZwB3jTZZdg4ro4nDrJadw3ymmMpjDCAzHpBqAyWomJrqYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 10:11:44AM -0800, Jeff Xu wrote: > Once per boot seems too little, it would be nice if we can list all processes. > I agree ratelimited might be too much. > There is a feature gap here for logging. > > Kees, what do you think ? I agree once per boot is kind of frustrating "I fixed the one warning, oh, now it's coming from a different process". But ratelimit is, in retrospect, still too often. Let's go with per boot -- this should be noisy "enough" to get the changes in API into the callers without being too much of a hassle. -- Kees Cook