From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99EAC001B2 for ; Fri, 16 Dec 2022 19:21:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 540498E0003; Fri, 16 Dec 2022 14:21:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EF328E0001; Fri, 16 Dec 2022 14:21:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B7408E0003; Fri, 16 Dec 2022 14:21:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C4B68E0001 for ; Fri, 16 Dec 2022 14:21:07 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F3069811B8 for ; Fri, 16 Dec 2022 19:21:06 +0000 (UTC) X-FDA: 80249137332.26.4EF9075 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 2761F180006 for ; Fri, 16 Dec 2022 19:21:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IESvI4UL; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671218465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t+rUiWGXsq5rMQqf3SGDySkjuHiNP3kDIhRjqu9bhKE=; b=a9fEN22gaQZIErwHbO1ycFOvGquLk+2p9kkwKcmGkjQejRNiTpUeLYo/qCNbENeLiFQW03 sxNJRsQ/YXCbqn/pRsgSqFKl41BNfSI/I/n+gdtrBqIgJPVirw42C/2HY8BmRTtpjt/73l mzasr+u5EUYPjQm2OoyknYOxzuDlv3k= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IESvI4UL; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671218465; a=rsa-sha256; cv=none; b=YuL3OJ/LU40JkwnXK/I5UjTR0/9Cp1aA7DGY3ZJ88buiZiQOmHNYQJ7YDBxupA6iZr2ac4 /2+dCPdzFt5cycGSpo6LLa47JWzjFiPRLL1S+rsijFP8jIPqzyUoNT7nt95r9BUfYC0scg SSscnTDTYIxUM4LSJFr/iAck6FSZK38= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06B26621D5; Fri, 16 Dec 2022 19:21:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7564C433D2; Fri, 16 Dec 2022 19:21:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671218463; bh=7V2x1Qhn0q8oBUckNQ44lIULP5uyurI4gqWQQ5JRHuI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IESvI4ULHOkIMzln29SQ2UHfmxQYyYK60NX/zgWPXEQgtI6Qm2GX6Z4ccGJovhoQV YAzVqaROyQdg/2C22txXuS1I1pOf+GpniQCXoW6BeWHrFX+K6qqQKscHU2xcoRwOlu +ZjYwQu0q+xSGj/mbsoUHEIGsxl3oR4OyMyW0jnY= Date: Fri, 16 Dec 2022 11:21:02 -0800 From: Andrew Morton To: Jeff Xu Cc: SeongJae Park , skhan@linuxfoundation.org, keescook@chromium.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, linux-security-module@vger.kernel.org, kernel test robot Subject: Re: [PATCH v7 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC Message-Id: <20221216112102.8eec617257eb90fccb9ff503@linux-foundation.org> In-Reply-To: References: <20221209160453.3246150-4-jeffxu@google.com> <20221216183949.169779-1-sj@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: oozyiw9qxi5rjninqb8tpso45cqwxb3h X-Rspam-User: X-Rspamd-Queue-Id: 2761F180006 X-Rspamd-Server: rspam06 X-HE-Tag: 1671218464-77592 X-HE-Meta: U2FsdGVkX1/dXIaf72Lu2yZ6uQDK3YRYxQ++wLeuGkollsVewlNNssfJOi3TyekB7y51hHevlSLKB/KaW03N91CYfdq3pOoc5/UmG14vPKPV9zTA+QgfnLBJ5CdZB97szweABKR+5xsqR3h2oSQ0+KtAhozYQmzIjR9VmEK5Ppz/dkXUA+3lF1eyJrVbrMgznxGS01F0nYyBhSbz2Q24axVfZgDUVwQWbcN7Nn2hTudb9chIBW/DosISpipmPaIB89eWoQQA85YorDDUbYIFC0fL2PsWt6YFmancCvt1jrcq1UETMy2s8Ecv8AYbKXyMq0KaXofjSYz7RzJnsybGZSKuWNow83FzSwg9boQMK0y3GzCYMo1yJaD9zrV3P2uJGKMc5C6tzIgP/AEBB9XOXqKtKXsPWf4eCzUEptdRny5olxTfVLzGBB5S0I8QYt0A10Hcg6+3zss48HwGkNvGOktYTkWvCS/LlC1A7an3MVpawyflp4tuQIhBb0nX0D7YG/BYmpIybNGBuju/v7OgfJcPqOywqqn08eGQxmpnKZTH3aXDU9T8DxmE7vE5NE+esm4GXtxzP9PA6tyh1qHNNZY48swvpSaUD5qK5yjOofv/HcMhFOEbRVTRSqx4Fj5sQ8gyEB0nhtAwEuR5WDMYKSiSffITGyrPhqrTrXXqyc0GA2TKgXn714PolWFVl2QjRR1EaXjGPDLgbU2UHnKbgp4a+GuQ1+T2N03EpOrmYwb/hJIcviYj2hH6LUXltXAYlTlgmlNZ5bMDMZMaeSn3SZuCebMzHsXnbDE5IRl5Z9+5QORYl6wCRTFgsbnhnGfg5VLEurDU72AlQdLkGhGWvadTAEsbsNje+c1PbevZbfWa4GwRAzfVv47eb09XWfNZaN0OtpsUwCcFeNXshAZuY+l3FBfHXCPIk5Aus7VyJ0ym/7TAG7CtcltAUvBAeIG2jeva5THR9YobWw41+dv wyWm0jzV v0e5R/TNOpalkEQ5X7RyEvSiB3rkI9LcznCIvWkjEOEeD8icPbzcPZtLmUuXFQBadLBIPYzWjyKHdDSTlhU0ZADnh4DPzZ9HD255SDWOcz31K/gdStBc/EzLufNg0XjUrLWAlX97itl89kwAp087BlEWmMQa7qlrbJ6S3Z7Z6TKGtOBQnzgT+wpLabjkx1sfdsAXU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 16 Dec 2022 11:03:06 -0800 Jeff Xu wrote: > > > > I just posted a patch for that: > > https://lore.kernel.org/linux-mm/20221216183314.169707-1-sj@kernel.org/ > > > > Could you please check? > > > Hi SeongJae, > Thanks for the patch ! I responded to the other thread. > > Andrew, > >From a process point of view, should I update this patch to V9 to > include the fix ? > or add a patch directly on top in the mm-unstable branch. A little fixup patch wouild be preferable. But I added the below yesterday, so I think we're all good? --- a/kernel/pid_sysctl.h~mm-memfd-add-mfd_noexec_seal-and-mfd_exec-fix +++ a/kernel/pid_sysctl.h @@ -52,8 +52,10 @@ static inline void register_pid_ns_sysct register_sysctl_paths(vm_path, pid_ns_ctl_table_vm); } #else +static inline void initialize_memfd_noexec_scope(struct pid_namespace *ns) {} static inline void set_memfd_noexec_scope(struct pid_namespace *ns) {} static inline void register_pid_ns_ctl_table_vm(void) {} +static inline void register_pid_ns_sysctl_table_vm(void) {} #endif #endif /* LINUX_PID_SYSCTL_H */ _