From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A876C001B2 for ; Fri, 16 Dec 2022 11:57:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06D428E0003; Fri, 16 Dec 2022 06:57:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01D048E0002; Fri, 16 Dec 2022 06:57:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E50698E0003; Fri, 16 Dec 2022 06:57:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D39DF8E0002 for ; Fri, 16 Dec 2022 06:57:46 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A7E544088B for ; Fri, 16 Dec 2022 11:57:46 +0000 (UTC) X-FDA: 80248020132.06.32AFE35 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 2FE27180003 for ; Fri, 16 Dec 2022 11:57:45 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=Hw7k=4O=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Hw7k=4O=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671191865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZkLSvHlKAxpiHHx+rMSlM6DVLJ6am83N/7hxDe62Bw=; b=gpU9lku3BkeEtP9vfPq6cGoXfjFn/DnZe3Q8DlIQwKB2PWXxtjapg/FB/+D2V4ppr7iCd1 yp7uN9EbLOHrKkeMNxjGIHdeRMkjEratjaTf/MdLgWrKVsMqVGw6NfL3FwnYtTUDNBJtdg h2aNbUsMcK4bqjqC55aUJrUDmVr5a4Q= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=Hw7k=4O=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Hw7k=4O=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671191865; a=rsa-sha256; cv=none; b=KI3eUQZGGDuRoPmkHElD+1vaW/K4IeGDw4HwpgMPGsnYYxGPeEjvlyKgw+6Q/sxa3KsILh AU6uPnzZ1NxKAEGIn21Z78142P8HSVc7GoCB9wgZ3zZTtIEJoDRAXJnjfYE0h0o58Fo7Nz z2SynU6DcwjIyIU3aM01u6SLkhfBJ2s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16A2B620C1; Fri, 16 Dec 2022 11:57:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B8E5C433EF; Fri, 16 Dec 2022 11:57:42 +0000 (UTC) Date: Fri, 16 Dec 2022 06:57:39 -0500 From: Steven Rostedt To: Wenchao Hao Cc: Masami Hiramatsu , Andrew Morton , , , , Subject: Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc_finish Message-ID: <20221216065739.30511197@gandalf.local.home> In-Reply-To: <4e9f9b32-7835-e4c5-55cb-9db82c98f9c1@huawei.com> References: <20221208142130.1501195-1-haowenchao@huawei.com> <4e9f9b32-7835-e4c5-55cb-9db82c98f9c1@huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2FE27180003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: dn3nmkopy97n81j715r8k8ugpsdww4mj X-HE-Tag: 1671191865-347091 X-HE-Meta: U2FsdGVkX1/kekHKPL9O5neuLwY2K8JZN3ejMKSK0HFmEZCoE/Z1y2ypu09gNaWDZmypxLwD96qdng0diznbhymM72YCf9GKtTEpxC5+cLkrfCBJhUoUAQBhP+PhFyxq6Xifd0hVCYKtnNTEjT/QLUBotx8eNY4VLHJ5/qX6h4lu21GO9KxZccsF9Yjkv5ciFAUHxVjHNe0nkgiwYrtZugnV/UWn6k07w3M2os+zAxTk6bZN+34ZhmhMyWIF23EsFLyfde4WE/WwRHleG9z7OecgA44Lqa/o3R8etAvzu35Lvuqj3DcLskDv9LdHabw7uAQk60DacX641pCZNjlIDK84E0NEtUfC79DgcnJ9GmUucFPVxDgDG5wZCRyDqF1Qhk43QvIUjwz4veOoZq6sdApQytK4q/RDO5txL7BniTymPnz06NQtDd6W+5HrJ2c7h5yMXeZUmtjDfuNBAhD9VsmE7DFcKy966DbfM2lCF+j7HaVowOg6TNcPruVqzRK34Olb51EhSlgzV4QqmXcktzFOFVOXzngEoMmrYKk/5aQMkNPLMvcZepWWqPX55i8Gp5R2jOBlxdrMoxaD9wSjO4sWolPjJSGnRLOOcHOMK0Ba6r2ZjutfB1H+lEZbIWXh9+nC7gA0ay0gjRZpVjkjDJT6O8ac31HquCglHbz8Iq+w69PBTAgssnESI1ETuGKfL5l5yvJJD2wGb6i/IFQqrWGziH4rkxSDOeRcinWnUzzklFq2wmmFVjIS2EA1nGuLnrOnN7L0+N8N4ZZ0UbGXS+p3+n1k6DNJDXx2PN62Gv9soOSj7sxErRgJfq6CzYopVKHHPOjpzx3RBPqFAG1iVzM8+yFSFuOcadSmeZipR07T5kSA3f8l4GZ4WFen+yH+nnx+BUdG8gJYQH32PymDrwbj65x5WBDZyIlOpldl98T2prk9RidP2uNL059ICwgs7shgzYvNrct7X+O8EIA /feqqTBb GdMzVXkeplMATc0nUhz02TQEBqZvnw0EOdP1rPc0zcwdCDjfd/lEwGxzaRnUltPKTMrUWch6fQ69rBr85LeUMLwwO6rwwXYVbx4fDu4uFFFve4i6NKJVI39KVWRvFA5O/HGxi9fkQF40lHBk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 16 Dec 2022 19:47:59 +0800 Wenchao Hao wrote: > On 2022/12/8 22:21, Wenchao Hao wrote: > > The result of allocation is not printed in trace_cma_alloc_finish > > now, while it's important to do it so we can set filters to catch > > specific error on allocation or trigger some operations on specific > > error. > >=20 > > Although we have printed the result in log, but the log is > > conditional and could not be filtered by tracing event. > >=20 > > What's more, it introduce little overhead to print this result. > > The result of allocation is named as errorno in trace. > >=20 > > Signed-off-by: Wenchao Hao > > --- >=20 > pinging =46rom a tracing point of view, I see nothing wrong with it. Reviewed-by: Steven Rostedt (Google) But I believe Andrew needs to take it. -- Steve