From: Steven Rostedt <rostedt@goodmis.org>
To: Wenchao Hao <haowenchao@huawei.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<liuzhiqiang26@huawei.com>, <linfeilong@huawei.com>
Subject: Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc_finish
Date: Fri, 16 Dec 2022 06:57:39 -0500 [thread overview]
Message-ID: <20221216065739.30511197@gandalf.local.home> (raw)
In-Reply-To: <4e9f9b32-7835-e4c5-55cb-9db82c98f9c1@huawei.com>
On Fri, 16 Dec 2022 19:47:59 +0800
Wenchao Hao <haowenchao@huawei.com> wrote:
> On 2022/12/8 22:21, Wenchao Hao wrote:
> > The result of allocation is not printed in trace_cma_alloc_finish
> > now, while it's important to do it so we can set filters to catch
> > specific error on allocation or trigger some operations on specific
> > error.
> >
> > Although we have printed the result in log, but the log is
> > conditional and could not be filtered by tracing event.
> >
> > What's more, it introduce little overhead to print this result.
> > The result of allocation is named as errorno in trace.
> >
> > Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> > ---
>
> pinging
From a tracing point of view, I see nothing wrong with it.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
But I believe Andrew needs to take it.
-- Steve
next prev parent reply other threads:[~2022-12-16 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 14:21 Wenchao Hao
2022-12-16 11:47 ` Wenchao Hao
2022-12-16 11:57 ` Steven Rostedt [this message]
2022-12-18 1:20 ` Masami Hiramatsu
2022-12-28 8:17 ` Wenchao Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216065739.30511197@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=haowenchao@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzhiqiang26@huawei.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox