From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86936C10F1E for ; Thu, 15 Dec 2022 22:37:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F6DC8E0003; Thu, 15 Dec 2022 17:37:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A7078E0002; Thu, 15 Dec 2022 17:37:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 696C78E0003; Thu, 15 Dec 2022 17:37:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5A08E8E0002 for ; Thu, 15 Dec 2022 17:37:08 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 32068405F4 for ; Thu, 15 Dec 2022 22:37:08 +0000 (UTC) X-FDA: 80246002536.04.5B2CB40 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf29.hostedemail.com (Postfix) with ESMTP id 7B74012000B for ; Thu, 15 Dec 2022 22:37:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="niC/oyIL"; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671143824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Iel239RCy3r4UMpkndCBPF9tmmORnw7g7JhiAdz86ZA=; b=NJkrC1O7aYyzJ/Pe5CgK3tHMmWz72xkdBP4cJGJAER4vHuDbBUvvhzZd5cP8DaoOAiBN5h +MTG+Q4eWRV4EXvoHChaZjw7H+pq8LlDIqe9a8uHDWrIhK7JuBr6qDrPKM4SGDZKQ3xYf6 DQEswKWA4j4c9E6vpQTeuB+SIYdsjEE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="niC/oyIL"; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671143824; a=rsa-sha256; cv=none; b=nR0sDTxv2jj+OtJxSnkCsXskk5ojqqzKa67xd8ybIZUuWrPginRsisrc40BuCHaZIUgd0M mpE42g3jftOqyZL6QG37ROfRzdJgnaKDMyxyZi37NhbcTWDAZnJYghWbOLoQDw3ZFWI1bb ixkYOBXVdZEq8kI0FcD3lpa84ti8qH0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF03CB81C9D; Thu, 15 Dec 2022 22:37:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E210C433D2; Thu, 15 Dec 2022 22:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671143821; bh=sORse0IGcAma0YoG8+CcwCQtsnysD6EbRJIA+wtE9w8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=niC/oyILOGo3MMNQvkGHvvoqVsyhtdU1p11c2bskUgZjejn1o90RAZ0Xi6vMU7ij8 qqheuoYvO55WC1r3mF3EvMltIcxQ30KoeVgY5yKSrMxU+rcKL8WKbUBI45CoW4/GTJ RS8/kwoEjrlusZ8clwbrQAC6JQjkgZbpr6/nheGE= Date: Thu, 15 Dec 2022 14:37:00 -0800 From: Andrew Morton To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Miaohe Lin , David Hildenbrand , Peter Xu , Naoya Horiguchi , "Aneesh Kumar K . V" , James Houghton , Mina Almasry Subject: Re: [PATCH 1/2] hugetlb: really allocate vma lock for all sharable vmas Message-Id: <20221215143700.232f7ef0084167269f7068df@linux-foundation.org> In-Reply-To: <20221212235042.178355-1-mike.kravetz@oracle.com> References: <20221212235042.178355-1-mike.kravetz@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7B74012000B X-Rspam-User: X-Stat-Signature: fptxuwfy5349j8npdh3iu6sc5hscqoas X-HE-Tag: 1671143824-610469 X-HE-Meta: U2FsdGVkX1/Lf6TOHagXH+TbhU5pnqi7abzLu4w6c7HEN5VCkznCa2YQttGl1SEZMEXGwtudQSC/F2NrpWwsGEshtaoDN6x48gkK4jHGYEuf+6Pb3XLaMnQ/9YsnzfpRf5wS0q64voxlXgJxTCglwNyKZlqSiQYGoki6p+6Q3LmXYor3kWGxWYVIcZ0OFYQW5blUwx0Md8Aj84TeASolwmo3kYNcVxSML5YyQaN2oYFyyaHDyXk178pxYEXdODF4+0nu4GQiVFck55QLpZcbbhhDwg+eA/Iq4rxsYGIJrjExXeQXUvoCFV9jhn07JUF3IoW8UJv4i43Tza4n9C3pSDgwhJvWFYU8OEhc85oeLgzXp3byrKSPk6FsrFlcni53zEXl1BziWLFReQLeyJrL6ENePiS8/EfjcigbnGClrdllrRHoeLAyOAboQf7KhNGO5B0g4hg+LnDTFYWkc+iG+ZFS0+uI9KDBHYf8WAKTTja2dtaZwgTBptvCtYvT0QvSn+/ldMoxdmxFC3O6MGMBwsdBWBGbIbq8XtEvGkG3aiCLY/NsrqqA22noiMDXwiee5X2G9UPlsx7ULv2KKmDAr33pblClBTltsjyMgblrnsNdFvZ1h1s/gavBZrezXXPT/aSTX88gwlocI/nE0okvASN/q+ENmg5Oxsu9SaDTxNdyBd+zGuIbHgziG8Dge3Qsg900HBUsrvcLwdinbdS9EogDNI4Up1Ona3sfDrzG20TVgFw3ugCUWmX4QShjtMMns/d2ELg0hL06UM7sVUBh+pS7Gtvm/AdL1azeWYrViClRlStzIHnWEhOeKBuaSJYK3BI6QrX3OtKmO5x+gV0DBWGs8V+M68LelNY3xjjncuQTvBs45qa/pYZ3fN2CJ/+a5uY9wWh2hi7hNTtr4QFMPxYYl1kG+jD55pTcF6CnYtP+xlYfJCc/b7QKWRtIXE6/La9sAA/pLYcIEOaOiQm B7Ck1ipq arMw4wmRH/uOWBBPO1RNPTc0ge79/SvaP0RzeW4A3VeS8p0JtXge3e1r/FffLLggnwVUTxOAJkY05ZB4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 12 Dec 2022 15:50:41 -0800 Mike Kravetz wrote: > Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") > removed the pmd sharable checks in the vma lock helper routines. > However, it left the functional version of helper routines behind #ifdef > CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being > used for sharable vmas on architectures that do not support pmd sharing. > On these architectures, a potential fault/truncation race is exposed > that could leave pages in a hugetlb file past i_size until the file is > removed. > > Move the functional vma lock helpers outside the ifdef, and remove the > non-functional stubs. Since the vma lock is not just for pmd sharing, > rename the routine __vma_shareable_flags_pmd. > > Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") So I assume we want this backported to 6.1? I added a cc:stable. The [2/2] patch is, I think, 6.3-rc1 material?