Hi Kefeng, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v6.1] [cannot apply to akpm-mm/mm-everything next-20221213] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-converted-page-idle-and-damon-to-use-folios/20221213-171230 patch link: https://lore.kernel.org/r/20221213092735.187924-2-wangkefeng.wang%40huawei.com patch subject: [PATCH -next 1/8] mm: memory_hotplug: add pfn_to_online_folio() config: m68k-allyesconfig compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6549c7ce5345695320d1dadef2aceff6e76d34f4 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Kefeng-Wang/mm-converted-page-idle-and-damon-to-use-folios/20221213-171230 git checkout 6549c7ce5345695320d1dadef2aceff6e76d34f4 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k prepare If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from arch/m68k/include/asm/page.h:60, from arch/m68k/include/asm/thread_info.h:6, from include/linux/thread_info.h:60, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from arch/m68k/include/asm/irqflags.h:6, from include/linux/irqflags.h:16, from arch/m68k/include/asm/atomic.h:6, from include/linux/atomic.h:7, from include/linux/rcupdate.h:25, from include/linux/rculist.h:11, from include/linux/pid.h:5, from include/linux/sched.h:14, from arch/m68k/kernel/asm-offsets.c:15: include/linux/memory_hotplug.h: In function 'pfn_to_online_folio': >> arch/m68k/include/asm/page_mm.h:139:115: error: 'high_memory' undeclared (first use in this function) 139 | #define virt_addr_valid(kaddr) ((unsigned long)(kaddr) >= PAGE_OFFSET && (unsigned long)(kaddr) < (unsigned long)high_memory) | ^~~~~~~~~~~ arch/m68k/include/asm/page_mm.h:140:33: note: in expansion of macro 'virt_addr_valid' 140 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/memory_hotplug.h:230:13: note: in expansion of macro 'pfn_valid' 230 | if (pfn_valid(pfn)) \ | ^~~~~~~~~ include/linux/memory_hotplug.h:270:29: note: in expansion of macro 'pfn_to_online_page' 270 | struct page *page = pfn_to_online_page(pfn); | ^~~~~~~~~~~~~~~~~~ arch/m68k/include/asm/page_mm.h:139:115: note: each undeclared identifier is reported only once for each function it appears in 139 | #define virt_addr_valid(kaddr) ((unsigned long)(kaddr) >= PAGE_OFFSET && (unsigned long)(kaddr) < (unsigned long)high_memory) | ^~~~~~~~~~~ arch/m68k/include/asm/page_mm.h:140:33: note: in expansion of macro 'virt_addr_valid' 140 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/memory_hotplug.h:230:13: note: in expansion of macro 'pfn_valid' 230 | if (pfn_valid(pfn)) \ | ^~~~~~~~~ include/linux/memory_hotplug.h:270:29: note: in expansion of macro 'pfn_to_online_page' 270 | struct page *page = pfn_to_online_page(pfn); | ^~~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:118: arch/m68k/kernel/asm-offsets.s] Error 1 make[2]: Target 'prepare' not remade because of errors. make[1]: *** [Makefile:1272: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:231: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/high_memory +139 arch/m68k/include/asm/page_mm.h ^1da177e4c3f41 include/asm-m68k/page.h Linus Torvalds 2005-04-16 138 a65a802aadba07 arch/m68k/include/asm/page_mm.h Geert Uytterhoeven 2021-03-05 @139 #define virt_addr_valid(kaddr) ((unsigned long)(kaddr) >= PAGE_OFFSET && (unsigned long)(kaddr) < (unsigned long)high_memory) ^1da177e4c3f41 include/asm-m68k/page.h Linus Torvalds 2005-04-16 140 #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) ^1da177e4c3f41 include/asm-m68k/page.h Linus Torvalds 2005-04-16 141 -- 0-DAY CI Kernel Test Service https://01.org/lkp