From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F040C4332F for ; Tue, 13 Dec 2022 19:26:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A10608E0005; Tue, 13 Dec 2022 14:26:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BFDD8E0002; Tue, 13 Dec 2022 14:26:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 886FA8E0005; Tue, 13 Dec 2022 14:26:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 799E38E0002 for ; Tue, 13 Dec 2022 14:26:40 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5545CA0A77 for ; Tue, 13 Dec 2022 19:26:40 +0000 (UTC) X-FDA: 80238264960.22.D1AC456 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id AE33B80007 for ; Tue, 13 Dec 2022 19:26:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uT2x8oDP; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670959598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/emhmtqf5vLCLN56FsPqtlsgIr6R8EiE/kgUIjsp4oY=; b=Z4/xkxOnfe4o7Q6u0JGSyBLEbFnPyfeiE6zsnMGvAcRRqazko0aEHFK2cAv0gTObLgXZN5 hnjpfOBCo6KGYgf6qy6yT86rONUPlfJGnCd7Cb7Otmom/WtzT/O4MVeWQNnp8y1bbre4kH oO8Q3GjIyIElTaBK0K/KWPbAS3vaBBY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uT2x8oDP; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670959598; a=rsa-sha256; cv=none; b=ozPhNEqABzOWfNHKIqhwiKamhZX01tEEtGmHmwS2jkwfArtDpJW6Aa8k/KD7FC1RmyKcYO 03pQyboRJhJNEG2bw93l4Hz8J4fK7Rg/zcClosw4c9mw8ZKIFihJTnUrBGV92Is+TnQVGx wuuzcAeBMtsdG+2ySGbxDmbKU3sliC8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3B9F1B815B1; Tue, 13 Dec 2022 19:26:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B7ADC433D2; Tue, 13 Dec 2022 19:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670959596; bh=QK2oIpKFkW8Y+pz74LHORvAxoSG1SnUXy4S3zV/L44U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uT2x8oDPFQmOBhB06fHpXNUG8BIaSfysV1d0mSqOFUvwRfazhlQuGTCRhl/ICwcX3 atRzYdVQCI2MxWZGJ1fhvuz2tWgKyT8mgq9/hsMktCizQBril30G86ftXB/uZb8pF0 76nhXKgy3S1DoVKbelp+0TX6l9LPsW7tJwAtk6Iek7gBQ0SjSbZ3UBHB0gJpL47izZ pdTzrj9cns4eE1fHszq2m+KhynY2QYJ9/omZdazrJSvek/492QSB63e7XoGfVNWc+L ShQIINlai/aocSwdyFEL+yE/VsHVs9UD8/HtoIVHIlpH+HyTxC/Mi4ZPqmU0uKksKa i0z/sQc+VdkaA== From: SeongJae Park To: Kefeng Wang Cc: Andrew Morton , David Hildenbrand , Oscar Salvador , SeongJae Park , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev, vishal.moola@gmail.com, willy@infradead.org Subject: Re: [PATCH -next 8/8] mm: damon: remove unneed damon_get_page() Date: Tue, 13 Dec 2022 19:26:33 +0000 Message-Id: <20221213192633.138774-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221213092735.187924-9-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AE33B80007 X-Stat-Signature: mc4jwgofasaujrjebxwmatdgxfmuf43r X-Rspam-User: X-HE-Tag: 1670959598-395790 X-HE-Meta: U2FsdGVkX19EW1XHf2RKzhoovZeIpGS2SWw3lOJYao5uz+rnJREfiVDUa4liUfLd9muvYLiGfmbgUKVCKI6pJx8AZgITO0Of3pWRzVp2tjbKyTbIZZ/rXCMXDSrUCe8H3boy+qhI1lSdu633caP5UwcSoLmHrymgQLEKkhG16YZuc2Y/4fjbpu9Rp+3m+2HLYTLeN5qtXQ6O7VeWu/s2VJpWKvMIgFXVz2g+nT2yr3tXQVcEio4BAUxuovp6OzgneDEFd9BcUoDaYNTauhgEQEV7xZ71e8mD1xMRPDYxCHKLcLFUhsxe9bM8fkwttOAqCU/9FQbF/aAzFX1/3HaIal6sFK4j6BscFKEXsuO4k2YcwwPZM5eIxny/65pcG8+zZ1ciL0kjf8pSE5llB476Zj5iKDrX4kPIz6Dwcj1HY8YC+I7ujcwbAGfyiiUJ4hF5hoHgIkArjPkGrmzJRRvR5REbMO04f78/z1TqD2iCTV1EsecbDnF1BdWMfyc8+9Wq+W0Kt5wKgzYEk7F39lnF/ewkvy0Xem3NDH52mcDUqJwrh5CgJO5KxO/V4XNPpPJFrm96EiOZA8T9o208h6CQ8pRTTY4lW7jBSWQ1Krwm3ZD2N/dcOjyS65pvhI7hTZ6meUx8M/Lc+K+0KQ+jh6VC8y9D+f7D9MuT+9ftrtLvUW4nLYvIl/VVVIecBbYHNK4kXRactEObz92Q8KjCzJod0GQhq56YAXG4b0jW3aeYXTAgd8POyNm4eceedPQ/7tRp9nnSd6M4HJ/DDwrFbv6xVU2iIeAOZBerFZ5mKllafpssrL0doUfpO43+D/nLOek5K0FCNHDaONaK/stMfZe7KLAPYCzERbXtc1z2mVSJgiA9qiGOHrka1a3WE4qJ3Cs4wbtNgsKSNI5enGbN0EF1CtQFbDJEBxE0O/c5eGsKEwtOKK4WkwhPeNx+JrblZf055gnDz6pGumLMjZbYkmj uFSno6Eq rgtStpd3E6duTOtRShh+VO7wwxEcpuOFt0OGpGGeDdB54Kklv5EHmDC1ZgWF2z/8T5eNFfvpLv9V1oY3npbOxhm6Lj5zWE5kJbuRFNDf2hXnL2kCxKdHntkviLsR86ES+ZqY/0hfFu+jza+HipwkeNUKpNLLCJ0K0TiReWpoPZCKapU3cZr9eycLR9Ofef5LovFDt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kefeng, On Tue, 13 Dec 2022 17:27:35 +0800 Kefeng Wang wrote: > After all damon_get_page() callers are converted to damon_get_folio(), > remove unneed wrapper damon_get_page(). > > Signed-off-by: Kefeng Wang > --- > mm/damon/ops-common.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h > index 4ee607813981..35a2e42a27da 100644 > --- a/mm/damon/ops-common.h > +++ b/mm/damon/ops-common.h > @@ -8,13 +8,6 @@ > #include > > struct folio *damon_get_folio(unsigned long pfn); > -static inline struct page *damon_get_page(unsigned long pfn) > -{ > - struct folio *folio = damon_get_folio(pfn); > - > - return &folio->page; > -} > - > void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr); Let's keep the one blank line before damon_ptep_mkold(). > void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr); > > -- > 2.35.3 Thanks, SJ