From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273A3C4332F for ; Mon, 12 Dec 2022 11:33:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59F778E0003; Mon, 12 Dec 2022 06:33:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54F438E0002; Mon, 12 Dec 2022 06:33:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4178E8E0003; Mon, 12 Dec 2022 06:33:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 32ED78E0002 for ; Mon, 12 Dec 2022 06:33:13 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0639340A62 for ; Mon, 12 Dec 2022 11:33:13 +0000 (UTC) X-FDA: 80233443066.22.8BCF8A6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 4756C4001B for ; Mon, 12 Dec 2022 11:33:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=S+A7YkFx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rQ33K+wQ; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670844791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mZYmdwkK1w0PeE5ptwfUe6FakZTF7Yz4y8nYAppV1AI=; b=eEj+ystjc8jXxBe26NsEKp50vBujCl/p7U3PiKjMZAsA1/8gw4JphbphyYdNDssaGu2Y+R /mCi+m+0d8K4gGnTlIa4PtaKKD2RsVlxvSBRwthTmyvSu9mEfnOv17xsh+7iYSqC0Y5sga GLenkI1xlRnJXo7UiLr3ji/nyqlCPek= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=S+A7YkFx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rQ33K+wQ; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670844791; a=rsa-sha256; cv=none; b=28fNc0Z93Bgih3xGoc7SFTS4ALSLn9PFpyFStb7f87qBBuQqp/G2GVmVdQSYgMYVGYVCKW GJ57B/ALei+LHXt0MqGMcBuZvEphmW7OLDPkZ1oau9WSrCAGGBmN1XsWp5uJvWRDGi/rEq FThJtdXHDM17M3GbJi8259K5EGOq20I= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 02F701FEBD; Mon, 12 Dec 2022 11:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670844790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mZYmdwkK1w0PeE5ptwfUe6FakZTF7Yz4y8nYAppV1AI=; b=S+A7YkFxWPJ6lLAQCT0hDvVHZudhl6ayUKTUiCv7zez4VSTs1J+6UpCk6gHw6cGQWzvGu4 JqjySd6gOEVDtV4MEt65O4XQ8Zryij8K6vbGCguAoraq7Y0r+CqEUGZEKKOO5feKf5dbkg 8PwpxCuNfmNqJF6M4ttRj+XYGjnJc70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670844790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mZYmdwkK1w0PeE5ptwfUe6FakZTF7Yz4y8nYAppV1AI=; b=rQ33K+wQv9qrKC7p/ZEpZA3lrl7v3ALplhUzQG19j2ZMBKOr/Ch+7YDZr190KQM/ryc2G1 j/bXxgwWK2JYg3DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EA5CE13456; Mon, 12 Dec 2022 11:33:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Y6ytOHURl2P2YgAAMHmgww (envelope-from ); Mon, 12 Dec 2022 11:33:09 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 79BD0A0728; Mon, 12 Dec 2022 12:33:09 +0100 (CET) Date: Mon, 12 Dec 2022 12:33:09 +0100 From: Jan Kara To: Linus Torvalds Cc: Jens Axboe , Jan Kara , "linux-fsdevel@vger.kernel.org" , Linux-MM Subject: Re: [GIT PULL] Writeback fix Message-ID: <20221212113309.xzrcxdmwewfx3zd5@quack3> References: <9f6a8d1a-aa05-626d-6764-99c376722ed7@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: zdgajq5xnreppt1skxu47xru36p3wp9q X-Rspam-User: X-Rspamd-Queue-Id: 4756C4001B X-Rspamd-Server: rspam06 X-HE-Tag: 1670844791-796524 X-HE-Meta: U2FsdGVkX18qQjKc9FU0fe6JM17BLabGrHpSZBIDcx+sCJLQ74Fw+HX8DA3zgMOcAmzkoXTioJe1JkLnhqAxJ3veMcKNxbEzIDy2P8xJLsictceBwtvjQElhOvNV+rOahSaaC4fUy2sfN5WhSlFrZ4RtLl6ATDmWJIs+H+MVAy0H6tNXle5jS8CTOa/hr1fiV6H62m7iEsYU2yjM+TkWw/h1dybN4VuWIPXvyEASWOmGo4Em5qvJB/fhnbw8hp34yZB+SRinAYXYMHdOfzSXfV+hxoypujJW0+GqyikyNvlywz+E1J8VfJhf4EhzbpavQ6D2Rg+0x2TepfRN2GFmKyoMHf1rtDY9uhYuysFsDsAZr7cMy+heiCfbX8QQX3Ad/s9v+9QOkUsUjEgNWMqhQHgDVMY2WGkn+qRQJxAu8dDZFb5NH0FrdhrXPhSauBhRmhpYp18tFjgKVbuuwNr96o4ifqio6D14uDgrVUDeymxuKhJorP+Xlnh1gpLkZGpHgjelF0+ARzE4RpS+zdPMzxWTS9ftiG8xLFnqlUEgRu4xACNQG5vt7xfuDa1YWMKZOvZarphrSxfYyCGuddoba548qNm0kRED4B4+3jr6g44mTk6YVfKeQLuUgJdwpFqm3+F8wpZoTZcmHnozJJj+0E0mpy3FzouDU2vWCwqZrp8Q46X5WQvke2Sn7K6/y30pLU+EyVtk5wya0cy/griLJlrZ3hbk7+otUTgR8R6/jf0GAygpsprcZy65S0no72YnXgHr1T52vIuyknN0a6UtizBLalwbpmcDpKbO6il7uw0feyLvWdlAMrA0Nk7nNqiIENIuKaCtDUjN1MsZA8/JdDyGIIBkGvdNIsXpC+7QmI16SZJANKLI4FI7MUQv/VGPxhxKIUcct+COKSp9Syo4bvSgY+BXEB0bQ8/I89EuLt63AJ+aeNSYOy/SeOdw/3Cq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 10-12-22 09:44:16, Linus Torvalds wrote: > On Sat, Dec 10, 2022 at 7:36 AM Jens Axboe wrote: > > > > Just a single writeback fix from Jan, for sanity checking adding freed > > inodes to lists. > > That's what the commit message says too, but that's not what the patch > actually *does*. > > It also does that unexplained > > + if (inode->i_state & I_FREEING) { > + list_del_init(&inode->i_io_list); > + wb_io_lists_depopulated(wb); > + return; > + } > > that is new. Yeah, I should have explained that. Now added to commit description and also to a comment before the if. I'll send new version to Jens. Honza -- Jan Kara SUSE Labs, CR