From: Jan Kara <jack@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [GIT PULL] Writeback fix
Date: Mon, 12 Dec 2022 12:33:09 +0100 [thread overview]
Message-ID: <20221212113309.xzrcxdmwewfx3zd5@quack3> (raw)
In-Reply-To: <CAHk-=wgqkWVi3nm6HJvOOy+GUVmPt9Wun+_ZVp47wZU43FET9w@mail.gmail.com>
On Sat 10-12-22 09:44:16, Linus Torvalds wrote:
> On Sat, Dec 10, 2022 at 7:36 AM Jens Axboe <axboe@kernel.dk> wrote:
> >
> > Just a single writeback fix from Jan, for sanity checking adding freed
> > inodes to lists.
>
> That's what the commit message says too, but that's not what the patch
> actually *does*.
>
> It also does that unexplained
>
> + if (inode->i_state & I_FREEING) {
> + list_del_init(&inode->i_io_list);
> + wb_io_lists_depopulated(wb);
> + return;
> + }
>
> that is new.
Yeah, I should have explained that. Now added to commit description and
also to a comment before the if. I'll send new version to Jens.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2022-12-12 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 15:36 Jens Axboe
2022-12-10 17:44 ` Linus Torvalds
2022-12-10 18:11 ` Jens Axboe
2022-12-10 18:14 ` Linus Torvalds
2022-12-10 18:56 ` Jens Axboe
2022-12-12 11:33 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212113309.xzrcxdmwewfx3zd5@quack3 \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox