From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5460C10F1B for ; Sat, 10 Dec 2022 23:01:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 702808E0005; Sat, 10 Dec 2022 18:01:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B3198E0001; Sat, 10 Dec 2022 18:01:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57D188E0005; Sat, 10 Dec 2022 18:01:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47C3E8E0001 for ; Sat, 10 Dec 2022 18:01:12 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1910EA08D8 for ; Sat, 10 Dec 2022 23:01:12 +0000 (UTC) X-FDA: 80227919184.12.F1FF972 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id A201780018 for ; Sat, 10 Dec 2022 23:01:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JiURrLgu; spf=pass (imf30.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670713269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=RAobAJDhnMfMrw100Rt9Jr3gbpGAJeof0vxby2hwwp8=; b=IwYEC51NxqtZu0y2PPZJ3KtqtjCh1t3sYlfiHW0txE3rbWj5i7lgC0NCpvok+M9uvKqFaZ 4/ymvtxwsDDDdpGmGHW4q2PXraSj28KZ//feBy39x0zSG4Unxr/7D55eYCo2uULZRq/RiO Z/zUYw/NafYMwQOCuysX/yhtS5ByWaw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JiURrLgu; spf=pass (imf30.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670713269; a=rsa-sha256; cv=none; b=8IXT5CMZqLhjkRl/3ac7wgcFzXefbsBqwjh0Sjb2ZencMfZQMvqcWx7UAITub5zCFpCpUb wk/x1MGKCQjnrFn9IjurJZqCi/YgLntVOhlpf09k9QbV0+Vsz2sCFEYp8orXy7aRgm8C9u 592L1roCUfAIobrs3rshM59JrKvHJu8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670713268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RAobAJDhnMfMrw100Rt9Jr3gbpGAJeof0vxby2hwwp8=; b=JiURrLguyb+R0XyJ/Ymqjxt5rPVbQ0NHEZatNjeMeftmBAeGifyTj4GTr7XGs1iPkgtu1q KHCD5NkhLx5mnS0QpsPye7DehYAvSp/CME0TMS4V36Zlxk3+kjiOT80u0QyaFXoksqJ04b R+vN2Opnl6o89XhrIB14KgDzbUgwFLA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-10-ezcSLyDeO-2eKLQy-x5yRw-1; Sat, 10 Dec 2022 18:01:04 -0500 X-MC-Unique: ezcSLyDeO-2eKLQy-x5yRw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF95E85A588; Sat, 10 Dec 2022 23:01:03 +0000 (UTC) Received: from llong.com (unknown [10.22.8.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93B8140C6EC2; Sat, 10 Dec 2022 23:01:03 +0000 (UTC) From: Waiman Long To: Catalin Marinas , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Waiman Long Subject: [PATCH 0/2] mm/kmemleak: Simplify kmemleak_cond_resched() & fix UAF Date: Sat, 10 Dec 2022 18:00:46 -0500 Message-Id: <20221210230048.2841047-1-longman@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A201780018 X-Stat-Signature: b6ij331pfgzs8833cxxhtkizb3sj45zf X-HE-Tag: 1670713269-465547 X-HE-Meta: U2FsdGVkX1991GUSB5GqGupxxsgP/4csZMeYYMhokwuJLUZqpUCZFI4gGQc15VBBQ0IQqMVtikkAgwrdWeKmtnvH/c2kVbAx872/seAa1VC3PHn+Lo0gask2ukD2lHKbH3GTOkb/LqV8Sabn48MVpaZJ4OIBfgP2z00O/wKrp22FYDJVsRq1fZbPJ12N5gVqZ56DsXmeTKqFet1CmA0eb1uHmZMnpFufzJg78qHroZsoHu6e420sv9Th/kWJXn9X8JxH79+r1xjjoNJ+yrYD3WTiaIWfUIpwHjqDra4b4S7CCv8x7kjhGL7s5orZn7ojFSdNd3z2Dvy3nNOEQxijJM75oM2dmKw5z5/e2I7Id6Ih/ypnZe7rq4IURGPLIq/ixugJlvYwHnFe3+xX8SPcqDUwkc1BHqMRf1INyXbOtq80HTUhXltj2RBI9sFSPfxR3SWQyblYtXMbH4ItGOi8bqF4NLzYUpYpf/sG6TCuyzQ7tSJimLmXkmNxYfXjCFrqZlmRnH8UP46Hm8BWi3nuDU51Pf6+AsCcBKN08rji2nbYlr/coRf/Jt+z+xza3c7eRCY+yezI79maiuJnX8JZeYnIKFdVQAEQZajYTXNfXHPZCDoD/1tsjR8HYvDB5fM86Ol5UFjdWjEJSJ8+WdlUg9QVlqNnz0ZwXixRdHXYFMiQk4cuZ64YOsoiMd7p7N73TBZJ/ljkQIIdFRvLLgPe21l4bgTCzPlkQzZQ+pVu8uXRCi2bHZO5ZAvdxxVo3dnQkTKJI/0VDzf7pGMZxuInN+JY3p2imqFM3nzGSnqHlSvA3fOPCUmTa4Oz5zN9c896bP5RYqHNny3rWaAellz1csrOpde6hZbA4/qo6fwjs2HjffiUqTYXg2rDOFZFKVskKmwctJD9BXMLvhm0zoKA6uwW/NsU2Q2b7SGoJ5p+3VTW7BVmJsdHM4zJzvrvz1VsJzs3eOtGioc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It was found that a KASAN use-after-free error was reported in the kmemleak_scan() function. After further examination, it is believe that even though a reference is taken from the current object, it does not prevent the object pointed to by the next pointer from going away after a cond_resched(). So the heuristics is now changed to restart scanning from the beginning of object_list in case the current object is no longer in the object_list, i.e. OBJECT_ALLOCATED flag not set. While making the change, I also simplify the current usage of kmemleak_cond_resched() to make it easier to understand. Waiman Long (2): mm/kmemleak: Simplify kmemleak_cond_resched() usage mm/kmemleak: Fix UAF bug in kmemleak_scan() mm/kmemleak.c | 59 ++++++++++++++++++++------------------------------- 1 file changed, 23 insertions(+), 36 deletions(-) -- 2.31.1