From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C00C4332F for ; Fri, 9 Dec 2022 08:05:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF3F98E0003; Fri, 9 Dec 2022 03:05:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA3C48E0001; Fri, 9 Dec 2022 03:05:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96B9A8E0003; Fri, 9 Dec 2022 03:05:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 86C458E0001 for ; Fri, 9 Dec 2022 03:05:13 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2D4591C5F9D for ; Fri, 9 Dec 2022 08:05:13 +0000 (UTC) X-FDA: 80222032506.09.5162196 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf24.hostedemail.com (Postfix) with ESMTP id 86FF6180012 for ; Fri, 9 Dec 2022 08:05:09 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Gci/7UCj"; spf=pass (imf24.hostedemail.com: domain of error27@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670573109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=8MTh1/zb3xDQSgK8VDwvbQOChLJ5+CGQoP/vrPxCnLw=; b=qKbEgwoz68tsYPU7UgPhHhfRYv4YWOxon17MrBCyd3l6bTtHn+Sdp+wfUXWtGiOdAIua+B BUIq/TGEQpprb66HYuIijIXwQoX9fFXkITTM7lr7PwZfIf6a77CBt8qrXyaxnMO/Z7u4ho 7LNVv/iobxXZX6tENSFKR28lu0xu99I= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Gci/7UCj"; spf=pass (imf24.hostedemail.com: domain of error27@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670573109; a=rsa-sha256; cv=none; b=H1N7VoW8lV91AXsYTjGOttL3yKI3gnStOyTzR4Whcuh+sRf8PER4t+I5y/uI2ayfVj1AaT 4cQkkr+TSAgDIEHmXgMK04HEOdGD3A7igmq7nvkYzo29+J0+/FQklMud8klJSxOu7ZdRk5 8vKrKHekbwwtxKvywj5KFu66+u3IjsM= Received: by mail-wr1-f47.google.com with SMTP id co23so4394791wrb.4 for ; Fri, 09 Dec 2022 00:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8MTh1/zb3xDQSgK8VDwvbQOChLJ5+CGQoP/vrPxCnLw=; b=Gci/7UCjFncxjCd6QYF1nPoMiT8KfI8pAmt+LfPvb8bGW9Vk9HmdA9HNs/l5UjUgxg xhs6uhMJraEebv8Xow+gtfb+3hlsavJl82eqtINytzhU6cvHPQsATrfb9DFJqu8jnKpO VSTZcZcS8t/8HiuHexXYE1h+RO8k4Ja8ytGoAiw79rAsn/EI7pKmYhGX3iadjud7YFgy PWu0xVTUyWH/RXetvoMT/bJhGxt9tYgVLjW2k5GGMl+mcv+9eUxdw57sO6r118Glhyuq b/uAF9f/cAcITyCnpnBvbfIMswEddTZPq2H9VH6DkXCVDQgwf6uXx/LERY3G3Nvdrdfu 4vyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8MTh1/zb3xDQSgK8VDwvbQOChLJ5+CGQoP/vrPxCnLw=; b=u0bg+G3tluqLsbgcCVZ1fa3coK52JkkvYDKPeGj2mOBC7f9WADczoHoaxdPZAgzrmb E/v0X7VaeERE3TOV18wf+Z3+N6AXqKJjSmrgvoKlt6D7DFHm60sHYUbTilNSCgGyxB8a 3UALSph2nA4qGxdr1uVHBC4ZawFnmlb3WpLPYD9RbIQO8+Fmwh9k0sbN2Fy4izctwMjp UDOc1A1304krgtDZG4+fcT1P8X2OEOwWI7sm9wRSmy1OtBw9ZMD0zMzkHkBB5NjTLwEz oxCEfzW1H4iLP7mIcSfba3d1HeGMrBZEeifoyY9XOtm+kpvXpr56ceQh9p2hP0YJARLp oD+Q== X-Gm-Message-State: ANoB5pn9Nz0sDUj/0a9UoHjZzM6qF2XsvuFT8XNTa/8KXbweUNeIWl3V qHZlsY0LFTJwBm8yr3LyWFI= X-Google-Smtp-Source: AA0mqf503FUJhjVxJcKPl2rUiRow6EtEqOePXG6oAYqnueoYW8W375miZorzIfC61HqCTxugiyhAXw== X-Received: by 2002:a05:6000:170b:b0:242:806c:8612 with SMTP id n11-20020a056000170b00b00242806c8612mr3983198wrc.7.1670573107961; Fri, 09 Dec 2022 00:05:07 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id ba17-20020a0560001c1100b0024245e543absm715324wrb.88.2022.12.09.00.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 00:05:07 -0800 (PST) Date: Fri, 9 Dec 2022 11:05:04 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Rodrigo Siqueira Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alex Deucher , Harry Wentland , Aurabindo Pillai Subject: [linux-next:master 2355/14039] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:2621 planes_changed_for_existing_stream() error: we previously assumed 'stream_status' could be null (see line 2611) Message-ID: <202212090127.VwvK4jYU-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: tfj638f7tiao638r8q6dbaopwd8zsamo X-Rspam-User: X-Rspamd-Queue-Id: 86FF6180012 X-Rspamd-Server: rspam06 X-HE-Tag: 1670573109-468659 X-HE-Meta: U2FsdGVkX183WghtLrfjzoYpprTugPtGvPUlCynQQMLlfsSVFf6s27EDi4WATdqRRPfdXluk/Zk504Pxz5CJwQtZ6t5jrxJemfRCZSzkX8s1BRZW/dA421mMtyA9/SQugqHSwj+vPnVV1zOKOaacJXWLNHAUSO5avM+4OjjyBi485WgZo4SPmObhbOUd1jnNoqZfY26CNBZAcgL2Uwch692W9+mIqfrrL9d50lE+t/tfTp4al2r+v3fmdruvLw/u9Jpq/DDHB+oMX9qrMs9EuYPa6WZp67G4BwZVrUM0gBa9s8ZHhZB2N5GKXsEI7EBkdUx9hZUeIZvZCdVv9zFHJV0NU797mRn7AOZvm4SgCc2RG405qF+dimSad4fYnf8+NjX1v7RJYRIoN8LUGtE6uJ+h8b2Wi3Dr3KLMCcHPY8vTeMuXRBnCL9seMCXtgrqR5L8fAlUbEHGbrM/831xWMeuzgEPq3RGz0pKF+nIEg6zyonPa9n+t+BuUKJkudJC3tZPJ0ER9e/w83aQdkTf91dkDtKDW/0eo1MU1s8zQvXQB32Y2zVrKoZyFBTKpF2FRP8esS/33//+R4rTlafluCqjPR4qFLKU4ywnhu15llLlL6u8BAoFhe3Y+Xhs/D5kipMsGszb2FXrCK/IEQMYNhUsSlXvCfdgms2miWTT/ON+xrW9kszA9+DeQJBHO5erSdVRjswqDYefZ/aosLAd/+GddUwyp+EK1wFPnv+UmLO0h9St4V1mk7d+zeq3or6EcYcS5el+rwD0lQDuacpNct+GRXnyrBQJi4DUqUeQUqcvDs1nutloBSw6OV9la+kwwFCgDqpM5AZaUhQkobUS+GfaGjHytphXz3UXUof8Wh+aMYfthX5bVsvCHzhp4EnxKhXWqVHOvnMRSQsaFXpZ2mPezseUc4nAPvrFsHh9JrNK5Kz4xc385JXEzoOTkRLOyQ2ShIiInkR7sZbpvl39 QZi23tem v8QiowOFKXz8sGJdRJMyk3HEIT9Kw1myR+7laxLxSJpR3QkOwa7rMUHvbO947RKl0jeotjAklxRvDVwbLwfhzQyTvraVeEti82a7TTanQunWwbiamwxociTvE64TMPqp+ZQVA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f925116b24c0c42dc6d5ab5111c55fd7f74e8dc7 commit: a5e39ae27c3a305c6aafc0e423b0cb2c677facde [2355/14039] drm/amd/display: Add function for validate and update new stream config: ia64-randconfig-m041-20221207 compiler: ia64-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:2621 planes_changed_for_existing_stream() error: we previously assumed 'stream_status' could be null (see line 2611) vim +/stream_status +2621 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2596 static bool planes_changed_for_existing_stream(struct dc_state *context, a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2597 struct dc_stream_state *stream, a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2598 const struct dc_validation_set set[], a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2599 int set_count) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2600 { a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2601 int i, j; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2602 struct dc_stream_status *stream_status = NULL; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2603 a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2604 for (i = 0; i < context->stream_count; i++) { a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2605 if (context->streams[i] == stream) { a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2606 stream_status = &context->stream_status[i]; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2607 break; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2608 } a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2609 } a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2610 a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 @2611 if (!stream_status) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2612 ASSERT(0); If you wrote this as ASSERT(stream_status) it would silence the static checker warning. a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2613 a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2614 for (i = 0; i < set_count; i++) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2615 if (set[i].stream == stream) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2616 break; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2617 a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2618 if (i == set_count) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2619 ASSERT(0); a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2620 a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 @2621 if (set[i].plane_count != stream_status->plane_count) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2622 return true; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2623 a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2624 for (j = 0; j < set[i].plane_count; j++) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2625 if (set[i].plane_states[j] != stream_status->plane_states[j]) a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2626 return true; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2627 a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2628 return false; a5e39ae27c3a30 Rodrigo Siqueira 2022-10-18 2629 } -- 0-DAY CI Kernel Test Service https://01.org/lkp