From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D8FC4332F for ; Thu, 8 Dec 2022 21:52:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C42D8E0003; Thu, 8 Dec 2022 16:52:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 174AA8E0001; Thu, 8 Dec 2022 16:52:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03D348E0003; Thu, 8 Dec 2022 16:52:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E9E238E0001 for ; Thu, 8 Dec 2022 16:52:06 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9FF9CAB74A for ; Thu, 8 Dec 2022 21:52:06 +0000 (UTC) X-FDA: 80220487452.04.C107C0C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 24404140005 for ; Thu, 8 Dec 2022 21:52:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Erh52IW4; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670536325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OP+jK1guRPYhk9Z/j5d5WoeGsKUIf6I8/87cNoXq7AY=; b=mTsFPqOa64DX18igw+sp28VK/4lYZZuC+gGhgMOyBwWBqTGs0SG6x4Q84njyBCVUhtGqG8 a1WaRvDLvSrpLP6vix9HYxCcCUc2sRCW+iDdkHH4bZ8JfPa+n2fZzBrdo/LyuZ6lN8y+/T yU9gPA5WRRyHiKQBcNIKD9AoZSnOBGo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Erh52IW4; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670536325; a=rsa-sha256; cv=none; b=4yC+wyiGcKZzb4spITj1Me+zfhjAvO4k5EdHdG/nmEtjI30beWDoP93UqZZmTPukK3X1HI 7JIeLJDNLGzSq7ZZ8O5Mf4UTtWTynbjNQtUmrR5pgEIXsZFXgpgAW6OVKjDLx9dFqgLlkp yPHMKAOftARP6Cr/5GpFHQORg3xmwtM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1FE606207F; Thu, 8 Dec 2022 21:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0661BC433EF; Thu, 8 Dec 2022 21:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670536323; bh=/G9rwfNNi1MXUfSnwUZ+XorKWRaIE52XaI7gJIzsvmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Erh52IW4k2ZEKHIjEznhcfh57Axz56QI/4fjinktS4BXRfWZG8inFM8bBJNZu5zj+ qqO1FVq8RtGOpHJcudE4u9FJh4aNCjxiaL2RVMD70V4U9i86Og/yTIxaRDO1SfAoNV MMvgHpf1IrXf/82zQQVb798v0LwpOInszswFKJObyUEgVKOQgCqR9xkNylewhnXKCz aVycStGuOgOsRbNVz0daxFJdAkqSCN08jX9qwwZjwn5RJ2w41a4NXw061nkuKN8BaG TYEqCUfzP79BqS7L9NxfVBe0m6TTgdSpYB9T4fwULCtX4zjt4qJBGOK/m5uIK6GKGg 7+wCNx5kPZXfg== From: SeongJae Park To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sj@kernel.org Subject: Re: [PATCH v3 3/4] mm/damon: Convert damon_pa_mark_accessed_or_deactivate() to use folios Date: Thu, 8 Dec 2022 21:52:01 +0000 Message-Id: <20221208215201.116835-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221208203503.20665-4-vishal.moola@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 24404140005 X-Stat-Signature: c4e8sr91zar3rre95g8szbdgi65zyuau X-HE-Tag: 1670536324-243083 X-HE-Meta: U2FsdGVkX1/7RgU4tjYRvOqrUKv+CcSLryJxync830D7mRvh/dJbCdMk8KtOJ+lCRszhuMpCYZSFRPeyv55+zcgoFlcbVkRv3XwfyPL22uSdv9kXFToMkGj8DpXmsFBnb+QML0g+rl2PfDux5/rW5sspTvVBZdaqoi/D7LmhAzamxHmRZe52J4anvJRbwdqkHwM2BYgD6KovnsnsSJXt3rDaxN144nI3oc8gKzw/XESoXwqBOzOgkCtWnENINFxEsvw5SiVTHlnX3JKqTm3SMJKMuNoi0VyaTfqxZwSGASPKdyuoW6vQPF3IO+MhlMMR4NLjo4G7szpdqwCnOGRxMBRiyShnWp7hudxO8VTUuXUZI3PWrCp8e94dSnncFe8amPRQyYY/9LwFZcvg0SwaqBw9PmSEkRDWVuOQPnNjGFHB1syoZnwJqVToKhOaZtjuuTdZKVUkE48T6ch2nYGXmifG+QQlw2T9UbBhkx74GSOdMaf6p+SvKRAtZRLc4p729krMbGkaN0buo+QlvfLmb0sebJ1Su2ezpFnE2sm37V5pSPPBLkyxJmZKZUuMSrHPVRXdJUgBUb6wo6w1RmbPUR3hjO1lQ1+IUDLNKY02H0mnxOv1vKH66m5SRIKL+ZNTr8tdcaGnVXdcZmLvtcc6gRKqNcL2o8igtjYzFXuwPAYTinsf65z0ZbJuuYiEDwuAnUIusokUOJPmyARDdskHe+hyYvcXe2tCMIVJKcFrGv8qR7fMJ6q1Q8KhhbZXivXHA5Nat/yhsAscGs+52H7i2b25ZSfHh++T2V9b2H/XPBk3qsr1dpwj5wSQDe12Soyx87d+YqW8SNJnovTmlqyfAJ5+0tov+TI00RlwpKnBTB8ZT4MH2ENbw2pOhnhlSLIA4fyHcZauL9Yi6PUxDJFEpN9HOsXgY/6qt4LgIQpq8RwVCslUhP9befNgQMzNnqbFIdtWE5FRQha4djhexSK YvIrHSH6 V7mBa50hj46xeblI9LorJ4EoVx3Xau5uVXqKALdnHJWUtbmbNNvN6YdaiFddguMiFX4EWjRtESuYKKGWwvr+yKP3ZO/0GnwRe68B4H6E9+W96o3iaXS/ucTpWjW8KPGLA7WikDbGfu2GkALt1w2Bqqh+jNaSqB+MqsnatYZeO4SDY/tz1AUeUe52Xog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 8 Dec 2022 12:35:02 -0800 "Vishal Moola (Oracle)" wrote: > This change replaces 2 calls to compound_head() with one. I hoped this to be more detailed (e.g., 2 calls from mark_page_accessed() and put_page() with 1 call from page_folio()), but it wouldn't be a blocker as we had the discussion in v1 of this patch. > This is in preparation for the conversion of deactivate_page() to > folio_deactivate(). > > Signed-off-by: Vishal Moola (Oracle) Reviewed-by: SeongJae Park Please note that this conflicts with one of my patches that under review[1] at the moment. I will rebase and send the patch again if Andrew merge this first. [1] https://lore.kernel.org/damon/20221205230830.144349-3-sj@kernel.org/ Thanks, SJ > --- > mm/damon/paddr.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index e1a4315c4be6..73548bc82297 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -238,15 +238,18 @@ static inline unsigned long damon_pa_mark_accessed_or_deactivate( > > for (addr = r->ar.start; addr < r->ar.end; addr += PAGE_SIZE) { > struct page *page = damon_get_page(PHYS_PFN(addr)); > + struct folio *folio; > > if (!page) > continue; > + folio = page_folio(page); > + > if (mark_accessed) > - mark_page_accessed(page); > + folio_mark_accessed(folio); > else > - deactivate_page(page); > - put_page(page); > - applied++; > + deactivate_page(&folio->page); > + folio_put(folio); > + applied += folio_nr_pages(folio); > } > return applied * PAGE_SIZE; > } > -- > 2.38.1