From: Kairui Song <ryncsn@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
David Hildenbrand <david@redhat.com>,
"Huang, Ying" <ying.huang@intel.com>,
Hugh Dickins <hughd@google.com>, Kairui Song <kasong@tencent.com>
Subject: [PATCH 5/5] swap: avoid ra statistic lost when swapin races
Date: Fri, 9 Dec 2022 02:02:09 +0800 [thread overview]
Message-ID: <20221208180209.50845-6-ryncsn@gmail.com> (raw)
In-Reply-To: <20221208180209.50845-1-ryncsn@gmail.com>
From: Kairui Song <kasong@tencent.com>
__read_swap_cache_async should just call swap_cache_get_folio for trying
to look up the swap cache. Because swap_cache_get_folio handles the
readahead statistic, and clears the RA flag, looking up the cache
directly will skip these parts.
And the comment no longer applies after commit 442701e7058b
("mm/swap: remove swap_cache_info statistics"), just remove them.
Fixes: 442701e7058b ("mm/swap: remove swap_cache_info statistics")
Signed-off-by: Kairui Song <kasong@tencent.com>
---
mm/swap_state.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/mm/swap_state.c b/mm/swap_state.c
index eba388f67741..f39cfb62551d 100644
--- a/mm/swap_state.c
+++ b/mm/swap_state.c
@@ -418,15 +418,12 @@ struct page *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
for (;;) {
int err;
/*
- * First check the swap cache. Since this is normally
- * called after swap_cache_get_folio() failed, re-calling
- * that would confuse statistics.
+ * First check the swap cache in case of race.
*/
si = get_swap_device(entry);
if (!si)
return NULL;
- folio = filemap_get_folio(swap_address_space(entry),
- swp_offset(entry));
+ folio = swap_cache_get_folio(entry, vma, addr);
put_swap_device(si);
if (folio)
return folio_file_page(folio, swp_offset(entry));
--
2.35.2
next prev parent reply other threads:[~2022-12-08 18:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 18:02 [PATCH 0/5] Clean up and fixes for swap Kairui Song
2022-12-08 18:02 ` [PATCH 1/5] swapfile: get rid of volatile and avoid redundant read Kairui Song
2022-12-09 2:48 ` Huang, Ying
2022-12-08 18:02 ` [PATCH 2/5] swap: avoid a redundant pte map if ra window is 1 Kairui Song
2022-12-09 3:15 ` Huang, Ying
2022-12-08 18:02 ` [PATCH 3/5] swap: fold swap_ra_clamp_pfn into swap_ra_info Kairui Song
2022-12-08 19:08 ` Matthew Wilcox
2022-12-09 2:00 ` Kairui Song
2022-12-09 3:23 ` Huang, Ying
2022-12-08 18:02 ` [PATCH 4/5] swap: remove the swap lock in swap_cache_get_folio Kairui Song
2022-12-11 11:39 ` Huang, Ying
2022-12-11 11:47 ` Kairui Song
2022-12-08 18:02 ` Kairui Song [this message]
2022-12-08 19:14 ` [PATCH 5/5] swap: avoid ra statistic lost when swapin races Matthew Wilcox
2022-12-09 1:54 ` Kairui Song
2022-12-11 12:02 ` Huang, Ying
2022-12-11 12:15 ` Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208180209.50845-6-ryncsn@gmail.com \
--to=ryncsn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox