From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B34C4332F for ; Thu, 8 Dec 2022 16:21:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FB3B8E0003; Thu, 8 Dec 2022 11:21:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1ABED8E0001; Thu, 8 Dec 2022 11:21:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09AE68E0003; Thu, 8 Dec 2022 11:21:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EAE798E0001 for ; Thu, 8 Dec 2022 11:21:33 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AE7D5140D4D for ; Thu, 8 Dec 2022 16:21:33 +0000 (UTC) X-FDA: 80219654466.22.B875D45 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf20.hostedemail.com (Postfix) with ESMTP id D1F641C0002 for ; Thu, 8 Dec 2022 16:21:31 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="g8P4/eoj"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670516491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hrJ14ayLT7F+1zAXfd85zeuS9jwgRhVrcw7Y0+tLb6Y=; b=mXDySALCr6KQn3b6ABpWGKEWFPxggM7mOYeFgtTolWtAXr5E3H3ePvr/dHuCfrMmupjmYL 49Cpv3oB/baGaK0rRWBoXQI+ntz+sWEpvZZ8UXjeZ1UAxO8e9G3d4eDxIDxh9ok59VDCHN qPi5J1tXojoFWlO02Sb+ptSj2ZpfkSw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="g8P4/eoj"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670516491; a=rsa-sha256; cv=none; b=gaj7Cbzu8CUt7LJfBbP11HiDaJ85QC4/OWq9S1f2pxUkS5I9r7kCgrva7aMRIzMP8IBdwy sEK0yg1Utv9DFFkKlJi6R+97FkwFUeW2FDgdtmwVFk7JAdSVWoREJeBDHBzv6H/oTDlg9u 14Qm+GZHStwebS8jwgOjsIybp7ZfveM= Received: by mail-pl1-f169.google.com with SMTP id m4so1975076pls.4 for ; Thu, 08 Dec 2022 08:21:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hrJ14ayLT7F+1zAXfd85zeuS9jwgRhVrcw7Y0+tLb6Y=; b=g8P4/eojTrI2HBCiA4zp/WCQXL2NPFnOjDEnV/senXcKqmtpvz8/sl35IibIlf56Xb ZynllzhNzGK/ud3dS9sa5QvNDOO/hi6CMtTwElRCKkJcwqr16oyYBna2FSFSeQmU9wko JEFCS20QBntq7LbVs0aCBuYQzFzL9J9+gjq70= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hrJ14ayLT7F+1zAXfd85zeuS9jwgRhVrcw7Y0+tLb6Y=; b=hq/17rv9jNZLdqKabhbUmLYi/ZQzqLRpkQoe742ZD6/P33amtM1vTMGlTstUIUAaDF 8bwGHI6rkLJYA1NULKxbFJ9RNDl3DxyQ3wTz3KyjCgU8SAv5wikf90RGbPPJh1EOv3aL AW3W8C+2mjida+AMQ047jCAdwLaWFAfhA6cwVfAQLIktyaoA11qasEm080twbhrIpP3L n4AW70sTe6X8n95ifhgVwD2shqRg2V0EjIHKbeCxxCvksoA84ql7d1RQqtzGfbVo7ajU yJBaIAIK0AZjvDehY+sOaBOhS5tP+qgUi49P7YudrRGI/z6aUzerZzC29h/zRVSeEX01 0yzg== X-Gm-Message-State: ANoB5pmu7VVrsaedVBHLvzOqLpb6Iz9Xpz3XzTiuC4qzg2JDy/DNDkSj dKXYp47yhIcdt+u84va/mrZgGw== X-Google-Smtp-Source: AA0mqf7RMfVU6OSBfzQOkqOeCkx3TWMEkSgjK0ClXrEprodhsyI5WvH+XKjOP1ImKWPf16MmgfyfaA== X-Received: by 2002:a17:90a:9f46:b0:219:b1db:f7e3 with SMTP id q6-20020a17090a9f4600b00219b1dbf7e3mr23917526pjv.64.1670516490729; Thu, 08 Dec 2022 08:21:30 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id pc16-20020a17090b3b9000b00212cf2fe8c3sm7924158pjb.1.2022.12.08.08.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 08:21:30 -0800 (PST) Date: Thu, 8 Dec 2022 08:21:29 -0800 From: Kees Cook To: jeffxu@chromium.org Cc: skhan@linuxfoundation.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jeffxu@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org Subject: Re: [PATCH v6 2/6] selftests/memfd: add tests for F_SEAL_EXEC Message-ID: <202212080818.28476A4@keescook> References: <20221207154939.2532830-1-jeffxu@google.com> <20221207154939.2532830-3-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207154939.2532830-3-jeffxu@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D1F641C0002 X-Stat-Signature: xj8upi6azj4ki8un8i6uyqfdned1n5mf X-HE-Tag: 1670516491-735059 X-HE-Meta: U2FsdGVkX1+Me5zxWimXKigIC0pkQYyT48pCScfY3YRAmA2jOVYNBU3KmPzcrwK4fbRQ+RdcmiMzCkn/UDCsosWRq7AQ1mHparolCrp/z4IvkBrdOIUREkBh6bhkvZ52I/Vig0Pf2V7qgluW4yE8E/o1tlCq6ssLD1lHGWGAofk1krAYvUPybCezVmzVJ1WwWNgZhWXjd7n+fhtMaIGsnSAts1YUle2fe9Gt7d5SW5cGK/UlPpC2QUZEXx/Dzq+d3rCr9DboYCqciYWCzMB5L+lGMcJdH4Y5Jgqc+/9O52u43k4x06GUrI58rArL37j9D6cD0y9XIYPwL0I9hMBNtBqJP9MqtydryGQXA5oo51EmI8EbK1ggb3xxc9FvXsn+KSeyllZ26rQf5ibM282Im/J2ivvBB8BOefPip7rF0xslXdy6fv5QwU8dmKUMnw2Y4uy+tmHUQB4E6cMyx0NjRUcwpzte9HN810FaoOC/2UtERe0BS0bbIJhvNAsShfxpReWV7aKx+ocbqKrciQ3fsp4thWt8axIrhi6BjjVFv9IRV4qaE3KZwWuaDeabjqkcbAC6N1xfgXMlXjly2hJxvfCisHCJ667Ao+wlvB7O/miMMtUVJLgAU4cra0geseUJVTf+5717Mv7VXEOXNFs1OUSS2RFpzYex/58lhuxBEWpoF/6mseRqLBCpd/bqjBFZc/U9Fg1ZYFG4mC+mcff9ajou8H2w3xsCzYZ5QXoiH8DwGqtLm8o/S43QxHSXMaPb/0T6r4tTYDQ/CT1Xm4PqTIygvfipfJ/ed4j+vEcprLYryc5RjUg2jmMcNPHp9XHK0z+RTYcsw0FGsD98xh1OJASV4d0KnPiUn9ntSiRip+rH70EZuwH6JULAf7WQtgA/XozII+Ot9QU1bHIzF0Ek2GzZiUo3Ss0nvhk2SrfTDLLR1M2ZnblFRdGT+/J37vnZ0S3/gNnElGerkQZTtwa xrPXcTnV Y8tY39DfHRfYEKOhrXvbNjilagnxdrSabKj1/FsUCh5HX2Zlc+TxWGacjBJ2/TBKMCyXYpc6aIxN169Q9UOWp3d2udIBqasGjyY/KhVCMmOzy20ewXI9fn1NSyKctgZ0hmowfG1sPofRNtj0s+zc5CtW6/Z6hw2/TBm1PTU/GGV65FOqr2cqNa9Wu4rzEJoJFUkcV9YCaaKJ07/wecJzQ0nueEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 03:49:35PM +0000, jeffxu@chromium.org wrote: > From: Daniel Verkamp > > Basic tests to ensure that user/group/other execute bits cannot be > changed after applying F_SEAL_EXEC to a memfd. > > Signed-off-by: Daniel Verkamp > Co-developed-by: Jeff Xu > Signed-off-by: Jeff Xu > --- > tools/testing/selftests/memfd/memfd_test.c | 129 ++++++++++++++++++++- > 1 file changed, 128 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c > index 94df2692e6e4..1d7e7b36bbdd 100644 > --- a/tools/testing/selftests/memfd/memfd_test.c > +++ b/tools/testing/selftests/memfd/memfd_test.c > @@ -28,12 +28,44 @@ > #define MFD_DEF_SIZE 8192 > #define STACK_SIZE 65536 > > +#ifndef F_SEAL_EXEC > +#define F_SEAL_EXEC 0x0020 > +#endif > + > +#ifndef MAX_PATH > +#define MAX_PATH 256 > +#endif I'd expect this to be named PATH_MAX, and it shouldn't need to have an #ifdef? That's a regular POSIX define. Otherwise, looks good. Though it'd be nice if this test use kselftest_harness.h, but that's not your problem. :) Reviewed-by: Kees Cook -- Kees Cook