From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185DCC4332F for ; Thu, 8 Dec 2022 16:16:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 819DD8E0005; Thu, 8 Dec 2022 11:16:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C9A58E0001; Thu, 8 Dec 2022 11:16:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B9448E0005; Thu, 8 Dec 2022 11:16:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E0E68E0001 for ; Thu, 8 Dec 2022 11:16:22 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2926AAB74D for ; Thu, 8 Dec 2022 16:16:22 +0000 (UTC) X-FDA: 80219641404.25.BB4C2D5 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 80605140024 for ; Thu, 8 Dec 2022 16:16:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hTN6H1OV; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670516179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5lfY71TAViOQoe8YQHZ95RIFrQ+A11ZWICcAERJdWds=; b=KFIbLUD1iZ0PkleNjvB2T969iMSbab0dEhVuffEuvuHYnjVR3nVCDNFVkV5qgpUgkWu4U2 5sw1hR54C1pCDCN3q6zSZbMJTHHfjf+WQhGors374m8Em9dGG6+Z7mXQIEpk7Kw6CjpmMr AjroO+Xb80Wlj5hyKKAhe5SUwbjxHLQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hTN6H1OV; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670516179; a=rsa-sha256; cv=none; b=b+xioLMf6l4Z8UjzVUA8vO/imWPzgkGLWqCe3GZVOrs7hYYwvAGn+Bze9GIkqycbIg/K0Y u8/sL/ycPe77SVHcN6D4arWdE/RCACRwpqAfdtzukBnKO/zJtDPVWDlPp2s5RbZVRAY2Eh AG2zpZJgWSG3HhmshjSLPv2AY58ICmk= Received: by mail-pl1-f174.google.com with SMTP id s7so1956221plk.5 for ; Thu, 08 Dec 2022 08:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5lfY71TAViOQoe8YQHZ95RIFrQ+A11ZWICcAERJdWds=; b=hTN6H1OVBAFSCwo/nxyNAtyDzh106TmfYVB4USPC+RT73HCInYFg1auXkJ182+uwoX QrnwHu8oZr+KHn59TSvHWnjU3dea2id9D+YkQ6cfcXskt11hkUTHL3ZkGVE9SE2x66/4 epv9mfaRYkC49+0DD6wlucjfoGmRJdF805Ny8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5lfY71TAViOQoe8YQHZ95RIFrQ+A11ZWICcAERJdWds=; b=Bqdi+QZeaqs2czw5JcF3Jr5l+cPjBF4p3XqZ2UJg3hDHMdJ20sG+MVBa+WBDLvr/yo 8p1du1VLXVqLZrdgYU2fzC+n50yKuSbMHLLeAX9rUcTHBFh5+5r5wVNCKPkqQDj+Ie/l gh0EB+lW7hgMW8bQ3T1D8Duyilw7HMcYIXuYoEWKBBVHLBPJgxRgG9PDJEH/yONtNnqX g/I3waHbhX5Uw/JJbb1uuwkkA7eVdg2z+QyLFfWmxW9akqMjxUGvmabN43sQX7otVR/2 yPB79hTcTbqVCehsw4XKc3vcntLJMkRDKAON/jPRc5gpcuIprMSaFQblra3O7kDFbjih EGHw== X-Gm-Message-State: ANoB5pmhxPIwFBTBNuRSohwbUklYfweWIecYy/DzL6oOSB2akyCL4l8F dHkLjIVswJja2YEtdrv5KvVX1w== X-Google-Smtp-Source: AA0mqf7HpLsd2uW2CYrl0cCNhuhZbciNR3eUqo8jRlRor65NEX26E+Iv7KyDDQfTOVBuaHYoLQ2iHw== X-Received: by 2002:a17:90a:ad85:b0:21a:1d94:568f with SMTP id s5-20020a17090aad8500b0021a1d94568fmr4818888pjq.51.1670516178264; Thu, 08 Dec 2022 08:16:18 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w6-20020a170902a70600b00174f7d10a03sm7377321plq.86.2022.12.08.08.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 08:16:17 -0800 (PST) Date: Thu, 8 Dec 2022 08:16:17 -0800 From: Kees Cook To: jeffxu@chromium.org Cc: skhan@linuxfoundation.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jeffxu@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org Subject: Re: [PATCH v6 1/6] mm/memfd: add F_SEAL_EXEC Message-ID: <202212080814.821C05264@keescook> References: <20221207154939.2532830-1-jeffxu@google.com> <20221207154939.2532830-2-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207154939.2532830-2-jeffxu@google.com> X-Rspamd-Queue-Id: 80605140024 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 5ch6c34yc5kh6sgkcks1ded68arheb7s X-HE-Tag: 1670516179-920444 X-HE-Meta: U2FsdGVkX1+YdQsRYSf/8OK+/p3mr0RX6f95FODhQ7mysmRwzph8BSnBrkxFVIlgXMbe69ydYrdpbfGDLH+L+OKAWdM44Yrs7iJDrYftKQ4K6JB3AnxegXfYyej04LoMoJtadaV/xBbrNQ+OtBEiy6Q7MfkNCY+stir86P/18YAz4+p2o3x9acLYnVwcl/i1KKjVLNsm2BJTUHOvEN58uiV3CSWNdZqnOoPyDG1tlnrnYutc754BU57JM/oWMTo4Ofy2IIohYco/yhZ8YjVd0noX5qZhBi5WTeC9N/KTSPwaOvEXqojnPt7Eu5ijc34QI6u08ZDrbYhwGqap0P4E0DzOOu9N2i73c94otJmZhZejQ8nV/NmnOM76oALrHzAYYilxYY9G412RYzHSXmhYjnCV+VnilBua5TUdHEIGkxjZXBTWYVEGJdwwreAOuRWaw0uMh/HF3Tees3NsT7JWa2D/K8YsjPqqbj0KKRyfGzU7GUJSVbRM8Vj0aIroLYieVOAmG4ubNkOeRQqVF9HqAUiVL9p5myW9XnStD7biKbOqjocP+JIuSSE5+3SCC4lvnXb8T9FddxgPczYxdHXrAY645Kcyv8lBS7xuTDVOWgNDhO9MjeueK1NehlImPFhdCDVWS06JIqTPSmDGeKAIglCo08nYG5tlKamZPZM2n7bUYgBzSwDpYyvj2MxeBPyM+5Mo6K/wOfTkXIQnohFFfq1GwjFW6hIfVlt5DuF3ecGb6+O8KKiByPcAzwtYDsNQMfAcI0FCyG9WeLoxyY4uzTIiffMApmJCER6D6uNB6dRNPm71WdcP8g2E82EpRcn+zIdhG1v73Ic/68MTRRZjeQhgVMm1aF/TV9ijZXfHHlDGoxNihXrF6bWJO4UAKMDV8kFa+6LTxFNKkU/lksxN+1YpJxE0wtUF3WRtX/NGN+K9x3L/9+EM+VPiS7enZyFDDAAi46I3hAcNMlvPDNw 0kMHywVr MBnfR9FFE3PX+VHmGGccSvnlKzsaqxYwliK9G5Y6zWpzmwY6fQtLQwaNcftn/2SeYIZnpUNd2cVAL1TKjLOht6FvvK8Le1jx4TvnQSMbSObOWJjwe9q+GIKWxhDZuHACR42rn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 03:49:34PM +0000, jeffxu@chromium.org wrote: > From: Daniel Verkamp > > The new F_SEAL_EXEC flag will prevent modification of the exec bits: > written as traditional octal mask, 0111, or as named flags, S_IXUSR | > S_IXGRP | S_IXOTH. Any chmod(2) or similar call that attempts to modify > any of these bits after the seal is applied will fail with errno EPERM. > > This will preserve the execute bits as they are at the time of sealing, > so the memfd will become either permanently executable or permanently > un-executable. > > Signed-off-by: Daniel Verkamp > Co-developed-by: Jeff Xu > Signed-off-by: Jeff Xu It looks like my Reviewed-by: tag was dropped? https://lore.kernel.org/lkml/202212021443.0F684E33@keescook/ This patch is unchanged, so please carry forward any review/ack/tested tags, etc. But for the bots: Reviewed-by: Kees Cook -- Kees Cook