From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5479FC63708 for ; Thu, 8 Dec 2022 16:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC15B8E0005; Thu, 8 Dec 2022 11:13:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D71208E0001; Thu, 8 Dec 2022 11:13:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C60EE8E0005; Thu, 8 Dec 2022 11:13:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B6A898E0001 for ; Thu, 8 Dec 2022 11:13:40 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 792A5160F52 for ; Thu, 8 Dec 2022 16:13:40 +0000 (UTC) X-FDA: 80219634600.16.7989F86 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf27.hostedemail.com (Postfix) with ESMTP id A7CC940003 for ; Thu, 8 Dec 2022 16:13:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=M9dPq43p; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.47 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670516017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VEF5Kdoxdu+cKfk6R3ZwPWFH59dyZr5XNLc+TP4k1ZU=; b=u0xAOvU717p51G7oXNAQgI1b2+RGm5n/989XYoABC322WJ409ds0/97t5b0to+Fg5inW9x jn0w/GxGJpByN9jIcMYMHKPzCIr6b5Bl9GEKVyLWAEhzlCzBqDZRaaPgtb5vpQ8+3JLxqW pfDvE8pmlOA4HO/Vk617337ukTRbFao= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=M9dPq43p; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.47 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670516017; a=rsa-sha256; cv=none; b=awSayu5orSRXRUhCCLhAl4IoDKoGlpoaallsq96hJM5a3bu1T5f+NNJ5z9IvY5ctv5vieg 0sLojWpYDQKIbc/ZqwozlHOcR5Fxkk1ZCPaKNcxhQDlC5DObKGnzhyVNBSKC2wY/jMnKcx /N31GuLLkfoUGPehRz9qz4n0+58I2ac= Received: by mail-pj1-f47.google.com with SMTP id k88-20020a17090a4ce100b00219d0b857bcso2040294pjh.1 for ; Thu, 08 Dec 2022 08:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VEF5Kdoxdu+cKfk6R3ZwPWFH59dyZr5XNLc+TP4k1ZU=; b=M9dPq43pCEesdG1Pr73JFi78Hptyiq5VZqWgnsSr3kI1jPoUdQ4zxjiAhyNFqpFmZg njyxgcdxqgN0KzGHxmez3cz91qutsMd43bfVz+BmUEiqosyY0DbvL3iHrFX0td8dUCSY MTh3j9pe6XZs6CcLquyZVVbjRBXWFW2xIvWp0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VEF5Kdoxdu+cKfk6R3ZwPWFH59dyZr5XNLc+TP4k1ZU=; b=YZSxiJaj38MEX361jv1uDrP2luttq6Elm56UCQYNh/ydjk7i/Pz35207+4nLct4gTD CjizkMfI6YOONQMFxcvh9EEEk4TqIueGdNZSQFJtAI8jN4hNpFTrKb0BKJuxkq6tBAKL 8zUB7iNF/6UF4FMnOX+0hB/G4V++n5VJJc2CuUqFbz0j8K98MVJCdbuZjjbim3QaGYgJ AXFXBRZrcmYuIUR65lU3HlcqAFWK4zkQxJIfANo9t8AH5wOnCPgWaZe6FrwO4dP62uu/ sKhkvDXIbEpgcTZkOVfn9YF+1ybujvoVe9Cv61xpZxQSlIb0xrjyfXDIGPbTiQzREQoU jeDQ== X-Gm-Message-State: ANoB5plhNEUAbyI9OVBT+3FLSDw1+zcWVSbVSfihcBM8MXY1RkyW71+B xTfghqQs8g2lWH9RpQVS+PZxOw== X-Google-Smtp-Source: AA0mqf54Uql+4I53tb1lC4yydY21faKQwOpWl2+BYX9Ds95kNuRBabF3SZQkBl8QR9ooQXG7EPr8Eg== X-Received: by 2002:a17:903:22c2:b0:189:c47b:af22 with SMTP id y2-20020a17090322c200b00189c47baf22mr24668561plg.23.1670516016394; Thu, 08 Dec 2022 08:13:36 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ik25-20020a170902ab1900b001869b988d93sm16661571plb.187.2022.12.08.08.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 08:13:35 -0800 (PST) Date: Thu, 8 Dec 2022 08:13:34 -0800 From: Kees Cook To: jeffxu@chromium.org Cc: skhan@linuxfoundation.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jeffxu@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org Subject: Re: [PATCH v6 0/6] mm/memfd: introduce MFD_NOEXEC_SEAL and MFD_EXEC Message-ID: <202212080809.687CC8BC23@keescook> References: <20221207154939.2532830-1-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207154939.2532830-1-jeffxu@google.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A7CC940003 X-Rspam-User: X-Stat-Signature: m33ws34ugidn4tqzhe6jcmtwxzet388g X-HE-Tag: 1670516017-559618 X-HE-Meta: U2FsdGVkX18bl8p/5I1GjQb9FRh9ngkDhCOt7uR1cxgYCHciNapecng6mGK7QmEx9uV+QP4EKvX2MAp/dayTpE6JcSKniFMqzU1pxG6G5Z74yl/n4j8qkq9Gp2+a0oyHIG3wTFbWX4f21vbspw7WFj557N4bnDyDcmg20suDkhbqfINVtJ7eMIjkXqJS3UbkVS53oVqmBSNjKBHQ5zZqVklMfNUibXd3cfgidV0Z3abhOIGSU8ev7k80QZ98+MOd5wTlBEwJpRorAUfpwa7UVNtyoAtnXvC6tyfq1S115zkwh840twdiOncdNrkVd7J4HNxeSl/TPH3HqFAX4mYInD6f4RtSCrBF3izKtIG/+YKt9H7+OZYnx2POqJLEfz3m6Sl5P6TDLY1/j2gPOhmWhM8/cXaUvleYNECRrDzZkJXoGyhoQRB4vP1p7rIcM+zl2gAwcimoJ6aXV/7a8/ac7UIVqZwRDaZUoJ3FTE8Rr99nLyzW44Hp85YQssWAly95jr3BpeQk/dW7up/bXtziwz4lIAyQyUX1pb9P4nrE0FNvtjH6I3qjXGaO6qNGKSGNXh030tRA/byWAXsx2QQqKTaXxIH3I2ZgEkeriYMEG1yNDwzh4AKy+OzrAF7tTFfCWndkiGkfLB22P7sAvU2b4w9SmvWiAcpoAMUzg1Zrp5ERmjzbQwLUpTU1d2qWpsKhPveNKggudi76QZsqI5dxbMQIl4b5AU6Jj0jTIuWu/FEpQmBkAYcmHoTI0GtxaOWDvlMufiMX6IYnfH27Ds1Exyp/r1gw0K/LzALuOwur6nWL38B2hu8cKVjXdPEoaAzSexT7yGc8KXWMizvYOo8uUT5vO8ZlsaQSTGMwx092PYc9F3bT6g/oF6suR2mLPoBFtYh/D3QwnalEN2Rv6oyfa3B/6NxeQ6h0cTvUuEYqRrxGD3JSCZaWocw7+ezmjhp49GF5N2y47h9Z3rZ+zSG WX2UnWYh rFlhTZYALWhExbF3Gu1DalQTPLd7uuxoeU5Dw9DwCZTfCqa1ZQVqX553Urp5dMqbw9/O9R35qa3vOjvsLXrt+9k3xD6M2lMm2PpynJhj3qqROKpv/OfP5dqLyl/eTlifJtpYAWOcdnDAeIV7EgEEXbejIfj2Tl7Pq+xr6vhjM43FhSXabskfI6B7abafCCTb+0YgomYIK/XPL7H72jFAWGBCEsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 03:49:33PM +0000, jeffxu@chromium.org wrote: > This is V6 version of patch: see [4] [5] [6] [7] for previous versions. When sending a new version, can you include an overview of what changed between this version and the prior version? This helps reviewers who are following along, so it's easier to focus our attention on the differences. Also, it's helpful to version the links: > [4] https://lwn.net/Articles/890096/ > [5] https://lore.kernel.org/lkml/20220805222126.142525-1-jeffxu@google.com/ > [6] https://lore.kernel.org/lkml/20221202013404.163143-1-jeffxu@google.com/ > [7] https://lore.kernel.org/lkml/20221206152358.1966099-1-jeffxu@google.com/ e.g.: v6: - moved foo to bar - improve comments for baz v5: https://lore.kernel.org/lkml/20221206152358.1966099-1-jeffxu@google.com/ v3: https://lore.kernel.org/lkml/20221202013404.163143-1-jeffxu@google.com/ v2: ...etc -Kees -- Kees Cook