From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, songmuchun@bytedance.com,
mike.kravetz@oracle.com, willy@infradead.org,
tsahu@linux.ibm.com, jhubbard@nvidia.com, david@redhat.com,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH mm-unstable] mm: clarify folio_set_compound_order() zero support
Date: Wed, 7 Dec 2022 14:37:31 -0800 [thread overview]
Message-ID: <20221207223731.32784-1-sidhartha.kumar@oracle.com> (raw)
Document hugetlb's use of a zero compound order so support for zero
orders is not removed from folio_set_compound_order().
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
Suggested-by: Muchun Song <songmuchun@bytedance.com>
---
This can be folded into f2b67a51d0ef6871d4fb0c3e8199f278112bd108
mm: add folio dtor and order setter functions
include/linux/mm.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 443d496949a8..cd8508d728f1 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -999,9 +999,16 @@ static inline void set_compound_order(struct page *page, unsigned int order)
#endif
}
+/*
+ * folio_set_compound_order is generally passed a non-zero order to
+ * initialize a large folio. However, hugetlb code abuses this by
+ * passing in zero when 'dissolving' a large folio.
+ */
static inline void folio_set_compound_order(struct folio *folio,
unsigned int order)
{
+ VM_BUG_ON_FOLIO(!folio_test_large(folio), folio);
+
folio->_folio_order = order;
#ifdef CONFIG_64BIT
folio->_folio_nr_pages = order ? 1U << order : 0;
--
2.38.1
next reply other threads:[~2022-12-07 22:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 22:37 Sidhartha Kumar [this message]
2022-12-08 0:38 ` John Hubbard
2022-12-08 1:42 ` Sidhartha Kumar
2022-12-08 2:27 ` John Hubbard
2022-12-08 4:41 ` Muchun Song
2022-12-08 18:06 ` Sidhartha Kumar
2022-12-08 19:32 ` Mike Kravetz
2022-12-08 19:33 ` Matthew Wilcox
2022-12-08 19:56 ` John Hubbard
2022-12-08 20:01 ` Mike Kravetz
2022-12-08 21:58 ` Sidhartha Kumar
2022-12-08 22:01 ` John Hubbard
2022-12-08 22:12 ` Sidhartha Kumar
2022-12-08 22:14 ` John Hubbard
2022-12-08 22:33 ` Sidhartha Kumar
2022-12-08 22:39 ` John Hubbard
2022-12-09 14:27 ` Muchun Song
2022-12-09 21:10 ` John Hubbard
2022-12-09 21:20 ` John Hubbard
2022-12-14 3:00 ` Muchun Song
2022-12-08 22:04 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207223731.32784-1-sidhartha.kumar@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=tsahu@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox