From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7349C4708D for ; Wed, 7 Dec 2022 11:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73B908E0003; Wed, 7 Dec 2022 06:17:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EB488E0001; Wed, 7 Dec 2022 06:17:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B2F38E0003; Wed, 7 Dec 2022 06:17:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4C84F8E0001 for ; Wed, 7 Dec 2022 06:17:30 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1C1DD160A04 for ; Wed, 7 Dec 2022 11:17:30 +0000 (UTC) X-FDA: 80215259460.28.2E17097 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf06.hostedemail.com (Postfix) with ESMTP id 8E2C218000F for ; Wed, 7 Dec 2022 11:17:29 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AVDPXKGl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DjJzkIYa; dmarc=none; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670411849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nl3cYnoVvIf50ZKL46F6ecGRdU1pjqEdzszMDzYGKFU=; b=eeqNh+GOTX/uFL4wX4WxcMTAL1dtigTb1jRbML6pFcqKID5KDoynerg3WpK7DbzTcW53Zq 5+HS8fMBvqiwbgVOUacetjpr4jZALvMpWh9aA3qo/QhlKUUIoqHhSBvf/e2f9cQeWUgsgh EXeTrYnD0Jrzn8Sq9RQEKSwQ2nwNQ8E= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AVDPXKGl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DjJzkIYa; dmarc=none; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670411849; a=rsa-sha256; cv=none; b=4h0M95Klvr2O+BuScRHVQnhX91lSvQ/LuG03mQaOb7o2lHrwpAwbu7AO501a4YRetnjN+o sfYMjk0Vrn5Dqa8NNKinxG5S0hxJ4GOo+XF6SyvF37yeWgx7XDs5K6JfT7OLonqifVBN/c VU9K3/I4iHrxWlIxSc/rcZEpDgd1UvE= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1D0C321C7B; Wed, 7 Dec 2022 11:17:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670411848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nl3cYnoVvIf50ZKL46F6ecGRdU1pjqEdzszMDzYGKFU=; b=AVDPXKGllvjKAC1hczPdpgK/XRWO8ALsxxugPSrmBfCSMPVkfwHMf9Jq5aihOeOFhUbHZy VZngxlI5hgGv8fa1nICQm/0ffdZwdoUZ0fSCj3wZHFzGuAY+Cajn7aEaEtTKNhTtexCoz0 vJo1jR4GmVHkzGzmnxmTTNKVzKhepdY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670411848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nl3cYnoVvIf50ZKL46F6ecGRdU1pjqEdzszMDzYGKFU=; b=DjJzkIYaKfqprPFdDhKAZcdQqebXQMbn+7XbSY2ly00k5SZJLJk/BeAbAV5slJX2iP8ElD sqdCOwrRPL10hNAA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 0D2C8134CD; Wed, 7 Dec 2022 11:17:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id WXopA0h2kGPnJgAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 11:17:28 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 85784A0725; Wed, 7 Dec 2022 12:17:27 +0100 (CET) Date: Wed, 7 Dec 2022 12:17:27 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , Theodore Ts'o , linux-ext4@vger.kernel.org, "Ritesh Harjani (IBM)" , Christoph Hellwig , Matthew Wilcox , linux-mm@kvack.org Subject: Re: [PATCH v3 11/12] ext4: Stop providing .writepage hook Message-ID: <20221207111727.d5dbfq4mewm4njth@quack3> References: <20221205122604.25994-1-jack@suse.cz> <20221205122928.21959-11-jack@suse.cz> <20221206105225.nr734teqlkueqdph@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-2.58 / 9.00]; BAYES_HAM(-4.18)[95.57%]; SUSPICIOUS_RECIPS(1.50)[]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; R_SPF_ALLOW(-0.20)[+ip4:195.135.220.0/24]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCPT_COUNT_SEVEN(0.00)[8]; DKIM_TRACE(0.00)[suse.cz:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_NA(0.00)[suse.cz]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; RCVD_COUNT_FIVE(0.00)[5]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 8E2C218000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 5onzs6f9xsco6nuuirr8kj4ky1y6rdiz X-HE-Tag: 1670411849-305018 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 06-12-22 23:38:50, Christoph Hellwig wrote: > On Tue, Dec 06, 2022 at 11:52:25AM +0100, Jan Kara wrote: > > I don't expect any objection. The only reason we didn't export that > > function when I've added it was that only blkdev code was using it and that > > cannot be compiled as a module. Should I send a patch to > > > > I've added a patch to the series to export this function. It is attached. > > > > I can also repost the whole series if these are the only changes that block > > the inclusion. > > I'd do an EXPORT_SYMBOL_GPL, but otherwise the export looks fine, and it > would be good to get this conversion going! OK, I've just copied how buffer_migrate_folio() is exported but I don't mind a GPL export. I'll change it and push out new version of the series. Honza -- Jan Kara SUSE Labs, CR