From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C09C4321E for ; Mon, 5 Dec 2022 15:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95A308E0003; Mon, 5 Dec 2022 10:13:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90AF48E0001; Mon, 5 Dec 2022 10:13:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D2E18E0003; Mon, 5 Dec 2022 10:13:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F3238E0001 for ; Mon, 5 Dec 2022 10:13:29 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5D44C0434 for ; Mon, 5 Dec 2022 15:13:28 +0000 (UTC) X-FDA: 80208596496.03.9ED03F5 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 33385A001F for ; Mon, 5 Dec 2022 15:13:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=ejYF75fU; dmarc=pass (policy=reject) header.from=meta.com; spf=pass (imf25.hostedemail.com: domain of "prvs=3338591533=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=3338591533=kbusch@meta.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670253208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MLWHDUS20C0jmHJ39hBO1H02jIUsWm5bZEXT2SOrcPk=; b=lNCosSPrYfg06SDxU6tvkbRHYcy5EHoNKB15fY8fRmvSej9m0eph7Fv3qlfIp9X/4uZu0P d4hVuMH0fYJFcGW814xwSoFJlVIYv/zONgKTbDs2KDpS2Shjfeh33eaaMCdVGJCLiWrucY 3c4f8zHjah8O4rejngtDdhrl0+8nNzo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=ejYF75fU; dmarc=pass (policy=reject) header.from=meta.com; spf=pass (imf25.hostedemail.com: domain of "prvs=3338591533=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=3338591533=kbusch@meta.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670253208; a=rsa-sha256; cv=none; b=UDN1X9WfKNYA4aFURekcNDKCKO8jrWZ/85e05BrjtOsX+qybe1vAoGXFMl7T78iQVjVbGI Lpm4PWjW1zrR3N/3YKZTDu5LnDLZ2JNw7VtgxSKdQwbrRuNZ0CKtEtjUd9YIo4mzq1bdbe W06hhUVL3tRBC06PNIzG7tM5NGdoY34= Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B50pTrw032021 for ; Mon, 5 Dec 2022 07:13:27 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=MLWHDUS20C0jmHJ39hBO1H02jIUsWm5bZEXT2SOrcPk=; b=ejYF75fU7LKM8wl5jpImHC6ob7OmFqntqgSVGc7q7fBRtNTo2YbmogV9/hYldchrM5wM G0+tjYboDIyd5JbXawla0H4uvIOtKIYTIurU5zdZBP0kxApMAZGRIOvXKAig2QNU3KMf eIiafVB8VOpgv6FqOoo28oMSYTlMz1YLZA6rOqxa7tMTjf+eHGdJuwl4dbcwngVrLne1 l16/SnAwj5orN2eNpyh6zDEi0moXxB76qmVzGa0EU66PzkXkQAohAew/QcGDljqEA6kz WusGmDZ0R0+69WEmS1e817ytYI09qRBuM4V9W9N5PPvhKdasT7p0qd7KndjZCpcdkU7Z yw== Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3m82ntv1ey-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 05 Dec 2022 07:13:27 -0800 Received: from twshared0551.06.ash8.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::c) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Dec 2022 07:13:24 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 6027CC6156E3; Mon, 5 Dec 2022 07:00:09 -0800 (PST) From: Keith Busch To: , , Matthew Wilcox CC: Tony Battersby , Keith Busch Subject: [PATCH 03/11] dmapool: use sysfs_emit() instead of scnprintf() Date: Mon, 5 Dec 2022 06:59:29 -0800 Message-ID: <20221205145937.54367-4-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221205145937.54367-1-kbusch@meta.com> References: <20221205145937.54367-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: xwZODHkA2lD62u-MEWwPq37bSw9qYVFM X-Proofpoint-GUID: xwZODHkA2lD62u-MEWwPq37bSw9qYVFM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-05_01,2022-12-05_01,2022-06-22_01 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 33385A001F X-Stat-Signature: i4fyincw9pm5fd3s7poo9dj95eadz7m6 X-Spamd-Result: default: False [3.34 / 9.00]; R_MISSING_CHARSET(2.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[meta.com,reject]; BAYES_HAM(-0.26)[67.38%]; R_SPF_ALLOW(-0.20)[+ip4:67.231.145.42]; R_DKIM_ALLOW(-0.20)[meta.com:s=s2048-2021-q4]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_TRACE(0.00)[meta.com:+]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FORGED_SENDER_VERP_SRS(0.00)[]; FROM_NEQ_ENVFROM(0.00)[kbusch@meta.com,prvs=3338591533=kbusch@meta.com]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; ARC_NA(0.00)[] X-HE-Tag: 1670253207-778921 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tony Battersby Use sysfs_emit instead of scnprintf, snprintf or sprintf. Signed-off-by: Tony Battersby Signed-off-by: Keith Busch --- mm/dmapool.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index 559207e1c3339..20616b760bb9c 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -64,18 +64,11 @@ static DEFINE_MUTEX(pools_reg_lock); =20 static ssize_t pools_show(struct device *dev, struct device_attribute *a= ttr, char *buf) { - unsigned temp; - unsigned size; - char *next; + int size; struct dma_page *page; struct dma_pool *pool; =20 - next =3D buf; - size =3D PAGE_SIZE; - - temp =3D scnprintf(next, size, "poolinfo - 0.1\n"); - size -=3D temp; - next +=3D temp; + size =3D sysfs_emit(buf, "poolinfo - 0.1\n"); =20 mutex_lock(&pools_lock); list_for_each_entry(pool, &dev->dma_pools, pools) { @@ -90,16 +83,14 @@ static ssize_t pools_show(struct device *dev, struct = device_attribute *attr, cha spin_unlock_irq(&pool->lock); =20 /* per-pool info, no real statistics yet */ - temp =3D scnprintf(next, size, "%-16s %4u %4zu %4zu %2u\n", - pool->name, blocks, - pages * (pool->allocation / pool->size), - pool->size, pages); - size -=3D temp; - next +=3D temp; + size +=3D sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n", + pool->name, blocks, + pages * (pool->allocation / pool->size), + pool->size, pages); } mutex_unlock(&pools_lock); =20 - return PAGE_SIZE - size; + return size; } =20 static DEVICE_ATTR_RO(pools); --=20 2.30.2