From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FDAC4332F for ; Mon, 5 Dec 2022 20:32:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46FDC8E0002; Mon, 5 Dec 2022 15:32:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4206B8E0001; Mon, 5 Dec 2022 15:32:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E8318E0002; Mon, 5 Dec 2022 15:32:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 20E218E0001 for ; Mon, 5 Dec 2022 15:32:59 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E43E5160A6B for ; Mon, 5 Dec 2022 20:32:58 +0000 (UTC) X-FDA: 80209401636.06.8EEA0E9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id D788A180016 for ; Mon, 5 Dec 2022 20:32:56 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="O/hMUbqT"; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670272377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lbXXokK3tmwql/z0cJl15lHdxkbhCEj/Cchuvb8Z1LQ=; b=W9jszALPZZ5Fjli5rBjHuVc/MI1xgZE66mUpBPtVBnqye52EEoGCKG0g9T+o5pegaiF2pr arjqODpdiOLhB6dIgAITWUCAI6//gnlnjXDUpxZWImZuQRDCUQ8ZP0pDoMx3zaOLZLpYVb GK9Xd4p/Yuzz7VVDg8MOoLSwYqiXgeE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="O/hMUbqT"; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670272377; a=rsa-sha256; cv=none; b=m4R4JW/oLBNM77qnOsz0c7a3IzYkuRiqm0BjKVxrgnS76u+r4Jsle3AMBHCfsm+hX3HwXD tVr3IllXeZv9VwkWYGfvy0WZLSkeH50mYBdhbU5Wx15xMZssIDpldTSy2scI/KgeHZSvTS vG0EBNLPO7lzIJ6sGi9rbfKRRm2Oqvs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A28E8CE13AF; Mon, 5 Dec 2022 20:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 749EDC433C1; Mon, 5 Dec 2022 20:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1670272371; bh=515qPF4ILAV8vNYwyWFbsUeaPOTzvoOjmq/jBopabaQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O/hMUbqTKq2RpqhtLTtSqvnB3UePKDLYa4bTgvhyBCituIaZq4/FEhJugYyOdqR+Q SuS9dEKxP42yQfYIkuFhoSHa3VK3fy5468En0AEt0mvdRoQZtTA0zye3V7+Ahal8wx vff0ASaVF0gOM0MBWn4BS70YfOOOmS0OdBNzNlMc= Date: Mon, 5 Dec 2022 12:32:50 -0800 From: Andrew Morton To: Liam Howlett Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Yu Zhao , Jason Donenfeld , Matthew Wilcox , SeongJae Park , Vlastimil Babka , Jann Horn Subject: Re: [PATCH v2] mmap: Fix do_brk_flags() modifying obviously incorrect VMAs Message-Id: <20221205123250.3fc552d96fcca5dc58be8443@linux-foundation.org> In-Reply-To: <20221205192304.1957418-1-Liam.Howlett@oracle.com> References: <20221205192304.1957418-1-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D788A180016 X-Stat-Signature: 6bao1pbs6gi14fauggson7r51zdtn7ou X-Spamd-Result: default: False [-1.81 / 9.00]; BAYES_HAM(-5.41)[98.72%]; IRL_BL_25(2.00)[52.25.139.140:received]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MV_CASE(0.50)[]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[9]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[linux-foundation.org:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[linux-foundation.org:s=korg]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+a:sin.source.kernel.org]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[linux-foundation.org]; TO_DN_EQ_ADDR_SOME(0.00)[] X-HE-Tag: 1670272376-405310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 5 Dec 2022 19:23:17 +0000 Liam Howlett wrote: > Add more sanity checks to the VMA that do_brk_flags() will expand. > Ensure the VMA matches basic merge requirements within the function > before calling can_vma_merge_after(). I't unclear what's actually being fixed here. Why do you feel we need the above changes? > Drop the duplicate checks from vm_brk_flags() since they will be > enforced later. > > Fixes: 2e7ce7d354f2 ("mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap()") Fixes in what way? Removing the duplicate checks?