From: Andrew Morton <akpm@linux-foundation.org>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yu Zhao <yuzhao@google.com>, Jason Donenfeld <Jason@zx2c4.com>,
Matthew Wilcox <willy@infradead.org>,
SeongJae Park <sj@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
Jann Horn <jannh@google.com>
Subject: Re: [PATCH v2] mmap: Fix do_brk_flags() modifying obviously incorrect VMAs
Date: Mon, 5 Dec 2022 12:32:50 -0800 [thread overview]
Message-ID: <20221205123250.3fc552d96fcca5dc58be8443@linux-foundation.org> (raw)
In-Reply-To: <20221205192304.1957418-1-Liam.Howlett@oracle.com>
On Mon, 5 Dec 2022 19:23:17 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:
> Add more sanity checks to the VMA that do_brk_flags() will expand.
> Ensure the VMA matches basic merge requirements within the function
> before calling can_vma_merge_after().
I't unclear what's actually being fixed here.
Why do you feel we need the above changes?
> Drop the duplicate checks from vm_brk_flags() since they will be
> enforced later.
>
> Fixes: 2e7ce7d354f2 ("mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap()")
Fixes in what way? Removing the duplicate checks?
next prev parent reply other threads:[~2022-12-05 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 19:23 Liam Howlett
2022-12-05 20:32 ` Andrew Morton [this message]
2022-12-05 21:55 ` Jann Horn
2022-12-05 22:13 ` Vlastimil Babka
2022-12-05 22:22 ` Jann Horn
2022-12-05 22:26 ` Vlastimil Babka
2022-12-06 17:12 ` Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205123250.3fc552d96fcca5dc58be8443@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Jason@zx2c4.com \
--cc=jannh@google.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox