From: Wupeng Ma <mawupeng1@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<mawupeng1@huawei.com>, <kuleshovmail@gmail.com>,
<aneesh.kumar@linux.ibm.com>, <clameter@sgi.com>
Subject: [PATCH 0/4] return EINVAL for illegal user memory range
Date: Mon, 5 Dec 2022 11:41:04 +0800 [thread overview]
Message-ID: <20221205034108.3365182-1-mawupeng1@huawei.com> (raw)
From: Ma Wupeng <mawupeng1@huawei.com>
While testing mlock, we have a problem if the len of mlock is ULONG_MAX.
The return value of mlock is zero. But nothing will be locked since the
len in do_mlock overflows to zero due to the following code in mlock:
len = PAGE_ALIGN(len + (offset_in_page(start)));
However this problem appear in multiple syscalls.
Since TASK_SIZE is the maximum user space address. The start or len of
mlock shouldn't be bigger than this. Function access_ok can be used to
check this issue, so return -EINVAL if bigger.
Ma Wupeng (4):
mm/mlock: return EINVAL for illegal user memory range in mlock
mm/mempolicy: return EINVAL for illegal user memory range for
set_mempolicy_home_node
mm/mempolicy: return EINVAL for illegal user memory range for mbind
mm/msync: return EINVAL for illegal user memory range for msync
mm/mempolicy.c | 7 +++++++
mm/mlock.c | 6 ++++++
mm/msync.c | 2 ++
3 files changed, 15 insertions(+)
--
2.25.1
next reply other threads:[~2022-12-05 3:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 3:41 Wupeng Ma [this message]
2022-12-05 3:41 ` [PATCH 1/4] mm/mlock: return EINVAL for illegal user memory range in mlock Wupeng Ma
2022-12-10 3:09 ` mawupeng
2022-12-28 22:17 ` Andrew Morton
2022-12-29 7:48 ` mawupeng
2022-12-05 3:41 ` [PATCH 2/4] mm/mempolicy: return EINVAL for illegal user memory range for set_mempolicy_home_node Wupeng Ma
2022-12-05 3:41 ` [PATCH 3/4] mm/mempolicy: return EINVAL for illegal user memory range for mbind Wupeng Ma
2022-12-05 3:41 ` [PATCH 4/4] mm/msync: return EINVAL for illegal user memory range for msync Wupeng Ma
2022-12-27 7:18 ` [PATCH 0/4] return EINVAL for illegal user memory range mawupeng
2023-01-02 13:22 ` David Hildenbrand
2023-01-04 9:32 ` mawupeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205034108.3365182-1-mawupeng1@huawei.com \
--to=mawupeng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=clameter@sgi.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox