From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E1CC4332F for ; Sun, 4 Dec 2022 01:05:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92B5B8E0002; Sat, 3 Dec 2022 20:05:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DB538E0001; Sat, 3 Dec 2022 20:05:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A3928E0002; Sat, 3 Dec 2022 20:05:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6BD778E0001 for ; Sat, 3 Dec 2022 20:05:05 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4B66C8093D for ; Sun, 4 Dec 2022 01:05:05 +0000 (UTC) X-FDA: 80202829770.23.39B8FDD Received: from r3-23.sinamail.sina.com.cn (r3-23.sinamail.sina.com.cn [202.108.3.23]) by imf16.hostedemail.com (Postfix) with ESMTP id 2183918000E for ; Sun, 4 Dec 2022 01:05:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.23 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670115905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tn/t3d/yaeaqFViHowV9jfKNX8XkPZymmGikaPfJmm0=; b=188gK2af1JEesUBI3Fe7BvONOzBBNp9xTJ6n77C2by2Um4rt06pb7a16DKRx0B43ctjWNM hPhWDcf7rCLR3nNlTd+eY84DMgEywZcEy8nbsYc6R5nh/Iks0cRo5Xl0ngBiwZ8eS3l0oo MrE5xWpr9nevtjuljErq3+maKQkUxa4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.23 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670115905; a=rsa-sha256; cv=none; b=jOoOo7LwIPnfJ4wIpjY48pDFTsU8sdt5g9DKtYMb6XIsVABXF3Yvzni6yPQHWNBVInt8FS fJLEFuPli5iyDQwF9gH2UONNlIfhoROo0QzrPtpa4tZafX/wcf8Ny+dOiVvrmzfXjh8+zf MFAafIxO1fZxwsjR5aImTFT1pVSGXbs= Received: from unknown (HELO localhost.localdomain)([114.249.57.238]) by sina.com (172.16.97.23) with ESMTP id 638BF1A800003EE7; Sun, 4 Dec 2022 09:02:34 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 31420454923723 From: Hillf Danton To: syzbot Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Elver , Dmitry Vyukov , linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk Subject: Re: [syzbot] WARNING in do_mkdirat Date: Sun, 4 Dec 2022 09:04:50 +0800 Message-Id: <20221204010450.7190-1-hdanton@sina.com> In-Reply-To: <00000000000064d06705eeed9b4e@google.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2183918000E X-Stat-Signature: c1cj4mhoo1a9jcgoicoqhtc6jf8py4xi X-Spamd-Result: default: False [0.80 / 9.00]; BAYES_HAM(-6.00)[99.99%]; R_MISSING_CHARSET(2.50)[]; SUSPICIOUS_RECIPS(1.50)[]; URI_HIDDEN_PATH(1.00)[https://syzkaller.appspot.com/x/.config?x=2325e409a9a893e1]; MID_CONTAINS_FROM(1.00)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; R_SPF_ALLOW(-0.20)[+ip4:202.108.3.0/24]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[sina.com]; TAGGED_RCPT(0.00)[919c5a9be8433b8bf201]; ARC_NA(0.00)[] X-Rspam-User: X-HE-Tag: 1670115902-891275 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 03 Dec 2022 06:52:45 -0800 > syzbot found the following issue on: > > HEAD commit: ca57f02295f1 afs: Fix fileserver probe RTT handling > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=171b06a1880000 > kernel config: https://syzkaller.appspot.com/x/.config?x=2325e409a9a893e1 > dashboard link: https://syzkaller.appspot.com/bug?extid=919c5a9be8433b8bf201 > compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/af66f1d3a389/disk-ca57f022.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/c0c7ec393108/vmlinux-ca57f022.xz > kernel image: https://storage.googleapis.com/syzbot-assets/ea8871940eaa/bzImage-ca57f022.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+919c5a9be8433b8bf201@syzkaller.appspotmail.com > > WARNING: CPU: 0 PID: 12206 at kernel/locking/rwsem.c:1361 __up_write kernel/locking/rwsem.c:1360 [inline] > WARNING: CPU: 0 PID: 12206 at kernel/locking/rwsem.c:1361 up_write+0x4f9/0x580 kernel/locking/rwsem.c:1615 > Modules linked in: > CPU: 0 PID: 12206 Comm: syz-executor.0 Not tainted 6.1.0-rc7-syzkaller-00012-gca57f02295f1 #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 > RIP: 0010:__up_write kernel/locking/rwsem.c:1360 [inline] > RIP: 0010:up_write+0x4f9/0x580 kernel/locking/rwsem.c:1615 > Code: c7 40 a3 ed 8a 48 c7 c6 e0 a5 ed 8a 48 8b 54 24 28 48 8b 4c 24 18 4d 89 e0 4c 8b 4c 24 30 31 c0 53 e8 1b 83 e8 ff 48 83 c4 08 <0f> 0b e9 6b fd ff ff 48 c7 c1 18 25 76 8e 80 e1 07 80 c1 03 38 c1 > RSP: 0018:ffffc9000338fd40 EFLAGS: 00010292 > RAX: 69eb1955c47aff00 RBX: ffffffff8aeda420 RCX: 0000000000040000 > RDX: ffffc900046f6000 RSI: 0000000000023311 RDI: 0000000000023312 > RBP: ffffc9000338fe10 R08: ffffffff816e560d R09: fffff52000671f61 > R10: fffff52000671f61 R11: 1ffff92000671f60 R12: 0000000000000000 > R13: ffff888027d20a90 R14: 1ffff92000671fb0 R15: dffffc0000000000 > FS: 00007f928b35b700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f268cbad988 CR3: 000000001e90f000 CR4: 00000000003506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > inode_unlock include/linux/fs.h:761 [inline] > done_path_create fs/namei.c:3857 [inline] > do_mkdirat+0x2de/0x550 fs/namei.c:4064 > __do_sys_mkdir fs/namei.c:4081 [inline] > __se_sys_mkdir fs/namei.c:4079 [inline] > __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4079 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > RIP: 0033:0x7f928a68c0d9 > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007f928b35b168 EFLAGS: 00000246 ORIG_RAX: 0000000000000053 > RAX: ffffffffffffffda RBX: 00007f928a7ac050 RCX: 00007f928a68c0d9 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000400 > RBP: 00007f928a6e7ae9 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > R13: 00007fffeaab152f R14: 00007f928b35b300 R15: 0000000000022000 > Add debug info to inode_unlock() to see if this is not a bogus report. Hillf --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -758,6 +758,7 @@ static inline void inode_lock(struct ino static inline void inode_unlock(struct inode *inode) { + lockdep_assert_held_write(&inode->i_rwsem); up_write(&inode->i_rwsem); } --