From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304E0C352A1 for ; Sat, 3 Dec 2022 04:20:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EFBF6B0072; Fri, 2 Dec 2022 23:20:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79F026B0073; Fri, 2 Dec 2022 23:20:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5326B0074; Fri, 2 Dec 2022 23:20:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5BC796B0072 for ; Fri, 2 Dec 2022 23:20:49 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 36F451C6084 for ; Sat, 3 Dec 2022 04:20:49 +0000 (UTC) X-FDA: 80199694218.13.B45A266 Received: from r3-20.sinamail.sina.com.cn (r3-20.sinamail.sina.com.cn [202.108.3.20]) by imf15.hostedemail.com (Postfix) with ESMTP id 34EF2A0002 for ; Sat, 3 Dec 2022 04:20:46 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.20 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670041248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t0IpCykA60u7lzWeOCCc9Tafdkks5OlAKf9D2P5Nayo=; b=ATaT1ixCJCNNAK6+HaSuxc3THn1eMDk6DE7o4HQPtJlOltJhP+UuGk6zJk1fFs5RvjB722 +84kd8FWtPsGS9xiGQwH0ROg3EoheGjOWQ4iYrIBKd/L6HWlD+jbNHsfLp1q/huy7xFrEU /Xnuxwo0iNfcKDRg7huG0tnd12zFfys= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.20 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670041248; a=rsa-sha256; cv=none; b=HFbh97gxs7c21K0oCU/EUjvwJLxU6SrDq/n/VaqWvfFDLhAH3cKg2cLyrmH2cgN/bkc+Xp aGuQKpP9XNP2dNaTlTZ6/uiu8isEDENJgkL+jhVzVyolGeKQ5l1hFjSRgIgWxYyvNmHVoH YzP7JRTnKLh/wwgBTYKGfMfNnDAlBmM= Received: from unknown (HELO localhost.localdomain)([114.249.57.238]) by sina.com (172.16.97.35) with ESMTP id 638ACDF9000066C0; Sat, 3 Dec 2022 12:18:03 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 19534215076430 From: Hillf Danton To: Yu Zhao Cc: Andrew Morton , Johannes Weiner , Jonathan Corbet , Michael Larabel , Michal Hocko , Mike Rapoport , Roman Gushchin , Suren Baghdasaryan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mm@google.com Subject: Re: [PATCH mm-unstable v1 6/8] mm: multi-gen LRU: per-node lru_gen_folio lists Date: Sat, 3 Dec 2022 12:20:31 +0800 Message-Id: <20221203042031.6978-1-hdanton@sina.com> In-Reply-To: <20221201223923.873696-7-yuzhao@google.com> References: <20221201223923.873696-1-yuzhao@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 34EF2A0002 X-Stat-Signature: uxr1jc4pkkcozdz66rp4us8s8gfppedk X-Rspam-User: X-Spamd-Result: default: False [0.73 / 9.00]; BAYES_HAM(-3.57)[93.71%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; R_SPF_ALLOW(-0.20)[+ip4:202.108.3.0/24]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[sina.com]; ARC_NA(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670041246-111944 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1 Dec 2022 15:39:22 -0700 Yu Zhao > @@ -477,6 +477,16 @@ static void mem_cgroup_update_tree(struct mem_cgroup *memcg, int nid) > struct mem_cgroup_per_node *mz; > struct mem_cgroup_tree_per_node *mctz; > > + if (lru_gen_enabled()) { > + struct lruvec *lruvec = &memcg->nodeinfo[nid]->lruvec; > + > + /* see the comment on MEMCG_NR_GENS */ > + if (soft_limit_excess(memcg) && lru_gen_memcg_seg(lruvec) != MEMCG_LRU_HEAD) > + lru_gen_rotate_memcg(lruvec, MEMCG_LRU_HEAD); > + > + return; The heuristic of rotation is so weak a signal in the background noise produced by prandom_u32_max(MEMCG_NR_BINS), wonder if mcgroup lru works no fine without it. > + } > + > mctz = soft_limit_tree.rb_tree_per_node[nid]; > if (!mctz) > return; > @@ -3526,6 +3536,9 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, > struct mem_cgroup_tree_per_node *mctz; > unsigned long excess; > > + if (lru_gen_enabled()) > + return 0; > + > if (order > 0) > return 0; >