From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D34C4321E for ; Sat, 3 Dec 2022 02:56:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D85BD6B0071; Fri, 2 Dec 2022 21:56:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D35F16B0072; Fri, 2 Dec 2022 21:56:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB0306B0073; Fri, 2 Dec 2022 21:56:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AC92E6B0071 for ; Fri, 2 Dec 2022 21:56:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 780ED140C2E for ; Sat, 3 Dec 2022 02:56:29 +0000 (UTC) X-FDA: 80199481698.23.84736D4 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 0E26FA0012 for ; Sat, 3 Dec 2022 02:56:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="dVzAW/5P"; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670036189; a=rsa-sha256; cv=none; b=cLMv04X4VXS8Zsui+BnJNCcgp4fVgFohbDKrcSO1BKWGyNwRP+uUrSy+hzrS8EwFUStxu/ +aoHBo/JyprH5UDoHHe8Xde6LdNwqMAsNIfumljbwT7z7m+g9vh+N3scoMNDJIaPbLVQFX 2TT9JKcCTBs874fGj6wI28MF8Tl3v/U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="dVzAW/5P"; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670036189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tg9EUUtodmg3gzO5fuJCgAWvD6/vLGnjIJiAun4Wv1k=; b=AkKWHprMNwNI0DP0/dNFvQbFMch7Wxbr6a6MnTIJsezwRgWfdVkOxmzSPErdHsMmEy0Apd 0pdMRdoeOF5uUv4mWDonJucVGVe6gKEeVj7r/IdyuzmLMrzOMYHpxXl9UazP/NMfSdWDQ6 4Gu8YlxhsP0T3u5WLTdjHmgmC39NaV8= Received: by mail-pj1-f42.google.com with SMTP id cm20so6574712pjb.1 for ; Fri, 02 Dec 2022 18:56:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tg9EUUtodmg3gzO5fuJCgAWvD6/vLGnjIJiAun4Wv1k=; b=dVzAW/5PnjoZ12qC31fP/OIaS00ZFKjjcdlIUmoFH4nqs2oQXU84uYYZcR2U26j75i lnWRKv4wFwfIfD1FKValEnoCUusu4OBsS1JkUWnNuD6ZjqEx7CnkNQVfq+pJTytFAtTd dgTWMEIqYR5j5j25ehzviauGOZFFMVPS2Dhh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tg9EUUtodmg3gzO5fuJCgAWvD6/vLGnjIJiAun4Wv1k=; b=FCxaLhfM/2PoY8HUn66znLi7h64iv6ruMku/nu5pZKJX/U50pEPD7FEFMMPPtsFoD0 dRL2tM9FL5PR/0PDxPljS4Ujl/bIPVsi6lrmQBulfQVtMAEo3RRLZq2ME1j904ziQepS kwdbYZKGDz36KHOyPRFXonPlKCg4kCWbf/ec7nhT2fUxbpaHT/xys+qFUP6NX0QVXZhY pPLe6KJNyQS5yuD9qTU49+wI2LdaSA07SlNWcnM9x+9dIBNlB9jU8YjRrA1hgwO9rHa8 WZznLLe451Xzr32JESMAFKhL7MlzGdcQH+iel0kRjeRNSAHgK4ZxPnlcBfNWLrjhJoas F8cw== X-Gm-Message-State: ANoB5pntBErOalzuvJfeE+swj0vbh0HX5E8ER+BGXf9C0LtBb/bLU+lC 1WB2kIq846e6mptVChTzCC5TVQ== X-Google-Smtp-Source: AA0mqf4wVFTnC0RifpAPxFPsQcjIHmX2vnF/zqOn8r7PZSoadjwf+cAK/tzZY5B/v6Z6SG7U6oDVQQ== X-Received: by 2002:a17:902:ce90:b0:186:b46d:da5e with SMTP id f16-20020a170902ce9000b00186b46dda5emr56175295plg.92.1670036188007; Fri, 02 Dec 2022 18:56:28 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k1-20020a170902c40100b0017e64da44c5sm6263310plk.203.2022.12.02.18.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 18:56:27 -0800 (PST) Date: Fri, 2 Dec 2022 18:56:26 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Mike Rapoport Subject: Re: [PATCH v4 38/39] x86/shstk: Add ARCH_SHSTK_UNLOCK Message-ID: <202212021856.603F800BC@keescook> References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-39-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203003606.6838-39-rick.p.edgecombe@intel.com> X-Rspam-User: X-Spamd-Result: default: False [5.47 / 9.00]; SORBS_IRL_BL(3.00)[209.85.216.42:from]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; BAYES_HAM(-0.63)[75.46%]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[39]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DKIM_TRACE(0.00)[chromium.org:+]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 0E26FA0012 X-Rspamd-Server: rspam01 X-Stat-Signature: sppnyxcub4ort9x1r1dpqfatsn8t83xm X-HE-Tag: 1670036188-944056 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 04:36:05PM -0800, Rick Edgecombe wrote: > From: Mike Rapoport > > Userspace loaders may lock features before a CRIU restore operation has > the chance to set them to whatever state is required by the process > being restored. Allow a way for CRIU to unlock features. Add it as an > arch_prctl() like the other shadow stack operations, but restrict it being > called by the ptrace arch_pctl() interface. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Signed-off-by: Mike Rapoport Reviewed-by: Kees Cook -- Kees Cook