From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435B5C47088 for ; Sat, 3 Dec 2022 02:43:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6CCC6B0074; Fri, 2 Dec 2022 21:43:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1CC36B0081; Fri, 2 Dec 2022 21:43:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BDED6B0082; Fri, 2 Dec 2022 21:43:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E46B6B0074 for ; Fri, 2 Dec 2022 21:43:26 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6312A1611BD for ; Sat, 3 Dec 2022 02:43:26 +0000 (UTC) X-FDA: 80199448812.06.EE4A7B3 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf20.hostedemail.com (Postfix) with ESMTP id 0DE2C1C000F for ; Sat, 3 Dec 2022 02:43:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BHC6VeRw; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.181 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670035406; a=rsa-sha256; cv=none; b=hLC1F2sZfg/zdsi8bgS3rDhPExLKixYT7vTMhXqVYqUhK16y+ZCEFxm4Nzvm7/2SoJ5Bgq GH2GSR27fYBYiec6q5PaRjBIH0M2KOb4Fsrhn0Mi8oEC2etieaRJTpkchbhUmAaf/jwj84 g8ZXAqBM2H8fzRTAZPuh+8NdrxPBVao= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BHC6VeRw; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.181 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670035406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X/PM/ivVkW0jUG/czVpW7oWD1ho2PznSORqfUymBhy0=; b=iQZKe2wzXTGAjShuSEZg5mYTsn8OpJNCdcTWB3THGGZK8jncVTEsOoP7iN3M5XvMNW8Zvt H9FmUCq//1Wu3bvtR7fCSnF5j16/+eX5rQeQiIvBGnYqQSkjQIqjwwBIz61GXu1Na+muO+ X8mUqStUcfYEW4xu7YWs2sEQPSdoOF8= Received: by mail-pg1-f181.google.com with SMTP id 62so5828477pgb.13 for ; Fri, 02 Dec 2022 18:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X/PM/ivVkW0jUG/czVpW7oWD1ho2PznSORqfUymBhy0=; b=BHC6VeRwJG5T8EtepfIwQCAz4f9/KMXxVhufdafNbwx34sQ2cfpog8dPrmfZytxgHw NwiHwbtRX1tNbYxQIDHSiKl/7Lb7dxQ25uXaOLiSD58djV8k9k9R7+J6HxJOnapfIbj+ ZhXmuaM7yhrvC8Agryx8O++LaWvytYXU7+iAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X/PM/ivVkW0jUG/czVpW7oWD1ho2PznSORqfUymBhy0=; b=JuWaMr/e1GaGCKLbwH6yTeDDKVDmxm9BkYvz+oAxjIHmHGT83+40HcaKz1SFKSUh5T fMYeIWk4Z866jY/+7DXHtjGYHaXl4v3KbqLkR3bCH00XH/j9TNYokSPT0VGU93vDENoc iqCPKtR4hrePaHeMzgKfZb5cG83Nfhbsyb3MXi0mthRcY0Swt1cSCnq4pJdblqGlMuzG nl+CO0thfFNfBtlYXezzDf8zjv+YmZieZnrAlEscJGg7IEGubHJyS+AcHTl34Wv45Zxc onF77hMgyNXKrsger6/6MSGk3mCxqoPNIq9FxmDSQNr3DIwv3XFmSoshjrlAZJhtP/1Q T9LQ== X-Gm-Message-State: ANoB5plEVxOQJCWnDLY+/4y0xZbIM3ufPI1mNbwRagmZOZw4NzzW3lz1 lLXBL8zJcnHsgIRrGG40ZNPcng== X-Google-Smtp-Source: AA0mqf67lnVWRQXMh/AnnxK9m37yXIew2nPrJP0zGiZF9Jg3GWVCVk2zapCjUdbyQSdpkIJPLM0Djg== X-Received: by 2002:a65:560a:0:b0:477:382d:dd38 with SMTP id l10-20020a65560a000000b00477382ddd38mr47494099pgs.264.1670035405043; Fri, 02 Dec 2022 18:43:25 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q24-20020aa78438000000b00576984617b1sm269014pfn.60.2022.12.02.18.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 18:43:24 -0800 (PST) Date: Fri, 2 Dec 2022 18:43:23 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Yu-cheng Yu Subject: Re: [PATCH v4 26/39] x86/shstk: Add user-mode shadow stack support Message-ID: <202212021843.89B0A2DBE1@keescook> References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-27-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203003606.6838-27-rick.p.edgecombe@intel.com> X-Spamd-Result: default: False [3.61 / 9.00]; SORBS_IRL_BL(3.00)[209.85.215.181:from]; SUSPICIOUS_RECIPS(1.50)[]; BAYES_HAM(-1.49)[84.02%]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; DKIM_TRACE(0.00)[chromium.org:+]; RCPT_COUNT_TWELVE(0.00)[39]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; ARC_NA(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0DE2C1C000F X-Stat-Signature: hsz9rn475151h18giod35w5p6na56rfs X-HE-Tag: 1670035405-337672 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 04:35:53PM -0800, Rick Edgecombe wrote: > From: Yu-cheng Yu > > Introduce basic shadow stack enabling/disabling/allocation routines. > A task's shadow stack is allocated from memory with VM_SHADOW_STACK flag > and has a fixed size of min(RLIMIT_STACK, 4GB). > > Keep the task's shadow stack address and size in thread_struct. This will > be copied when cloning new threads, but needs to be cleared during exec, > so add a function to do this. > > Do not support IA32 emulation or x32. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -- Kees Cook