From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC03C4321E for ; Sat, 3 Dec 2022 02:34:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 029DE6B0073; Fri, 2 Dec 2022 21:34:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F422F6B0074; Fri, 2 Dec 2022 21:34:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE3DB6B0080; Fri, 2 Dec 2022 21:34:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CC1A36B0073 for ; Fri, 2 Dec 2022 21:34:23 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9FEE91401EA for ; Sat, 3 Dec 2022 02:34:23 +0000 (UTC) X-FDA: 80199426006.08.C04DB4E Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf26.hostedemail.com (Postfix) with ESMTP id 53FF2140007 for ; Sat, 3 Dec 2022 02:34:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bZhPZLza; spf=pass (imf26.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670034863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ZO9EQfENAwfe5IE7Ju6A4A1JevIMxb0gNE4/cvCkwk=; b=D46zGRmMNtIWsHwdE/3WKiDm3OG91W4jsCNq1fzzZaTC66eZbmr3OldjqSEGKLO5V+l6IV 5gVhKvVaSMJeVJeEXfV1rYwKuIBW+q5zlUYGePvEYqDn7MaBircmF4mzDggLqaR99+G4sh 6qB8nSmgDHFYsHlLX23+/jezyO0MxDM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bZhPZLza; spf=pass (imf26.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670034863; a=rsa-sha256; cv=none; b=E9X1AVcJ81dvDbPHxSbJ31ltvVL47okNJ8loLAm46p1vZ3I75MB9wH/A3FrlfRSHIEdgFk KPoFku925OqCluplFTd7UBBuhdjUYi/NWsV9acrxjE1oVjiogmU63A7jpCW8SSDkL8mgmI N/LbrAWQ+BXIH0JSB4eN5ocA9Usul9c= Received: by mail-pg1-f169.google.com with SMTP id q71so5828784pgq.8 for ; Fri, 02 Dec 2022 18:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0ZO9EQfENAwfe5IE7Ju6A4A1JevIMxb0gNE4/cvCkwk=; b=bZhPZLzaUJWjoiiQ0jtjANhKr0iyX1e0uNG49etJ1ffWLpKLJWwcXc84+guaypsl2A PjNDYu6sq7/NhXTAN1lBIp+zdvO9hB7UzRhMwC5VpDg0Hre5BtWmGUPdPFbZzI3sRhRf q4LqAwlrDWT2cQe+jeZ47UPoQQQDyEaLB+62w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0ZO9EQfENAwfe5IE7Ju6A4A1JevIMxb0gNE4/cvCkwk=; b=BDEMX6bXS+St6mXIYiLUDcKkuheJ6t7DPI64bSsbE8CLgDcMmp7eqi9T23NN5Jb4c/ LHp9bpjzCCA0+/lmS6WPIW7xWyWK7jknjQzox826Uj7k79u1NzFMeT7OcIQvU77AItXF EjrYQGS6R4tFjTaW6I7+N8DdV5eevm3BmqTrvalIDtZUPIf7MppZow05QvS2ZpQ0B6NO boqI9q7IppdITuDN0rLx/gTXvOYOskcMWUZE17TyvVowZtnEb1PtNBjmrr3z9QwjpBFr lcWBq4oIzpO9dqUcBcmWztyiJcwaJaC+aQroxsBiFefK1YdLKCUauSLA2XdL/GvNV6eo iQyw== X-Gm-Message-State: ANoB5pnIQjaafe9D3+dubQJXdsC/gQ/dGq/wzk6L+cZqiSe+o8yyHnDP gNmwG1NGyhEsDsfW9u8FmNmKpw== X-Google-Smtp-Source: AA0mqf4mKN6Zf9amKvtLE7G+OstIEuXv9ZvjBZH+Lsz+I5pkp/mARSH/gPpqWxQoI1ofPNBJm2wDiQ== X-Received: by 2002:aa7:9245:0:b0:571:3fb3:9b5f with SMTP id 5-20020aa79245000000b005713fb39b5fmr75199209pfp.86.1670034862394; Fri, 02 Dec 2022 18:34:22 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ij19-20020a170902ab5300b0018685257c0dsm6213889plb.58.2022.12.02.18.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 18:34:22 -0800 (PST) Date: Fri, 2 Dec 2022 18:34:21 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Yu-cheng Yu Subject: Re: [PATCH v4 15/39] mm: Introduce VM_SHADOW_STACK for shadow stack memory Message-ID: <202212021834.DC29FAC1@keescook> References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-16-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203003606.6838-16-rick.p.edgecombe@intel.com> X-Stat-Signature: 6ytujq7ic6fwcdt1hwjpayfkpjrpkis5 X-Rspam-User: X-Spamd-Result: default: False [3.71 / 9.00]; SORBS_IRL_BL(3.00)[209.85.215.169:from]; BAYES_HAM(-2.39)[89.14%]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[39]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DKIM_TRACE(0.00)[chromium.org:+]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 53FF2140007 X-Rspamd-Server: rspam06 X-HE-Tag: 1670034863-181360 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 04:35:42PM -0800, Rick Edgecombe wrote: > From: Yu-cheng Yu > > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > A shadow stack PTE must be read-only and have _PAGE_DIRTY set. However, > read-only and Dirty PTEs also exist for copy-on-write (COW) pages. These > two cases are handled differently for page faults. Introduce > VM_SHADOW_STACK to track shadow stack VMAs. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -- Kees Cook