From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B552C4321E for ; Sat, 3 Dec 2022 02:33:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A89FC6B007D; Fri, 2 Dec 2022 21:33:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3A026B007E; Fri, 2 Dec 2022 21:33:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DB706B0080; Fri, 2 Dec 2022 21:33:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7FC5E6B007D for ; Fri, 2 Dec 2022 21:33:30 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 55B55A12E0 for ; Sat, 3 Dec 2022 02:33:30 +0000 (UTC) X-FDA: 80199423780.12.9E86967 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf29.hostedemail.com (Postfix) with ESMTP id EBA64120017 for ; Sat, 3 Dec 2022 02:33:29 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=E3bdGTvQ; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670034810; a=rsa-sha256; cv=none; b=vgwfEvOXjkPnuSKS4/YljsxvUOPQBER3DWzKlXzWmGyqqJcVypS/9j0l0IoQqfpmlNAGbc BJY+DoSpYrmNIkjsshKNzvAYHgNnKhQaUkMkgt7ZXaPZj7BE4PUbzodXNBHWzmt6yLQ1/U JeDUiqNT8xf+/m32HaSTyc2M4xH/7lw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=E3bdGTvQ; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670034810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UQHpdcG0W3UOHn08MSLP1Hn9wMHJIZSaG2NLULB4U7o=; b=O7D7gN0ueErSSICDiPSlNnJ38AFNl/H4nguslmdPmzXRdGqaMniEirDn/1GSVEnwNV8jjb MjzURACNrrLm9licHJFcrPJqdmtrwsetUjIIoTHQnQai6sDX/lrncfHoLyVNv97a5AS0SK D3tnE6iWH7eciQ0Spf5VmkbriLElkyI= Received: by mail-pj1-f46.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so9938344pjc.3 for ; Fri, 02 Dec 2022 18:33:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UQHpdcG0W3UOHn08MSLP1Hn9wMHJIZSaG2NLULB4U7o=; b=E3bdGTvQFJOu55KJyamBSJ4T9NSqfMM5Csnbxgq36xtAGpgkHrj/bujWh1mOR7TYN8 w9hvOgwZSBtg9CIC6o64G1mfBhzL8E6UCAO5O3zJFxZgKtNAMkoa0XsW6kX7wn5wqlWs OaqF8Uxv3zj9vtEdDaJG6lGtv3V4g96YLmq84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UQHpdcG0W3UOHn08MSLP1Hn9wMHJIZSaG2NLULB4U7o=; b=m99VP61+5pKgjlhbR7zTpTouS+J/zQHp93VrGGb8cZ1/FKQhuJdE96FV7wiL0Z7WnX 0yTvjWK8x+P+i04xmu3RoAh0rHihINqv5qQoNd3QcQUuxs9dmKJcBkmQkyJm0VoA06dh YA4ix+gofV9z1PhdAjy9sd07lEYH1TrKIP3yGZpdnoerF/cXtCfJJq/KGZLQ5Fnei5rd wQ6IyP3WmH56nPWim4k/gQDyrXbAZcrCaCGm8d46W1zReVD8tDN5khr+Oi/UJJ5GWQ/M rXYMaQUEY4Bkj/aQdy9acIPrCeREjl/NfCkPAKKDkge6l4M+dRFxs9Fci/s4W++W+UwC Aq3Q== X-Gm-Message-State: ANoB5pmcnO5V+vWCDeclmujperDFjxfGJyDq/T5A7/AVRDfKqUGiFgF4 P+v1lP85rhc4x/d6kYA/JX/Sgg== X-Google-Smtp-Source: AA0mqf4geVaa0a643GENg2McukE2oodkrSBYzsuzasDBLw/p2NXrif8eGSQbP+ryc5PiIYw/fBbkSQ== X-Received: by 2002:a17:90a:8b18:b0:219:1897:f72b with SMTP id y24-20020a17090a8b1800b002191897f72bmr36568022pjn.141.1670034808999; Fri, 02 Dec 2022 18:33:28 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e68-20020a621e47000000b00574db8ca00fsm5706861pfe.185.2022.12.02.18.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 18:33:28 -0800 (PST) Date: Fri, 2 Dec 2022 18:33:27 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Yu-cheng Yu Subject: Re: [PATCH v4 13/39] x86/mm: Start actually marking _PAGE_COW Message-ID: <202212021833.58C233E5@keescook> References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-14-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203003606.6838-14-rick.p.edgecombe@intel.com> X-Spamd-Result: default: False [1.13 / 9.00]; BAYES_HAM(-4.97)[97.67%]; SORBS_IRL_BL(3.00)[209.85.216.46:from]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[39]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DKIM_TRACE(0.00)[chromium.org:+]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EBA64120017 X-Stat-Signature: t19haywicdw573js9hq391ek97bbjaoe X-HE-Tag: 1670034809-712286 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 04:35:40PM -0800, Rick Edgecombe wrote: > The recently introduced _PAGE_COW should be used instead of the HW Dirty > bit whenever a PTE is Write=0, in order to not inadvertently create > shadow stack PTEs. Update pte_mk*() helpers to do this, and apply the same > changes to pmd and pud. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Co-developed-by: Yu-cheng Yu > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -- Kees Cook