From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 407B4C4321E for ; Sat, 3 Dec 2022 02:29:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BECA76B0074; Fri, 2 Dec 2022 21:29:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9C536B0078; Fri, 2 Dec 2022 21:29:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A654D6B007B; Fri, 2 Dec 2022 21:29:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A99F6B0074 for ; Fri, 2 Dec 2022 21:29:08 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6C587AAD9A for ; Sat, 3 Dec 2022 02:29:08 +0000 (UTC) X-FDA: 80199412776.08.3E235E6 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf29.hostedemail.com (Postfix) with ESMTP id 11E26120016 for ; Sat, 3 Dec 2022 02:29:07 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Cw0UHv0K; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670034548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7cAXYlQ5VaMQ5BLk1aXMB0oGCT+qSAsSmGT0reRflQc=; b=qhy51AbuMa/QRbnmmrCFluCfT2a84sUiCBBQKK5qy5lQ+ubeZ5pEX9BB2zG6Uq0dxKCDVx YMR2hAnmvMDepJHAuEz0Bu+9NPFrjNaUM+xqXycoD5vj3Ts9aj0XJfN6bvRz0wvqxUFut7 Kg0YU3Dh8pzjXIYw9BZzoXyFTZ91gJc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Cw0UHv0K; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670034548; a=rsa-sha256; cv=none; b=ZmiqruZstO4y/ESE8bEJJ8jFvYOSCu8ZISYhvECnlD9tPldHGH1mp8KSOq5ztLq3OIELAn IjOueyH6PpgkPxhgug4+a845/5ZIJQOEDuHVIiqafH6A4PjYLAGxibhVJ4d12h1o17QNba /xqybXXphh7uZlD9aQ4dp88MdhDjcp4= Received: by mail-pg1-f180.google.com with SMTP id s196so5842665pgs.3 for ; Fri, 02 Dec 2022 18:29:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7cAXYlQ5VaMQ5BLk1aXMB0oGCT+qSAsSmGT0reRflQc=; b=Cw0UHv0K60H2AUe/OHjHGbe1/PIv2QHijwO47pCLQnR0Nr3P2+bbC8LJsVDbY+XouK NFoPxlyc2jdU2VQ+juROPfFypj8Jq05Y+bxXUKPbXsSeUNyBt5F1Bsw9gKeXm4yh9imA AV8acjj2rcjHaPGj3e4k1akRPlxsWHNY2D/M4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7cAXYlQ5VaMQ5BLk1aXMB0oGCT+qSAsSmGT0reRflQc=; b=Rxhtwkfy4sUYDOFVIol1pzwLCTDlfeJFFXgFFLBBddtwvLVTP3bKnKmkSV6NR1lEUJ wM+eM3XKsXZIiTMjmpoQf0fFgVfRHMTkfaGt37IspyOMrJJ8/M6+FCoQNxobejOo1zo9 8g568qS2jCyc0ipTxnMw4N+axeIPC9tkfGIodkb7Bby9Gx1xC63LiFfkn7gLBL5Aqeig krennAWzc0O03oHQXO386+P7J1zlzRhNLbK8VSeHpZFBaogUs6h9g05WHtjValzj7aIv PMcXikLT6HMs5gVLB5Fh34fbcpDXhIRimF0+1gc8lPKEXN6+SFK3/Yd3XPOtAEh71o+e s7IA== X-Gm-Message-State: ANoB5pnFlmUl8pzNEEIt4ZKXlsYmARpRUhpxLYQzmBX45cIh/9MAmnAh r9EJ1/MQbaX5CzAPachMYGUHLw== X-Google-Smtp-Source: AA0mqf6/9F9eQhV2SemHnuT8JgDUMtDX9L2AtZ2rN4g6mPGyaYzfNzuVgwLmybGIQ8bH/RdTIzEP8g== X-Received: by 2002:a63:4908:0:b0:477:e0b4:3f5 with SMTP id w8-20020a634908000000b00477e0b403f5mr34621298pga.265.1670034547107; Fri, 02 Dec 2022 18:29:07 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x27-20020aa7957b000000b0057534fcd895sm5716573pfq.108.2022.12.02.18.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 18:29:06 -0800 (PST) Date: Fri, 2 Dec 2022 18:29:05 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Yu-cheng Yu , Christoph Hellwig Subject: Re: [PATCH v4 08/39] x86/mm: Remove _PAGE_DIRTY from kernel RO pages Message-ID: <202212021829.6BC87357@keescook> References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-9-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203003606.6838-9-rick.p.edgecombe@intel.com> X-Rspamd-Queue-Id: 11E26120016 X-Stat-Signature: 8yo5grnteqdd41r5xi6bjpt49u9writs X-Rspam-User: X-Spamd-Result: default: False [4.98 / 9.00]; SORBS_IRL_BL(3.00)[209.85.215.180:from]; SUSPICIOUS_RECIPS(1.50)[]; BAYES_HAM(-1.12)[81.09%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[40]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DKIM_TRACE(0.00)[chromium.org:+]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670034547-289627 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 04:35:35PM -0800, Rick Edgecombe wrote: > From: Yu-cheng Yu > > New processors that support Shadow Stack regard Write=0,Dirty=1 PTEs as > shadow stack pages. > > In normal cases, it can be helpful to create Write=1 PTEs as also Dirty=1 > if HW dirty tracking is not needed, because if the Dirty bit is not already > set the CPU has to set Dirty=1 when it the memory gets written to. This > creates addiontal work for the CPU. So tradional wisdom was to simply set > the Dirty bit whenever you didn't care about it. However, it was never > really very helpful for read only kernel memory. > > When CR4.CET=1 and IA32_S_CET.SH_STK_EN=1, some instructions can write to > such supervisor memory. The kernel does not set IA32_S_CET.SH_STK_EN, so > avoiding kernel Write=0,Dirty=1 memory is not strictly needed for any > functional reason. But having Write=0,Dirty=1 kernel memory doesn't have > any functional benefit either, so to reduce ambiguity between shadow stack > and regular Write=0 pages, removed Dirty=1 from any kernel Write=0 PTEs. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -- Kees Cook