From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA1AC4321E for ; Sat, 3 Dec 2022 02:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 870066B0072; Fri, 2 Dec 2022 21:20:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F9C16B0073; Fri, 2 Dec 2022 21:20:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 673766B0074; Fri, 2 Dec 2022 21:20:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4F5506B0072 for ; Fri, 2 Dec 2022 21:20:51 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1A94F140C41 for ; Sat, 3 Dec 2022 02:20:51 +0000 (UTC) X-FDA: 80199391902.03.8B566AA Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf07.hostedemail.com (Postfix) with ESMTP id BE3C04000D for ; Sat, 3 Dec 2022 02:20:50 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gsBDlFYI; spf=pass (imf07.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670034050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pdj4rQnZt3ghY0JYsDbW8G29zmubdAJq8qnfUhP1bDw=; b=nkV46E7IuZUrbmseahzwWvZCdjOugI53iH14ug4g46Y+dGH2wbQwuEXlkE7GcD7FsTs0tz GkKg6rugj5wPgqBlCwts/HFKb7JWGMaeYQcvBFehovcj5LL1YPY/uI/+t9X5kIxw69/G/7 VP83FFIdjxD64kU3shYMGvYfB+qbCZg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gsBDlFYI; spf=pass (imf07.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670034050; a=rsa-sha256; cv=none; b=hR/iNUEQ+Zir/eGyf22DZ117W1jLc+dph2uB8nBD+dsZnjiN1ElmB9iFJvJu1JSEmzgoxG 7Gi2zZyPF5Gx7GIai54s1yeSP7lwjCTFsQ2zm+k1YERRn+k2NR45nUDm8qtBfQIVv0NbO+ VtP8ktBWS96qHUeXM5hWHNc2Sq09+jk= Received: by mail-pg1-f173.google.com with SMTP id f3so5830403pgc.2 for ; Fri, 02 Dec 2022 18:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pdj4rQnZt3ghY0JYsDbW8G29zmubdAJq8qnfUhP1bDw=; b=gsBDlFYIA6+ssXAuRQnSCJpEb8pM4SDnpeDeLeFetrTCxdejKvNiZg4cCs8RzVeSVR aCDxlveDMDqzJ0/uwkJSoqvEnryHxT4HvfWZkKCjiqK9uowsLom9/PdT5VLwDe7XrNm0 QZiu0h6AvVRpdlpM9Nd8QSrYGdi9ypFGXRNzQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pdj4rQnZt3ghY0JYsDbW8G29zmubdAJq8qnfUhP1bDw=; b=49kT7HzLokiBTbM0xDV7/EGxmxhP4tcZ6hJocJ57Tya3YT9pOS/m/MVPnMg09fVsfr mD7gNQZ0P0f4QENpRsMeztHreP45MW+Jfkwe3ognxpasy0iBeKVu59KSSb9X2j9ULHHx fODK91xONgMQA7UkIZ1OdJ69k6ffNGFuCKXhWEuJIOKv+WcOq1zTGQ6Lvd6w4eR5oIQF 1xXdfGQHiUd7LDkt5Qc1ppox7wLku2ZhZ9u2S7sosHaDbC7bco92ERG9ZQ9YPUy9+2mG dy6stM7HSDtPILxOHCWK5k9fB4Tt7pha5qjqfhia5a1kzRK8WYu2F9BAD+QFoBiTBaka EPTw== X-Gm-Message-State: ANoB5plpxJxngc0tG+hExM4tOAPeL2l6gzz1t6g7zfq07FmfiseiQw9G uyB3wdI1Q4PADheJam+pZvfV4A== X-Google-Smtp-Source: AA0mqf4mF13JhpORx1pjJYPRNcogO+X7Oh29vGm+VcX+eNni2cgUCbmjN8FPxQdYEN/m921aEDZQ9A== X-Received: by 2002:a62:5b43:0:b0:573:6cfc:2210 with SMTP id p64-20020a625b43000000b005736cfc2210mr57434898pfb.55.1670034049745; Fri, 02 Dec 2022 18:20:49 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z19-20020aa79493000000b00576670cc170sm1903619pfk.93.2022.12.02.18.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 18:20:49 -0800 (PST) Date: Fri, 2 Dec 2022 18:20:48 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Yu-cheng Yu Subject: Re: [PATCH v4 02/39] x86/shstk: Add Kconfig option for Shadow Stack Message-ID: <202212021820.72F8CAE9E@keescook> References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-3-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203003606.6838-3-rick.p.edgecombe@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BE3C04000D X-Rspam-User: X-Stat-Signature: 5ohrgapto97memc571sd65f7cgngts6r X-Spamd-Result: default: False [2.59 / 9.00]; SORBS_IRL_BL(3.00)[209.85.215.173:from]; BAYES_HAM(-2.51)[89.69%]; SUSPICIOUS_RECIPS(1.50)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; DKIM_TRACE(0.00)[chromium.org:+]; RCPT_COUNT_TWELVE(0.00)[39]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; ARC_NA(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-HE-Tag: 1670034050-126437 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 04:35:29PM -0800, Rick Edgecombe wrote: > From: Yu-cheng Yu > > Shadow Stack provides protection for applications against function return > address corruption. It is active when the processor supports it, the > kernel has CONFIG_X86_SHADOW_STACK enabled, and the application is built > for the feature. This is only implemented for the 64-bit kernel. When it > is enabled, legacy non-Shadow Stack applications continue to work, but > without protection. > > Since there is another feature that utilizes CET (Kernel IBT) that will > share implementation with Shadow Stacks, create CONFIG_CET to signify > that at least one CET feature is configured. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -- Kees Cook