From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA6DC4321E for ; Thu, 1 Dec 2022 21:32:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B44356B0074; Thu, 1 Dec 2022 16:32:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF4456B0075; Thu, 1 Dec 2022 16:32:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BCCF6B0078; Thu, 1 Dec 2022 16:32:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8FE726B0074 for ; Thu, 1 Dec 2022 16:32:07 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 61E14A02D5 for ; Thu, 1 Dec 2022 21:32:07 +0000 (UTC) X-FDA: 80195035494.22.192A8DB Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by imf29.hostedemail.com (Postfix) with ESMTP id E3E7B120016 for ; Thu, 1 Dec 2022 21:32:06 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sbHSU0xy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of 3VR2JYwgKCNYK92C66D38GG8D6.4GEDAFMP-EECN24C.GJ8@flex--shakeelb.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3VR2JYwgKCNYK92C66D38GG8D6.4GEDAFMP-EECN24C.GJ8@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669930327; a=rsa-sha256; cv=none; b=5RDCSBzdVwbWcZu9UZrjotXl/goI2rmgm5D3ENTUhq66/rvL2vneiGOXTCgHz8sSTMWzhX kDQPiDhge+CsikR3Mjjg7Om09f8ZphZKbScqo5VEEIVA0/L6P6khWl+UxQO34NZLkgaCvx j00iILopjHduyhWO85Cyh0G2TAW4LX0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sbHSU0xy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of 3VR2JYwgKCNYK92C66D38GG8D6.4GEDAFMP-EECN24C.GJ8@flex--shakeelb.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3VR2JYwgKCNYK92C66D38GG8D6.4GEDAFMP-EECN24C.GJ8@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669930327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IfDx/vZZhAqgLTBVAtZpOgxT3AMIFtwt/yJ9iwINIG4=; b=HX7Q0c4+Yuh97ZxZbn7lRBQoggdanWvPmG2BJDrSKtgoWx8y4AIXDhHViHLESVkffEoSkq FjgRj3vqexJ2XuS9Wfz/0GmIT3cURbuGA7Z+OYnOkq1odso7ayddVfs7Yn0UoRDRwlYPg0 gpqZV2kdCFMoSUehW1caP9S+WxsfIHU= Received: by mail-pg1-f201.google.com with SMTP id 69-20020a630148000000b00478118684c4so2737862pgb.20 for ; Thu, 01 Dec 2022 13:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=IfDx/vZZhAqgLTBVAtZpOgxT3AMIFtwt/yJ9iwINIG4=; b=sbHSU0xyULWPTLXrm4btl81eBH5mc9EKqlCz8FBmg/OKAGvwye48d3zFEn0riuTVz+ WI135Ntn79yhQRfKeyZF9J31eWKZKbKfBPuZ6/IMFzXeE7bgaaa2yAN6MEz3rn9BS3KN pNq4oLUFZmBCza5DExDhCrhY1gEBUmnnwuPGqI06j6cwAnmA9q0TDNzZ1mv8sSTIT1dN i7JlGJQmI3F0FeNp58IYU82p1+DN2kCgMsZWLPZ80EgvnJx/a3yI/cpU52DcBwD9efhB EZCOpNyNvSM5cmzqGWy8U39bvl1fJXnh98h4aU96DBsH01M0Va7s9KdyfDWD8Tiyn9Ie bEvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IfDx/vZZhAqgLTBVAtZpOgxT3AMIFtwt/yJ9iwINIG4=; b=NEp1bUeZjU4h2ZOWcsJ8MjMa0y20CT1P/A3IZ9UGb3jdlGliPh4rUpk5Q0BVUhRqS0 4hrqvx6DeufbqH9PRYMrmd48ruLYFh2zTBg2RQIdT7nS8FhaiI1bZUMldXcCAmGhrQqV FHTCM3m52bdceXAGkmPIf7KmKmlt5zoc/zklJey9q9PzV102AXiSKRBWFVacxGum6Slp H7+tO2HuQ9gPFVf81i1NTMNJAYpS1SCmJ9+Yb8CLfKoyaB1VWdESazSBuQT8bbaJv9x5 IaKDxQd2SvnJvBqu7KsmDW2c24R9VIkmBbhfgWXm/bljhJu/1YdhN024dE1FE82dG3pc tIQA== X-Gm-Message-State: ANoB5pnUDYzwXbq4aftlwMPcZOSkT8iDiaA8HXudncisNzsr4fdHt5NJ qsNO4y4uqCp6Mvsrqv+4q74eJypsPBq7rQ== X-Google-Smtp-Source: AA0mqf6pgLZ9Fc+K/9bMs2AxM/jvaK3js6zpoUDFS4IqiABOk/6WhwnwrmgPz87CaWY8z9dGCinxzJhJXRwT3w== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a17:902:efd6:b0:189:94e6:6a8e with SMTP id ja22-20020a170902efd600b0018994e66a8emr18501696plb.72.1669930325681; Thu, 01 Dec 2022 13:32:05 -0800 (PST) Date: Thu, 1 Dec 2022 21:32:02 +0000 In-Reply-To: <20221130020328.1009347-1-almasrymina@google.com> Mime-Version: 1.0 References: <20221130020328.1009347-1-almasrymina@google.com> Message-ID: <20221201213202.ycdaymwojd5plyrk@google.com> Subject: Re: [RFC PATCH v2] mm: Add nodes= arg to memory.reclaim From: Shakeel Butt To: Mina Almasry Cc: Huang Ying , Yang Shi , Yosry Ahmed , Tim Chen , weixugc@google.com, gthelen@google.com, fvdl@google.com, Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E3E7B120016 X-Stat-Signature: khn9nptscfbnnb37o3xjq1d8kati59h5 X-Spamd-Result: default: False [3.63 / 9.00]; SORBS_IRL_BL(3.00)[209.85.215.201:from]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[shakeelb@google.com,3VR2JYwgKCNYK92C66D38GG8D6.4GEDAFMP-EECN24C.GJ8@flex--shakeelb.bounces.google.com]; BAYES_HAM(-0.27)[73.96%]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; RCPT_COUNT_TWELVE(0.00)[20]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[google.com:+]; MIME_TRACE(0.00)[0:+]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; FROM_NEQ_ENVFROM(0.00)[shakeelb@google.com,3VR2JYwgKCNYK92C66D38GG8D6.4GEDAFMP-EECN24C.GJ8@flex--shakeelb.bounces.google.com]; TO_DN_SOME(0.00)[] X-Rspam-User: X-HE-Tag: 1669930326-649847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 29, 2022 at 06:03:27PM -0800, Mina Almasry wrote: [...] > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 7b8e8e43806b..23fc5b523764 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -6735,7 +6735,8 @@ unsigned long mem_cgroup_shrink_node(struct mem_cgroup *memcg, > unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *memcg, > unsigned long nr_pages, > gfp_t gfp_mask, > - unsigned int reclaim_options) > + unsigned int reclaim_options, > + nodemask_t nodemask) Can you please make this parameter a nodemask_t* and pass NULL instead of NODE_MASK_ALL?