From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A552C4332F for ; Fri, 2 Dec 2022 03:15:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 546516B0071; Thu, 1 Dec 2022 22:15:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F6686B0073; Thu, 1 Dec 2022 22:15:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3970B6B0074; Thu, 1 Dec 2022 22:15:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 27D9E6B0071 for ; Thu, 1 Dec 2022 22:15:03 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E493D801A5 for ; Fri, 2 Dec 2022 03:15:02 +0000 (UTC) X-FDA: 80195899644.05.89278AA Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 7CE8018000C for ; Fri, 2 Dec 2022 03:15:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Fa9mz0Dc; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669950902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oqF8S2h0QfjDSY5BvnG3c6kD+5Es8xPoCcPiNLRGmBY=; b=ureW/H7H6TzhC1xT/CkDIE7j1IOfgVUpTVWviyCSW0TH1ym+kLqqvEESZRroF92xqY/vAr DlDP/8YPrU0tN3a8yVcJ1r+vb1NIE/JirRchOx89HIfiTQk8aM4KXz0uZSyQAuFNT+6Rh+ pcjjuSTKAQFhzBGwVYuFsUI0JAgUzn8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669950902; a=rsa-sha256; cv=none; b=hJdJTf5DAT4cCaxbdy8L999Jf2ZE1+lM4LMb4lFeZaU40kbbbclpaGMcmtMeBuFJtmOyGo 8f3vpNXRAujFcP+vAayrV2vBSfrAyOZYI+a67apxDAJ2Rnl/qa/hv5I/XniH4sZMAwk6/0 Dvfn/Op/Sg6bSLng5BoYDHbwW3Im8Sw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Fa9mz0Dc; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f172.google.com with SMTP id d3so3478715plr.10 for ; Thu, 01 Dec 2022 19:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oqF8S2h0QfjDSY5BvnG3c6kD+5Es8xPoCcPiNLRGmBY=; b=Fa9mz0Dc6OvnCQeV7mKMdOpv3bANXuvSDuKqWT3mNGilaa1aLiwU9tzK3gTdi8BZky Cf0VI8AV20LH/YIcZ6jLe8d6/czcA1UOmuGjwbdXzUiSo8n7rS5e3Ry32FZz/xTHuLO5 0Ix+RcHs/mJFGnXMcEnClcHbpqtpvcErX7N50= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oqF8S2h0QfjDSY5BvnG3c6kD+5Es8xPoCcPiNLRGmBY=; b=enUiZJgp3Orlk1Cw5lHonFS6lYiuE8G/gnF59s7DwjVxmz4WruEFfuwK51EA1AdIWM DV+L4YVdvhTKLECNItCC99eVxazdWIoySFPGySrJRO2fvZALyXYVjIuiIQ7VuN6FOkmL uQj29wCnxpajBvAezZDeWFJ87kjS4bo6MkgY2nfi2ZrobFf7J7OZp7nf77IMq2RSGDKL N4LznWU4KQxoTRLdKQAKR24qz3wI6xQVnLQwLRmsQ720/RifzFlnlJylHnHy1R6XzZE8 Uz+5/61PaWV0WmlBX+tvfIy+NsoGjZKwKyml6p6mvSctG0o+La8tgZKl7M1WCXKiL+LA Igbg== X-Gm-Message-State: ANoB5pkVe6T0fnID/YCO5PVDT0s8vwPxHl7YGWjn02ALC2J+Sy8fEfLc We16QJN4SezRX2sQaRzWH0qwxw== X-Google-Smtp-Source: AA0mqf7a/WwRWd061ZWQpdBuig0WFuxxmWOGrWFK6efQfuyV8RpxQuBfw6dN3ZvaaAfMbtN90FNMcQ== X-Received: by 2002:a17:902:ef44:b0:189:6793:644f with SMTP id e4-20020a170902ef4400b001896793644fmr34274294plx.38.1669950901280; Thu, 01 Dec 2022 19:15:01 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 65-20020a620544000000b00575448ab0e9sm3924741pff.123.2022.12.01.19.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 19:15:00 -0800 (PST) Date: Thu, 1 Dec 2022 19:14:59 -0800 From: Kees Cook To: Wang Yufen Cc: viro@zeniv.linux.org.uk, ebiederm@xmission.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] binfmt: Fix error return code in load_elf_fdpic_binary() Message-ID: <202212011914.792F2FE@keescook> References: <1669945261-30271-1-git-send-email-wangyufen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1669945261-30271-1-git-send-email-wangyufen@huawei.com> X-Rspam-User: X-Rspamd-Queue-Id: 7CE8018000C X-Stat-Signature: zjs7wfyksxhkbqmdsefgh9mden3qozz3 X-Rspamd-Server: rspam01 X-Spamd-Result: default: False [3.67 / 9.00]; SORBS_IRL_BL(3.00)[209.85.214.172:from]; SUBJECT_HAS_UNDERSCORES(1.00)[]; BAYES_HAM(-0.93)[86.34%]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[chromium.org:+]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-HE-Tag: 1669950902-374270 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 09:41:01AM +0800, Wang Yufen wrote: > Fix to return a negative error code from create_elf_fdpic_tables() > instead of 0. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Wang Yufen Thanks for the catch! Yeah, it looks like this has been wrong for a long time. :) -Kees > --- > fs/binfmt_elf_fdpic.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index 08d0c87..9ce5e1f 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -434,8 +434,9 @@ static int load_elf_fdpic_binary(struct linux_binprm *bprm) > current->mm->start_stack = current->mm->start_brk + stack_size; > #endif > > - if (create_elf_fdpic_tables(bprm, current->mm, > - &exec_params, &interp_params) < 0) > + retval = create_elf_fdpic_tables(bprm, current->mm, &exec_params, > + &interp_params); > + if (retval < 0) > goto error; > > kdebug("- start_code %lx", current->mm->start_code); > -- > 1.8.3.1 > -- Kees Cook