From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C251C4321E for ; Tue, 29 Nov 2022 21:26:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B0286B0073; Tue, 29 Nov 2022 16:26:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1609F6B0074; Tue, 29 Nov 2022 16:26:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 028196B0075; Tue, 29 Nov 2022 16:26:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E48D36B0073 for ; Tue, 29 Nov 2022 16:26:22 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A79794105A for ; Tue, 29 Nov 2022 21:26:22 +0000 (UTC) X-FDA: 80187763404.12.8B94C61 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 3AC5480015 for ; Tue, 29 Nov 2022 21:26:22 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 590FC6193B; Tue, 29 Nov 2022 21:26:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62F43C433C1; Tue, 29 Nov 2022 21:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1669757180; bh=6ALCXb/pWvuaPqQbiW6kDLBf8N7JSNk2pLYAG27FG00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EAQhfAtlgmpzYOMolrZDszRgzQkfuSrbi4HidyAWyZd8JUBq3EgRk9XzxH8xx6xCY 8NQl2KvQiG39KDECQsim0NJ5h9TQTh+XgCVzxWOJ/kb6Ek9zZ79sAOMzsyfM3c3E3W gX9/OAPT369m8Vpe+d/Kww1WyJaL3l2Wl8oqD/Xo= Date: Tue, 29 Nov 2022 13:26:19 -0800 From: Andrew Morton To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , Jann Horn , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz , David Hildenbrand Subject: Re: [PATCH 00/10] mm/hugetlb: Make huge_pte_offset() thread-safe for pmd unshare Message-Id: <20221129132619.f982806393c607fc20c9cb34@linux-foundation.org> In-Reply-To: References: <20221129193526.3588187-1-peterx@redhat.com> <20221129124944.8eff54cda65d0f5a8a089e22@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EAQhfAtl; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669757182; a=rsa-sha256; cv=none; b=2LlPl/620aNZk2CjKlINBnphmI5ssp3815XVNyofb6F6h3vy4YW3yeC3DxI44On7KLooE2 BqRBQSJXe6Mu+WMt5QUVwg1/130s2W6JhMnVT0BLkEgG5nQ4LvCVchHNjOcCif5x4T7aso fyAs8erKxWi5qPJpl/cktkkhgGvRba8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669757182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pC2eHa0msxd9sy+5bd/7OZtPq8dO13H53fm6+pOfYUs=; b=pspaZIM4sCKj0lIIDbjvERB5GmtRcnSvfkT40Z4R0N7pBijXIk4UqbwrFitOW1pCWuLb2q NQ4zDjhsnpMlJxUIA9BsHbpG6poPtQ6TeseB5Cajv7v/gWIBDN/6racjIly2jNvsRM2pPd H4BxQf44Jym8TnlK/PH825hTeB6IK8Y= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EAQhfAtl; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam01 X-Stat-Signature: cozfuwtyo136xj54po4q7rszamec8rty X-Rspamd-Queue-Id: 3AC5480015 X-Rspam-User: X-HE-Tag: 1669757182-705269 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 29 Nov 2022 16:19:52 -0500 Peter Xu wrote: > On Tue, Nov 29, 2022 at 12:49:44PM -0800, Andrew Morton wrote: > > On Tue, 29 Nov 2022 14:35:16 -0500 Peter Xu wrote: > > > > > Based on latest mm-unstable (9ed079378408). > > > > > > This can be seen as a follow-up series to Mike's recent hugetlb vma lock > > > series for pmd unsharing, but majorly covering safe use of huge_pte_offset. > > > > We're at -rc7 (a -rc8 appears probable this time) and I'm looking to > > settle down and stabilize things... > > I targeted this series for the next release not current, because there's no > known report for it per my knowledge. > > The reproducer needs explicit kernel delays to trigger as mentioned in the > cover letter. So far I didn't try to reproduce with a generic kernel yet > but just to verify the existance of the problem. OK, thanks, I missed that. I'll give the series a run in -next for a couple of days then I'll pull it out until after the next Linus merge window, so it can't invalidate testing heading into that merge window.