From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0495FC46467 for ; Tue, 29 Nov 2022 14:32:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ACD26B0071; Tue, 29 Nov 2022 09:32:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95D516B0072; Tue, 29 Nov 2022 09:32:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84C506B0074; Tue, 29 Nov 2022 09:32:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7545B6B0071 for ; Tue, 29 Nov 2022 09:32:23 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 76D7D140789 for ; Tue, 29 Nov 2022 08:35:24 +0000 (UTC) X-FDA: 80185820568.28.59C55A2 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP id CBA3D10000F for ; Tue, 29 Nov 2022 08:35:23 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 679A068C7B; Tue, 29 Nov 2022 09:35:19 +0100 (CET) Date: Tue, 29 Nov 2022 09:35:18 +0100 From: Christoph Hellwig To: Song Liu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, rppt@kernel.org, mcgrof@kernel.org Subject: Re: [PATCH bpf-next v5 3/6] selftests/vm: extend test_vmalloc to test execmem_* APIs Message-ID: <20221129083518.GA25167@lst.de> References: <20221128190245.2337461-1-song@kernel.org> <20221128190245.2337461-4-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221128190245.2337461-4-song@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669710924; a=rsa-sha256; cv=none; b=77ejywun5sl9/mvbPj2Blle9PuWVYrr5Wu/mDMwM+T3GfG78xrQhTET/jOXF2mgExKjISS U0mBkUTETEljek4zLUqVDJFSzpgsZ0vvqNGWUrIdUK2piIoAOjBf2QJ0j0E7M13AJoohA8 Cjr+4xwl3v9gqYP2kDacK+pdfAwdqmY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669710924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qea+kW8a6EvOXa9T2Fw2+wNNvjliheKs9FGWME4umr4=; b=Dd8l5qcMopO5eiZxkyx/4br5ZaIbtxo/vzLm/I+G8qoUPdEK7FOaEgOdCyMaAWzxYm80kZ aXeV2PhPd4zGVjRX+lZ1tIPyQ3Gi/+7MXR8psX84lk7R69BhXpe+0zLfUd9yjz36sxG9n+ LkNFQ26tinGP4NsID90RTWnsUgGknZg= X-Rspamd-Queue-Id: CBA3D10000F X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam09 X-Stat-Signature: 9b551skrsoe3ns4m9ywr6hoctw5njzss X-HE-Tag: 1669710923-536102 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC > +EXPORT_SYMBOL_GPL(execmem_alloc); > +#endif > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC > +EXPORT_SYMBOL_GPL(execmem_fill); > +#endif > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC > +EXPORT_SYMBOL_GPL(execmem_free); > +#endif Still NAK. These symbols never have any business being exported ever. Just force the test to be built-in if you want to test this functionality.