From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C75C4332F for ; Fri, 25 Nov 2022 07:10:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26D916B0071; Fri, 25 Nov 2022 02:10:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F5356B0072; Fri, 25 Nov 2022 02:10:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 098216B0073; Fri, 25 Nov 2022 02:10:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA9DC6B0071 for ; Fri, 25 Nov 2022 02:10:37 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AC5A1160E99 for ; Fri, 25 Nov 2022 07:10:37 +0000 (UTC) X-FDA: 80171091714.04.2093E41 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf10.hostedemail.com (Postfix) with ESMTP id 5F6D5C0004 for ; Fri, 25 Nov 2022 07:10:36 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id k5so2965449pjo.5 for ; Thu, 24 Nov 2022 23:10:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lpI09D4mWcHJ7/K+doiGSv8YTaJguLCmdZoe5Iuc0aI=; b=Dp9qdYV3Qk2KwfyXvm+XfGzKSUxj0sUur9Ht8R5nXrw3GNf57sNHPQO1lNfJ/yj5ks ixg6x1HISo5F3qibG9UOBzghU/3isXfTPfG4g+x8+xMdBVSY1OHeJ9t7P0Wv9USubbbP UrYZzT5galnrH7u280HXSGOXCA7/cGSIdN+zsa9PPRI1YTjBzgolztLkYZaHENa14AZI dl388W8iHhl+E3sJz1VZq+9TXkYe6QZQKYQlo+rd/gZUP9rbL+X50IlBbFf/3adj1nWA Uan/AzmsYhiABaYo8ywM4yGvKm5k1/C1Br5pVoAxnFPJgKHLqMeUxJU9v0pgG2LvIvW8 cDTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lpI09D4mWcHJ7/K+doiGSv8YTaJguLCmdZoe5Iuc0aI=; b=dXNxslYR9a8/jL31aOdbXUPetT/lhdHxauZll9ptYsaj5ag1iwVxRdI4ss0Wtjh1ZZ xOzixvNsmYJmO0OrqhJYCgGMv7/JhtsYy2LdD9K72RlxBS8qWJzMkjagcojsj9/5phdr ngq7TVeI8l7UYysy1BErp1/vuvaR2+1S6gIGq0M7ymeRTTpGaJvFYkP1v9bAz+aNBigq TjVApXIdiaRa08/hXbYwju7eis+zyXmccVTPUM6SCIr98Dr/5zsXw5FwXCgI2dVd4LoU /N/1KuYSttPbGSkY0Cky5g+kerUoTw1hzV+7zz25Y88t6jd34WmszbgyH/cqbBuqpCoR 2wrg== X-Gm-Message-State: ANoB5pmrvdtZCfuMEQQ5RmzLg66qOzoGPJAI2YbRaQiMO3IxiMOiTIfe eyrsTYkj9lvRSnrJ+b50hJxhnA== X-Google-Smtp-Source: AA0mqf7V43Xz2Moi9FjtIMiTzYXGtNAY8tk5vkxd3bX6vBsI50geRZURKPxgk7qALSZm0Tv+Nb7QXA== X-Received: by 2002:a17:902:c611:b0:189:58a6:851d with SMTP id r17-20020a170902c61100b0018958a6851dmr6900338plr.146.1669360234978; Thu, 24 Nov 2022 23:10:34 -0800 (PST) Received: from localhost.localdomain ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id a5-20020a170902710500b0017d97d13b18sm2555352pll.65.2022.11.24.23.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 23:10:34 -0800 (PST) From: Jiachen Zhang To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xieyongji@bytedance.com, Jiachen Zhang Subject: [PATCH] filemap: Fix some misleading comments Date: Fri, 25 Nov 2022 15:09:59 +0800 Message-Id: <20221125070959.49027-1-zhangjiachen.jaycee@bytedance.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669360237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=lpI09D4mWcHJ7/K+doiGSv8YTaJguLCmdZoe5Iuc0aI=; b=TxFmONmMTXzHkEiUm40LcdS44+sr0EKmrVPFSOVH/ZS3+bfzxt5ZoL3voP3aIfwlBmUYR3 JblQ6q9nfqvbjBMwsW80fvQ/sqSnToViz3WFaiaBGNFUZxh0+JD9IN+zGUGoC421cJWks9 MDiLlx7oxgkdHoooFoar2jcop+6tyZo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Dp9qdYV3; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of zhangjiachen.jaycee@bytedance.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zhangjiachen.jaycee@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669360237; a=rsa-sha256; cv=none; b=L8j5c6wy/6ikFB9pXRmbYfCbBV09hmsLPpsg7/6HP3XedC4lbRx1JIS5Nem6nE2f/U+ARs XhLShY6j+PQtf4Isb6492x/4HmLzEuZljDtShgoUHeUHPQt2IJP92iyri5ZcZNw3yxJNkH DpNCRR3Q7YU81xof6VZ8UA3PoyuVIXk= X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Dp9qdYV3; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of zhangjiachen.jaycee@bytedance.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zhangjiachen.jaycee@bytedance.com X-Stat-Signature: bafrmxfczb677dkmmcnp4x7fwkztikgx X-Rspamd-Queue-Id: 5F6D5C0004 X-Rspamd-Server: rspam08 X-HE-Tag: 1669360236-564570 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The users of filemap_write_and_wait_range() and file_write_and_wait_range() interfaces should set the lend parameter to LLONG_MAX, rather than -1, to indicate they want to writeback to the very end-of-file, as several kernel code paths are checking the 'wbc->range_end == LLONG_MAX' conditions. Signed-off-by: Jiachen Zhang --- mm/filemap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 65eee6ec1066..c6d066a39425 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -661,7 +661,8 @@ EXPORT_SYMBOL_GPL(filemap_range_has_writeback); * Write out and wait upon file offsets lstart->lend, inclusive. * * Note that @lend is inclusive (describes the last byte to be written) so - * that this function can be used to write to the very end-of-file (end = -1). + * that this function can be used to write to the very end-of-file (@lend = + * LLONG_MAX). * * Return: error status of the address space. */ @@ -758,7 +759,8 @@ EXPORT_SYMBOL(file_check_and_advance_wb_err); * Write out and wait upon file offsets lstart->lend, inclusive. * * Note that @lend is inclusive (describes the last byte to be written) so - * that this function can be used to write to the very end-of-file (end = -1). + * that this function can be used to write to the very end-of-file (@lend = + * LLONG_MAX). * * After writing out and waiting on the data, we check and advance the * f_wb_err cursor to the latest value, and return any errors detected there. -- 2.20.1