From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 081DFC43219 for ; Thu, 24 Nov 2022 21:47:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 579C26B0071; Thu, 24 Nov 2022 16:47:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52A106B0072; Thu, 24 Nov 2022 16:47:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 419576B0073; Thu, 24 Nov 2022 16:47:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 319606B0071 for ; Thu, 24 Nov 2022 16:47:00 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0093A804A8 for ; Thu, 24 Nov 2022 21:46:59 +0000 (UTC) X-FDA: 80169671400.17.8BE506D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 9244DA000F for ; Thu, 24 Nov 2022 21:46:59 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3B6D62259; Thu, 24 Nov 2022 21:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D68CC433C1; Thu, 24 Nov 2022 21:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1669326418; bh=VQhrA4QvkvbVxLz5ExJ5z1Rxw/daXHI5RLFJxB9ahKE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1ozBDRZygQ1WMLJFF6VpXPDDavWnzZekkaueVw0i5rerEiN/6tvhCMaYR5lvvOpoP REPiSFZJ/okOmuANXvVzPHOWSbcWSIBxkxXtzBcVwSfvPpOR4POhhZdc5dDATEeGWQ Zgo5gza6kc4z7BiBqputAd2JbQj2AE8RgQmojoqQ= Date: Thu, 24 Nov 2022 13:46:57 -0800 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/thp: Rename pmd_to_page() as pmd_pgtable_page() Message-Id: <20221124134657.0120000e174fa1a9ad292113@linux-foundation.org> In-Reply-To: <20221124131641.1523772-1-anshuman.khandual@arm.com> References: <20221124131641.1523772-1-anshuman.khandual@arm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669326419; a=rsa-sha256; cv=none; b=U9F1Ubh9bM/WcbenwQlKsVHBJqmjgCWOkXoqfzZZr12OVHSdSyKqHDuD5raqTRymt9Aweu +wmlM07HHzRCuqnQ4O7/abwUmutldVgWV7YIWosRh6E929ap5WfGZodFVV+cOsAgILZBLn yd/u4QTXdLp5aBWylUsOmF8Xi3jDgrg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1ozBDRZy; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669326419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RfUHD0crA640SE+K/nUeTpRhYFY0hJROoEC1Ii10XZM=; b=knOK3HAhdTpEbRWkYAD3Do+23Nfk/OJ2B9umesWYWGiZ3mS3iMEhcXbXpGnk1dAxtnmHe1 1FRXduUH50GQ8S89b93DH7jABLa9dwH3jCwHWAT+URg5vojTmGKLQfkieUwHkOHTDOyESR rwnvXHQrWah8LcRhLvtGzaW7Z1aKZ/M= X-Rspamd-Queue-Id: 9244DA000F X-Stat-Signature: sh1357t6kk9hgex19ngcyi6g7bh3xaoj X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1ozBDRZy; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam09 X-HE-Tag: 1669326419-267442 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 24 Nov 2022 18:46:41 +0530 Anshuman Khandual wrote: > Current pmd_to_page(), which derives the page table page containing the pmd > address has a very misleading name. The problem being, it sounds similar to > pmd_page() which derives page embedded in a given pmd entry either for next > level page or a mapped huge page. Rename it as pmd_pgtable_page() instead. > Is the new name much clearer? There are a zillion of these little conversion functions in the pagemap layer, all quite confusing yet we seem to have decided that they are so plainly obvious that no code commenting is needed. Sigh.