From: Andrew Morton <akpm@linux-foundation.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/thp: Rename pmd_to_page() as pmd_pgtable_page()
Date: Thu, 24 Nov 2022 13:46:57 -0800 [thread overview]
Message-ID: <20221124134657.0120000e174fa1a9ad292113@linux-foundation.org> (raw)
In-Reply-To: <20221124131641.1523772-1-anshuman.khandual@arm.com>
On Thu, 24 Nov 2022 18:46:41 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> Current pmd_to_page(), which derives the page table page containing the pmd
> address has a very misleading name. The problem being, it sounds similar to
> pmd_page() which derives page embedded in a given pmd entry either for next
> level page or a mapped huge page. Rename it as pmd_pgtable_page() instead.
>
Is the new name much clearer?
There are a zillion of these little conversion functions in the pagemap
layer, all quite confusing yet we seem to have decided that they are so
plainly obvious that no code commenting is needed. Sigh.
prev parent reply other threads:[~2022-11-24 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 13:16 Anshuman Khandual
2022-11-24 21:46 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124134657.0120000e174fa1a9ad292113@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox