From: Andrew Morton <akpm@linux-foundation.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@linux.com>,
"Pekka Enberg" <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
<linux-mm@kvack.org>, <kasan-dev@googlegroups.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next 1/2] mm/slab: add is_kmalloc_cache() helper macro
Date: Tue, 22 Nov 2022 15:17:18 -0800 [thread overview]
Message-ID: <20221122151718.4f7ffcb656dd7dc0eceb0ad2@linux-foundation.org> (raw)
In-Reply-To: <Y3xeYF5NipSbBFSZ@feng-clx>
On Tue, 22 Nov 2022 13:30:19 +0800 Feng Tang <feng.tang@intel.com> wrote:
> > If so, that's always best. For (silly) example, consider the behaviour
> > of
> >
> > x = is_kmalloc_cache(s++);
> >
> > with and without CONFIG_SLOB.
>
> Another solution I can think of is putting the implementation into
> slab_common.c, like the below?
I'm not sure that's much of an improvement on the macro :(
How about we go with the macro and avoid the
expression-with-side-effects gotcha (and the potential CONFIG_SLOB=n
unused-variable gotcha)? That would involve evaluating the arg within
the CONFIG_SLOB=y version of the macro.
next prev parent reply other threads:[~2022-11-22 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:50 Feng Tang
2022-11-21 13:50 ` [PATCH -next 2/2] mm/kasan: simplify is_kmalloc check Feng Tang
2022-11-21 14:13 ` Feng Tang
2022-11-21 15:15 ` Andrey Konovalov
2022-11-22 6:53 ` Feng Tang
2022-11-22 9:57 ` Andrey Konovalov
2022-11-21 20:19 ` [PATCH -next 1/2] mm/slab: add is_kmalloc_cache() helper macro Andrew Morton
2022-11-22 5:30 ` Feng Tang
2022-11-22 23:17 ` Andrew Morton [this message]
2022-11-23 9:21 ` Vlastimil Babka
2022-11-23 12:17 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122151718.4f7ffcb656dd7dc0eceb0ad2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=42.hyeyoo@gmail.com \
--cc=andreyknvl@gmail.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=feng.tang@intel.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=ryabinin.a.a@gmail.com \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox