From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C175C433FE for ; Tue, 22 Nov 2022 23:04:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 875646B0072; Tue, 22 Nov 2022 18:04:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 826826B0073; Tue, 22 Nov 2022 18:04:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EDB36B0074; Tue, 22 Nov 2022 18:04:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5E6096B0072 for ; Tue, 22 Nov 2022 18:04:01 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2D049161077 for ; Tue, 22 Nov 2022 23:04:01 +0000 (UTC) X-FDA: 80162607882.13.CF27703 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id A2BD540010 for ; Tue, 22 Nov 2022 23:03:59 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94662B81D4B; Tue, 22 Nov 2022 23:03:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A83DC433D6; Tue, 22 Nov 2022 23:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1669158236; bh=Mo+orukc3bevWxHrUrHQcfom3WcnVlNM1E+v3+jDJgQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vEzAYP6FIhN1e2rFg5KylUlwXnqabL/VvLoNfdCYLdlq7jXrNQn/EsIS4gb57DHXn iQKWQ2+ru5Ns2vjEZi1Y1rHDxS/+r7A8C8Ex4HqTB3S/G2nyZSc+/8/iWYe/840Bo0 Wg4RrH6ds3TE269DjBDjaXpV0Qitxik7CBgOC75Q= Date: Tue, 22 Nov 2022 15:03:55 -0800 From: Andrew Morton To: Jason Gunthorpe Cc: Mike Kravetz , David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , John Hubbard , syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com Subject: Re: [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings Message-Id: <20221122150355.41805b9013855cf0433b6612@linux-foundation.org> In-Reply-To: References: <20221031152524.173644-1-david@redhat.com> <20221121133320.a4e1c70af6ca72f29795fd5f@linux-foundation.org> <4b926dc7-b8ec-e363-b9d8-35c0f2c897f6@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vEzAYP6F; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669158239; a=rsa-sha256; cv=none; b=1MijVmEPFvRAgrMheQUgbnxqYTpkRP3RHDVke2K97TLw0VXccGC35rQR1lPv/g6KJrcKsa 3PM8Tsssgz9dHEqXgH5gJUFFEp+NySJ2ef7EtL1qqDwejwVLZB9ea7dQe7Szr3yQSCtIv+ suzOI+I7rJP7o7QfEWPzLi4li8C0TeE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669158239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bhyJqXFV0/1lFr5OYXHz5j7hflCzF2klK9SYprkIvX0=; b=uRDdOCiAzuiq/7Nm/9fDG2KeaTWNX37k8/tcC5LJsHmgzYesraPAakGyDc1RpuJuxqvuFt CTHYKXyp7GZ4JPMz2FwgvQ/q+s/a51v5vN64o0Z3N0/rMFj0eTlVjZoCt9ja7/Axra099O 7RApX3JJhm1gc/MzHtJtoTNha8PogHc= X-Rspamd-Queue-Id: A2BD540010 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vEzAYP6F; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam06 X-Stat-Signature: r4t73q6qtc9ozjwjutio86ehg3pqrj8i X-HE-Tag: 1669158239-91153 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 22 Nov 2022 13:59:25 -0400 Jason Gunthorpe wrote: > > > > > > While that's certainly valid, it's not the common use case with > > > hugetlb pages. > > > > FWIW, I did check with our product teams and they do not knowingly make use > > of private mappings without write. Of course, that is only a small and > > limited sample size. > > Yeah, if it is only this case I'm comfortable as well > So.... I am to slap a cc:stable on this patch and we're all good?