From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F132C433FE for ; Tue, 22 Nov 2022 15:30:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F50C6B0071; Tue, 22 Nov 2022 10:30:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A40A6B0073; Tue, 22 Nov 2022 10:30:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8921D6B0074; Tue, 22 Nov 2022 10:30:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 764986B0071 for ; Tue, 22 Nov 2022 10:30:50 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 47EE8AB85E for ; Tue, 22 Nov 2022 15:30:50 +0000 (UTC) X-FDA: 80161465860.27.7482049 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id BA109C0019 for ; Tue, 22 Nov 2022 15:30:48 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AE215B81BEA; Tue, 22 Nov 2022 15:30:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78D64C433C1; Tue, 22 Nov 2022 15:30:44 +0000 (UTC) Date: Tue, 22 Nov 2022 10:30:42 -0500 From: Steven Rostedt To: Mark Rutland Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Will Deacon , Florent Revest , "Masami Hiramatsu (Google)" Subject: Re: [linux-next:master 8539/9537] include/linux/ftrace.h:126:16: error: implicit declaration of function 'arch_ftrace_get_regs'; did you mean 'ftrace_get_regs'? Message-ID: <20221122103042.07c349ee@gandalf.local.home> In-Reply-To: References: <202211212249.livTPi3Y-lkp@intel.com> <20221121124015.31d34642@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669131048; a=rsa-sha256; cv=none; b=mAoyoAX3MlQv76EKX1NJNNg1LVoU/sbtn60Kw5nyNXpbDUstdP/oy2HMGxOZQNryzbwBjX e1YVjDxxAx7IMe/Eoo8iKvLHz1E5w1HQdZkraptE9basp+h6z2xd6vJofLJ1LFBMOrEEtu Lgh2PPm4p7NaKGPGbb0oX6IwEupyaQE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of "SRS0=q8fe=3W=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=q8fe=3W=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669131048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VpdodQydfJ5cedgfIZhtWOuzqeIyJ+Zgi01RGjxpXHw=; b=n0qktsi5WqevClzPSc3odQim94NyLWdDdVPol8CboE5iJE/xlAtzCZBzAqrhOvrH2R//Gy Z1Yi2YQDQbB79wsCmo1ScoxvlNtp6u7XtC+BH7Xh3eOlFeqp1007udGOtWIU5d9LPo4IQM JR8kxQJS9sOT49qedhJExc/7ZqJ3mOU= Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of "SRS0=q8fe=3W=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=q8fe=3W=goodmis.org=rostedt@kernel.org" X-Stat-Signature: fio49uu1x7kjcm8j36qrnsrp53sha8ro X-Rspamd-Queue-Id: BA109C0019 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1669131048-373107 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 22 Nov 2022 15:13:39 +0000 Mark Rutland wrote: > To be honest, we just didn't think to remove static ftrace; I'm happy to remove > that for arm64. Please do. There's no reason for it. The *only* reason I keep it around on x86 is to make sure it still works (for those other architectures developing ftrace). > > That said, I still think it makes sense to change the code to check > CONFIG_DYNAMIC_FTRACE_WITH_ARGS rather than > CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, as mentioned below, unless you intend for > that to have an effect on static ftrace on x86? > > Everywhere else with DYNAMIC_FTRACE_WITH_ARGS forces DYNAMIC_FTRACE, so it ends > up equivalent; x86 and arm64 are the only exceptions today. Yeah, looking at the code, I think it does make sense to just use DYNAMIC_FTRACE_WITH_ARGS, as that was created to combine the other two configs anyway. -- Steve