From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 574A6C433FE for ; Mon, 21 Nov 2022 15:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEE616B0074; Mon, 21 Nov 2022 10:55:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D79CE6B0075; Mon, 21 Nov 2022 10:55:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C19446B0078; Mon, 21 Nov 2022 10:55:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ADC8A6B0074 for ; Mon, 21 Nov 2022 10:55:47 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 865C01A0CFB for ; Mon, 21 Nov 2022 15:55:47 +0000 (UTC) X-FDA: 80157899934.27.350646A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf16.hostedemail.com (Postfix) with ESMTP id BF98C18000C for ; Mon, 21 Nov 2022 15:55:46 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 45AEA68CFE; Mon, 21 Nov 2022 16:55:42 +0100 (CET) Date: Mon, 21 Nov 2022 16:55:42 +0100 From: Christoph Hellwig To: Daniel Borkmann Cc: Song Liu , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, rppt@kernel.org, mcgrof@kernel.org Subject: Re: [PATCH bpf-next v4 1/6] vmalloc: introduce execmem_alloc, execmem_free, and execmem_fill Message-ID: <20221121155542.GA27879@lst.de> References: <20221117202322.944661-1-song@kernel.org> <20221117202322.944661-2-song@kernel.org> <882e2964-932e-0113-d3cd-344281add3a1@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <882e2964-932e-0113-d3cd-344281add3a1@iogearbox.net> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669046147; a=rsa-sha256; cv=none; b=ESIxaxQMw40NMM0Y/IGjN5eENFSu86J6OkOAA/2dHRMO+fbHxKQ11CXYZqbO8eKE4/cKuQ TOtbjm9oh2hxU/eOpNMaqpx7Xtscffs4D63wMfmmUE+nRfrH8vYBoBedkVCSft96xT/Q95 BJF3AXsAKVaGy50znlzhj9S/Au8XwDM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669046147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tuuTWfGZCeCxehJaDddTxfLhz42CbN+Npl4VidnCGOw=; b=iNva8Fv71nTz0hwf3KT7BSVGJ2FtswCCy3UfuKYmsMSBNXpEqANug5ZcVsQk3fbJg+YMoq WtyMNFh7HaelH00ywlTBMVXDSW2SWWPUM4/PJiKfMEinkftSDWlH1JT+eyCqy++1DweZoI Jq05JaXstc1LHYoFyulYBTcxVPD5QdE= X-Rspam-User: X-Stat-Signature: 15xsienjhqquzhykkzuotw8mhd1rfsby X-Rspamd-Queue-Id: BF98C18000C Authentication-Results: imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam07 X-HE-Tag: 1669046146-148361 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 04:52:24PM +0100, Daniel Borkmann wrote: >> +void *execmem_fill(void *dst, void *src, size_t len) >> +{ >> + return ERR_PTR(-EOPNOTSUPP); >> +} > > Don't they need EXPORT_SYMBOL_GPL, too? None of these should be exported. Modular code has absolutely no business creating executable mappings.