From: Christoph Hellwig <hch@lst.de>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Song Liu <song@kernel.org>,
bpf@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org,
hch@lst.de, rick.p.edgecombe@intel.com, rppt@kernel.org,
mcgrof@kernel.org
Subject: Re: [PATCH bpf-next v4 1/6] vmalloc: introduce execmem_alloc, execmem_free, and execmem_fill
Date: Mon, 21 Nov 2022 16:55:42 +0100 [thread overview]
Message-ID: <20221121155542.GA27879@lst.de> (raw)
In-Reply-To: <882e2964-932e-0113-d3cd-344281add3a1@iogearbox.net>
On Mon, Nov 21, 2022 at 04:52:24PM +0100, Daniel Borkmann wrote:
>> +void *execmem_fill(void *dst, void *src, size_t len)
>> +{
>> + return ERR_PTR(-EOPNOTSUPP);
>> +}
>
> Don't they need EXPORT_SYMBOL_GPL, too?
None of these should be exported. Modular code has absolutely no
business creating executable mappings.
next prev parent reply other threads:[~2022-11-21 15:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 20:23 [PATCH bpf-next v4 0/6] execmem_alloc for BPF programs Song Liu
2022-11-17 20:23 ` [PATCH bpf-next v4 1/6] vmalloc: introduce execmem_alloc, execmem_free, and execmem_fill Song Liu
[not found] ` <882e2964-932e-0113-d3cd-344281add3a1@iogearbox.net>
2022-11-21 15:55 ` Christoph Hellwig [this message]
2022-11-21 16:29 ` Song Liu
2022-11-21 19:55 ` Luis Chamberlain
2022-11-22 2:55 ` Song Liu
2022-11-22 6:13 ` Christoph Hellwig
2022-11-22 17:25 ` Song Liu
2022-11-28 17:53 ` Song Liu
2022-11-17 20:23 ` [PATCH bpf-next v4 2/6] x86/alternative: support execmem_alloc() and execmem_free() Song Liu
2022-11-17 20:23 ` [PATCH bpf-next v4 3/6] selftests/vm: extend test_vmalloc to test execmem_* APIs Song Liu
2022-11-17 20:23 ` [PATCH bpf-next v4 4/6] bpf: use execmem_alloc for bpf program and bpf dispatcher Song Liu
2022-11-17 20:23 ` [PATCH bpf-next v4 5/6] vmalloc: introduce register_text_tail_vm() Song Liu
2022-11-17 20:23 ` [PATCH bpf-next v4 6/6] x86: use register_text_tail_vm Song Liu
2022-11-21 20:12 ` [PATCH bpf-next v4 0/6] execmem_alloc for BPF programs Luis Chamberlain
2022-11-21 20:20 ` Luis Chamberlain
2022-11-22 2:36 ` Song Liu
2022-12-08 2:48 ` Luis Chamberlain
2022-11-22 2:28 ` Song Liu
2022-11-23 0:21 ` Luis Chamberlain
2022-11-23 5:06 ` Song Liu
2022-11-30 9:53 ` Mike Rapoport
2022-11-30 9:41 ` Mike Rapoport
2022-11-22 2:55 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121155542.GA27879@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox