From: Andrew Morton <akpm@linux-foundation.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] tools/vm/slabinfo-gnuplot: Use "grep -E" instead of "egrep"
Date: Mon, 21 Nov 2022 14:07:34 -0800 [thread overview]
Message-ID: <20221121140734.397eacb569252aafee64c498@linux-foundation.org> (raw)
In-Reply-To: <1668825419-30584-1-git-send-email-yangtiezhu@loongson.cn>
On Sat, 19 Nov 2022 10:36:59 +0800 Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
>
> sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/vm`
>
> Here are the steps to install the latest grep:
>
> wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
> tar xf grep-3.8.tar.gz
> cd grep-3.8 && ./configure && make
> sudo make install
> export PATH=/usr/local/bin:$PATH
>
> ...
>
> --- a/tools/vm/slabinfo-gnuplot.sh
> +++ b/tools/vm/slabinfo-gnuplot.sh
> @@ -150,7 +150,7 @@ do_preprocess()
> let lines=3
> out=`basename "$in"`"-slabs-by-loss"
> `cat "$in" | grep -A "$lines" 'Slabs sorted by loss' |\
> - egrep -iv '\-\-|Name|Slabs'\
> + grep -E -iv '\-\-|Name|Slabs'\
> | awk '{print $1" "$4+$2*$3" "$4}' > "$out"`
> if [ $? -eq 0 ]; then
> do_slabs_plotting "$out"
> @@ -159,7 +159,7 @@ do_preprocess()
> let lines=3
> out=`basename "$in"`"-slabs-by-size"
> `cat "$in" | grep -A "$lines" 'Slabs sorted by size' |\
> - egrep -iv '\-\-|Name|Slabs'\
> + grep -E -iv '\-\-|Name|Slabs'\
> | awk '{print $1" "$4" "$4-$2*$3}' > "$out"`
> if [ $? -eq 0 ]; then
> do_slabs_plotting "$out"
Thanks. I'll add a cc:stable to this, in an attempt to make older
kernels work well with newer toolchains.
parent reply other threads:[~2022-11-21 22:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1668825419-30584-1-git-send-email-yangtiezhu@loongson.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121140734.397eacb569252aafee64c498@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox