From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 287EEC433FE for ; Mon, 21 Nov 2022 17:40:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84FF46B0072; Mon, 21 Nov 2022 12:40:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D7B66B0073; Mon, 21 Nov 2022 12:40:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69F586B0074; Mon, 21 Nov 2022 12:40:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 56D866B0072 for ; Mon, 21 Nov 2022 12:40:23 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1288DC03B0 for ; Mon, 21 Nov 2022 17:40:23 +0000 (UTC) X-FDA: 80158163526.25.AA6B0F9 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 01B2940011 for ; Mon, 21 Nov 2022 17:40:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28BD4B8123A; Mon, 21 Nov 2022 17:40:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BFA5C433D6; Mon, 21 Nov 2022 17:40:16 +0000 (UTC) Date: Mon, 21 Nov 2022 12:40:15 -0500 From: Steven Rostedt To: Mark Rutland Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Will Deacon , Florent Revest , "Masami Hiramatsu (Google)" Subject: Re: [linux-next:master 8539/9537] include/linux/ftrace.h:126:16: error: implicit declaration of function 'arch_ftrace_get_regs'; did you mean 'ftrace_get_regs'? Message-ID: <20221121124015.31d34642@gandalf.local.home> In-Reply-To: References: <202211212249.livTPi3Y-lkp@intel.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669052421; a=rsa-sha256; cv=none; b=uGZwKHdzVpjEzhBLO33tzrmTNNbFzE/+mqUZ7zj3d31mHiiqPruvSx1ngtb7Bi9jhmlzFH ECuVnu6osQvStfCtkBgcXt1xvcJLTT6hMLXmDe7yHJASGhUUjsNdl5YBHi88fNltPpgQke SBwxRVlyCMhilLbk0Is04vqzUNRT6hI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=8Rnd=3V=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=8Rnd=3V=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669052421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8egQq7/ZkZnw6e11ofR1koWspH292NTsNuO4aUJE/qU=; b=MElQt9Jwd/7FuQDSrK5ML8XP6IKQ1G0KAt6LeiWBR008yd8Fh23dhxl64I9NkQ0RRsXhoO iyFRtkYSlrL8RIWrmGicoG+jqhXLyNLAWbW+tXADWB53CXdrPCQ7HUtCd8GONbDrnvdJvr ldsmxtQ6EY3cnypgRy2slgIu03GN7io= X-Stat-Signature: qp6mxqjweunrifkoxyonnh71bbsb1kfj X-Rspamd-Queue-Id: 01B2940011 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=8Rnd=3V=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=8Rnd=3V=goodmis.org=rostedt@kernel.org"; dmarc=none X-Rspamd-Server: rspam02 X-HE-Tag: 1669052420-531189 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 21 Nov 2022 17:26:15 +0000 Mark Rutland wrote: > ... and since arm64 can be built with DYNAMIC_FTRACE=n we end up with: > > CONFIG_DYNAMIC_FTRACE=n Is there any reason to have CONFIG_DYNAMIC_FTRACE=n and CONFIG_FUNCTION_TRACE=y? The only reason I keep the option to turn off DYNAMIC_FTRACE is for debugging purposes. That is, if you have HAVE_DYNAMIC_FTRACE, then DYNAMIC_FTRACE should be enabled whenever it is needed by something else. The reason for static ftrace is simply to help new architectures work their way to having DYNAMIC_FTRACE enabled. Perhaps the solution is to get rid of the DYNAMIC_FRACE prompt, and have it set whenever FUNCTION_TRACER is set and HAVE_DYNAMIC_FTRACE is set. For debugging purposes, I may add HAVE_DEBUG_DYNAMIC_FTRACE which brings back the prompt (for x86 only). -- Steve > CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS=y > CONFIG_DYNAMIC_FTRACE_WITH_ARGS=n > > Looking at this some more, ftrace_regs_has_args() should check for > CONFIG_DYNAMIC_FTRACE_WITH_ARGS rather than > CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, or it'll bogusly report we have args when > CONFIG_DYNAMIC_FTRACE=n. > > I'd prefer to change the core ftrace code to check for > CONFIG_DYNAMIC_FTRACE_WITH_ARGS for consistency with that, but I'll need to > check how that affects other architectures.