From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A552DC433FE for ; Mon, 21 Nov 2022 10:07:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C41B8E000B; Mon, 21 Nov 2022 05:07:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 273CD8E0001; Mon, 21 Nov 2022 05:07:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13C3B8E000B; Mon, 21 Nov 2022 05:07:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 01B5E8E0001 for ; Mon, 21 Nov 2022 05:07:17 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C442280EAA for ; Mon, 21 Nov 2022 10:07:17 +0000 (UTC) X-FDA: 80157021714.27.A4A397B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 14097120014 for ; Mon, 21 Nov 2022 10:07:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC83421E2E; Mon, 21 Nov 2022 10:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669025234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q4IViuQpwPEcZzjjxamaWcFWnSXKTM0MbrHGsCmeqkQ=; b=jWO57yYjiG6oJ7os9jTrYvpZwMpk7iFCyXSFiozl+kCieh91bLV3UGjW3Bb55k3q0DM0iT Pye7XzjLd+H0jQuBklHlAxqt1U3WbzDWXLeMIK5xCM8SWsovnxyhrVye84ieWJeWn5QENP cU5eX4gfF1uRGBx6kvzWOREKWBTdjjA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669025234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q4IViuQpwPEcZzjjxamaWcFWnSXKTM0MbrHGsCmeqkQ=; b=C/PSDzkFpjgWFOKTSy3+AJAFIyRJIUsoxq+JCiCyQBTUxM8KgZql1lzPCYbkjZkbOfVj4b L4lcWr/A/flK1BAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A79931377F; Mon, 21 Nov 2022 10:07:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4s7iKNJNe2MjAwAAMHmgww (envelope-from ); Mon, 21 Nov 2022 10:07:14 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 2DEFDA070A; Mon, 21 Nov 2022 11:07:14 +0100 (CET) Date: Mon, 21 Nov 2022 11:07:14 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , Christoph Hellwig , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH 2/9] ext2: remove ->writepageo Message-ID: <20221121100714.73zjzpbgdvt5j7xv@quack3> References: <20221113162902.883850-1-hch@lst.de> <20221113162902.883850-3-hch@lst.de> <20221114104927.k5x4i4uanxskfs6m@quack3> <20221116182040.tecis3dqejsdqnum@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669025236; a=rsa-sha256; cv=none; b=3D1g0r3q22clHBLL2CqfvJAhCRSXeVUjeKq+roNN909m211VZHcHspQMarM706SPYD/Urs WIIsFkrJu2wWkTI2xw2i5bByYGYZQDbxW21iSB1U2cYBeL6f5syFk3C9La1Xq9JUovcNVE qD29LfT5+WTc2jSmeX2DAxX2nRnBEbI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jWO57yYj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="C/PSDzkF"; spf=pass (imf29.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669025236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4IViuQpwPEcZzjjxamaWcFWnSXKTM0MbrHGsCmeqkQ=; b=QTvgJDFCiqt/5owV0ECT/Cn/SUwNwimQ/fJLlOiYeMjRLDEqmDXyjUHJ+R+n5gWAVVu3h3 ZBhqckxphu0bSoaQQGrjtT7yuyRVwcCaTGyQ7McHY2YdQHtjXsLYZgKAfcib3kMXUeP8Y5 Eqj8Fd8PhrMUF7QiLhJ4H7P2iw1uGXA= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jWO57yYj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="C/PSDzkF"; spf=pass (imf29.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 14097120014 X-Rspam-User: X-Stat-Signature: 66h68f6oofhrymp4sa64ggwxsef1rzpa X-HE-Tag: 1669025235-440747 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 16-11-22 22:31:47, Christoph Hellwig wrote: > On Wed, Nov 16, 2022 at 07:20:40PM +0100, Jan Kara wrote: > > Looking at the code, IMO the write_one_page() looks somewhat premature > > anyway in that place. AFAICS we could handle the writeout using > > filemap_write_and_wait() if we moved it to somewhat later moment. So > > something like attached patch (only basic testing only so far)? > > Yes, this looks sensible. Do you want to queue this one and the > ext2 and udf patches from this series if the testing works fine? OK, I'll take udf and ext2 patches through my tree. Honza -- Jan Kara SUSE Labs, CR