From: Stefan Roesch <shr@devkernel.io>
To: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org
Cc: shr@devkernel.io, axboe@kernel.dk, clm@meta.com,
akpm@linux-foundation.org
Subject: [RFC PATCH v4 07/20] mm: add bdi_set_max_bytes() function.
Date: Fri, 18 Nov 2022 16:52:02 -0800 [thread overview]
Message-ID: <20221119005215.3052436-8-shr@devkernel.io> (raw)
In-Reply-To: <20221119005215.3052436-1-shr@devkernel.io>
This introduces the bdi_set_max_bytes() function. The max_bytes function
does not store the max_bytes value. Instead it converts the max_bytes
value into the corresponding ratio value.
Signed-off-by: Stefan Roesch <shr@devkernel.io>
---
include/linux/backing-dev.h | 1 +
mm/page-writeback.c | 37 +++++++++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 473686c32775..ea6c993433d5 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -108,6 +108,7 @@ static inline unsigned long wb_stat_error(void)
u64 bdi_get_max_bytes(struct backing_dev_info *bdi);
int bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ratio);
int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
+int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes);
int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit);
/*
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index e74ef596dc27..20ae9adeb22f 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -13,6 +13,7 @@
*/
#include <linux/kernel.h>
+#include <linux/math64.h>
#include <linux/export.h>
#include <linux/spinlock.h>
#include <linux/fs.h>
@@ -650,6 +651,28 @@ void wb_domain_exit(struct wb_domain *dom)
*/
static unsigned int bdi_min_ratio;
+static int bdi_check_pages_limit(unsigned long pages)
+{
+ unsigned long max_dirty_pages = global_dirtyable_memory();
+
+ if (pages > max_dirty_pages)
+ return -EINVAL;
+
+ return 0;
+}
+
+static unsigned long bdi_ratio_from_pages(unsigned long pages)
+{
+ unsigned long background_thresh;
+ unsigned long dirty_thresh;
+ unsigned long ratio;
+
+ global_dirty_limits(&background_thresh, &dirty_thresh);
+ ratio = div64_u64(pages * 100ULL * BDI_RATIO_SCALE, dirty_thresh);
+
+ return ratio;
+}
+
static u64 bdi_get_bytes(unsigned int ratio)
{
unsigned long background_thresh;
@@ -722,6 +745,20 @@ u64 bdi_get_max_bytes(struct backing_dev_info *bdi)
return bdi_get_bytes(bdi->max_ratio);
}
+int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes)
+{
+ int ret;
+ unsigned long pages = max_bytes >> PAGE_SHIFT;
+ unsigned long max_ratio;
+
+ ret = bdi_check_pages_limit(pages);
+ if (ret)
+ return ret;
+
+ max_ratio = bdi_ratio_from_pages(pages);
+ return __bdi_set_max_ratio(bdi, max_ratio);
+}
+
int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit)
{
if (strict_limit > 1)
--
2.30.2
next prev parent reply other threads:[~2022-11-19 1:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 0:51 [RFC PATCH v4 00/20] mm/block: add bdi sysfs knobs Stefan Roesch
2022-11-19 0:51 ` [RFC PATCH v4 01/20] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-11-19 0:51 ` [RFC PATCH v4 02/20] mm: add knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-11-19 0:51 ` [RFC PATCH v4 03/20] mm: document /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-11-19 0:51 ` [RFC PATCH v4 04/20] mm: use part per 1000000 for bdi ratios Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 05/20] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 06/20] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-11-19 0:52 ` Stefan Roesch [this message]
2022-11-19 0:52 ` [RFC PATCH v4 08/20] mm: add knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 09/20] mm: document /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 10/20] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 11/20] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 12/20] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 13/20] mm: add /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 14/20] mm: document " Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 15/20] mm: add bdi_set_max_ratio_no_scale() function Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 16/20] mm: add /sys/class/bdi/<bdi>/max_ratio_fine knob Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 17/20] mm: document " Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 18/20] mm: add bdi_set_min_ratio_no_scale() function Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 19/20] mm: add /sys/class/bdi/<bdi>/min_ratio_fine knob Stefan Roesch
2022-11-19 0:52 ` [RFC PATCH v4 20/20] mm: document " Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221119005215.3052436-8-shr@devkernel.io \
--to=shr@devkernel.io \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=clm@meta.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox