linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Roesch <shr@devkernel.io>
To: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org
Cc: shr@devkernel.io, axboe@kernel.dk, clm@meta.com,
	akpm@linux-foundation.org
Subject: [RFC PATCH v4 18/20] mm: add bdi_set_min_ratio_no_scale() function
Date: Fri, 18 Nov 2022 16:52:13 -0800	[thread overview]
Message-ID: <20221119005215.3052436-19-shr@devkernel.io> (raw)
In-Reply-To: <20221119005215.3052436-1-shr@devkernel.io>

This introduces bdi_set_min_ratio_no_scale(). It uses the max
granularity for the ratio. This function by the new sysfs knob
min_ratio_fine.

Signed-off-by: Stefan Roesch <shr@devkernel.io>
---
 include/linux/backing-dev.h | 1 +
 mm/page-writeback.c         | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index d9acbb22ff25..fbad4fcd408e 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -109,6 +109,7 @@ u64 bdi_get_min_bytes(struct backing_dev_info *bdi);
 u64 bdi_get_max_bytes(struct backing_dev_info *bdi);
 int bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ratio);
 int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
+int bdi_set_min_ratio_no_scale(struct backing_dev_info *bdi, unsigned int min_ratio);
 int bdi_set_max_ratio_no_scale(struct backing_dev_info *bdi, unsigned int max_ratio);
 int bdi_set_min_bytes(struct backing_dev_info *bdi, u64 min_bytes);
 int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes);
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index f44ade72966c..ad608ef2a243 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -690,6 +690,8 @@ static int __bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ra
 	unsigned int delta;
 	int ret = 0;
 
+	if (min_ratio > 100 * BDI_RATIO_SCALE)
+		return -EINVAL;
 	min_ratio *= BDI_RATIO_SCALE;
 
 	spin_lock_bh(&bdi_lock);
@@ -734,6 +736,11 @@ static int __bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ra
 	return ret;
 }
 
+int bdi_set_min_ratio_no_scale(struct backing_dev_info *bdi, unsigned int min_ratio)
+{
+	return __bdi_set_min_ratio(bdi, min_ratio);
+}
+
 int bdi_set_max_ratio_no_scale(struct backing_dev_info *bdi, unsigned int max_ratio)
 {
 	return __bdi_set_max_ratio(bdi, max_ratio);
-- 
2.30.2



  parent reply	other threads:[~2022-11-19  2:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19  0:51 [RFC PATCH v4 00/20] mm/block: add bdi sysfs knobs Stefan Roesch
2022-11-19  0:51 ` [RFC PATCH v4 01/20] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-11-19  0:51 ` [RFC PATCH v4 02/20] mm: add knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-11-19  0:51 ` [RFC PATCH v4 03/20] mm: document /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-11-19  0:51 ` [RFC PATCH v4 04/20] mm: use part per 1000000 for bdi ratios Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 05/20] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 06/20] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 07/20] mm: add bdi_set_max_bytes() function Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 08/20] mm: add knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 09/20] mm: document /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 10/20] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 11/20] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 12/20] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 13/20] mm: add /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 14/20] mm: document " Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 15/20] mm: add bdi_set_max_ratio_no_scale() function Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 16/20] mm: add /sys/class/bdi/<bdi>/max_ratio_fine knob Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 17/20] mm: document " Stefan Roesch
2022-11-19  0:52 ` Stefan Roesch [this message]
2022-11-19  0:52 ` [RFC PATCH v4 19/20] mm: add /sys/class/bdi/<bdi>/min_ratio_fine knob Stefan Roesch
2022-11-19  0:52 ` [RFC PATCH v4 20/20] mm: document " Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221119005215.3052436-19-shr@devkernel.io \
    --to=shr@devkernel.io \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=clm@meta.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox