From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D9AC4332F for ; Fri, 18 Nov 2022 22:08:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02EFD6B0072; Fri, 18 Nov 2022 17:08:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F21736B0073; Fri, 18 Nov 2022 17:08:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEA6F6B0074; Fri, 18 Nov 2022 17:08:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D2C596B0072 for ; Fri, 18 Nov 2022 17:08:10 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B3A54807FB for ; Fri, 18 Nov 2022 22:08:10 +0000 (UTC) X-FDA: 80147951940.07.9286F55 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf11.hostedemail.com (Postfix) with ESMTP id 68E7C4000C for ; Fri, 18 Nov 2022 22:08:10 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id v17so5745932plo.1 for ; Fri, 18 Nov 2022 14:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dKSjP9jIbGdZ8wbLlDbYShn3Lx3bNa4PD6IpDt+85XI=; b=jCHkY5be8ot6u32cjkAArYEdMbMdd/w6wP+nB4cDhKX2kolNOXxHlMgpNPhKHBZDun 5iqAKa+xnzabXzyeEke9B6y/WqR9HZBzUOXDa+8z7VzbYb0ltRHjQ0nxGlRhhx+MagRo mnuJh20aB1V+bUj8jD0C4PPW8HbUzVKVlYkBoPqbn+bNkuPukYdTDZzBE6z6z7BrBsqt ve28ZH+WoPXL5Ou7XhswiBPFvUm+Y2vVcK7RoZQ+8eYcGn8GGmY5HZqiNF/d4N9rH6JW PpN9IQfDsmfx1mBDX3YomsLVWwd+Utvt4FKR4YXUglrsFZZ+wVieaj9l84mIlDUkSFUI Mvuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dKSjP9jIbGdZ8wbLlDbYShn3Lx3bNa4PD6IpDt+85XI=; b=OxmRLGjeG4KSm43xfU0ArhoQjHWbFZ4Xm3Xt6yfWQKIMI4I957reHtDrsr3vYP2xsT 19gHj/nUvUgatDDS13oBNGVybTlJQ0l7avxTu6Bs4Hn9VmddarQ96+wr9jv4z+aBUthf vybKZMSUW37CYucA6i6/GUeAKUMVMAGh6S7DYvWvkvIS8nPDeEzo7D5VXn7vZrrBeLuc odjqfZrWVP9siA0+AlLB7XVkRNLVsu34c/77uUbOQ9ar6hLhnLvYGOmNLW0nTaIw+qYy lpTMBwn3cDJCZmX6FXhctkm0MpwSjDHYONVz0Tne0pLAwOlNB/GyOAcLCp6EuAvPVSUx dBLQ== X-Gm-Message-State: ANoB5pnmW5UZ+jLQesq5IA4LgU49Eehn1iWz/JGBi8hyawjjP8CeX7V0 Q7JVBuE+RL4o8UUGtxRA5x4= X-Google-Smtp-Source: AA0mqf4oyTiXZv8g23McsjX9c4sNZxa1YSzTsl3yHDCHEpXc7lx6IEJWHWyf2U0zaUht3NSGqrNyeg== X-Received: by 2002:a17:902:e849:b0:17a:aca0:e295 with SMTP id t9-20020a170902e84900b0017aaca0e295mr1553420plg.3.1668809289374; Fri, 18 Nov 2022 14:08:09 -0800 (PST) Received: from localhost (fwdproxy-prn-118.fbsv.net. [2a03:2880:ff:76::face:b00c]) by smtp.gmail.com with ESMTPSA id f15-20020a170902ce8f00b0017305e99f00sm4336459plg.107.2022.11.18.14.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 14:08:08 -0800 (PST) From: Nhat Pham To: minchan@kernel.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v5 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Date: Fri, 18 Nov 2022 14:08:08 -0800 Message-Id: <20221118220808.1194168-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668809290; a=rsa-sha256; cv=none; b=UKRO+nzneQB5ctPsD0xzVFIOWkuJzu+96zwRnwGqUsQclGSo22M/10WE8S4ncCvJRnVJCJ u6Q9Eo7pa22/1tue2O2y+nk2vDZO+bMLwKBVq6VMZKEsoCYLi01R/pjN3LBwk8fCFwJ1cm jni75N/Cx9+eyIAScH4+CpeJBFj1EAo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jCHkY5be; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668809290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dKSjP9jIbGdZ8wbLlDbYShn3Lx3bNa4PD6IpDt+85XI=; b=yy+nyDBTBPVruSQJ+jE0c4c5BEVWZ5qLuTxnXwUHWpQM+E3ObIJXLEvTYw0AN7bNLXmi6b 3ARUj9q/8QQthU6bkb+e3580t44jEHQE8MmRaQaBJVDURkkEtgLSSx+EpvUWs4Iz6Q3/RB WPCwY9qb/HnKasWitGGfuVbguucBJZM= X-Stat-Signature: abhsp4zghnzu69mniikik4q1mwt45nxt X-Rspamd-Queue-Id: 68E7C4000C Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jCHkY5be; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1668809290-467605 X-Bogosity: Ham, tests=bogofilter, spamicity=0.009790, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks a lot for the suggestions so far and for the review, Minchan! Quick question about your last comment: >> +#ifdef CONFIG_ZPOOL > > Let's remove the ifdef machinery here. > >> + /* Free all deferred handles from zs_free */ >> + free_handles(pool, zspage); >> +#endif free_handles() here is for the deferred handle freeing, which is also under CONFIG_ZPOOL now, so I don't think we should remove the #ifdef CONFIG_ZPOOL here, no? Let me know if I'm misunderstanding your suggestion, or if you have any further comments regarding this patch.