From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D7DC433FE for ; Fri, 18 Nov 2022 22:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 291FD8E0002; Fri, 18 Nov 2022 17:29:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21A3F6B007B; Fri, 18 Nov 2022 17:29:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06DB98E0002; Fri, 18 Nov 2022 17:29:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E90DA6B0078 for ; Fri, 18 Nov 2022 17:29:04 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C30DE4050D for ; Fri, 18 Nov 2022 22:29:04 +0000 (UTC) X-FDA: 80148004608.07.A3F3306 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 65A3AA000E for ; Fri, 18 Nov 2022 22:29:04 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id jn7so3907990plb.13 for ; Fri, 18 Nov 2022 14:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UbBsvDU//DL6nEBTfVogOGw4gtrIt5cEgoWU7wg0yqE=; b=An8R27hBelrmHfCbOWIi0CQbpB+FbdUKZd/K74OWA+t1inv8v4494buerQXpAbVoQ/ hawXo5IWqwOaOJXIlgQJ62nY4aZ8mzIQL8T0sN5QawgAa8EGZw3klOrzN/KXycM8ohn1 PnwiDQNXHvwQENzmlhMaoO6BFIxzwB92hREPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UbBsvDU//DL6nEBTfVogOGw4gtrIt5cEgoWU7wg0yqE=; b=GaqlICpQL/3bunAlwMkP4yAwNEuwqSg8lT6GgdkAOrH6fuRRdmLCzyycmN+/Ggmv8R 7tAqrB2fnaBaVdWryebMrxUkhobgDjrwfYgmRi+rBLe9DalGenM414cTwMYzQs7W/W75 OO/u0Sue2TBi2q0QRRinDhYrKezl7vZ0/T0LdVSDqompdLSmHe/+5IopbU6ibT569InU ZvtetWcnNEkKMA0uiXL95ei0xQ6zDoyn0Eh+AMJDw3wkQHVLw8WoWW70YZ1nFGq9ULJZ 1nP/sQTQj+SlDixp7ob1TPL/gUaGLsaU3pYzf91WHvH5FMUqKyy4wvCKQyYZTEL4y7cf Hbyw== X-Gm-Message-State: ANoB5pmo6aBfBlvzIm8+7936e4rJSPtlBtdC6LW6xGsMlrKOwq9T7Z2D FvM98SoCqD25YkOtH1uJ4nZRqA== X-Google-Smtp-Source: AA0mqf6CgTDul/374P0W7rrlIZwWC/WtPB/rFM9c4Pb8H4WjGT5BNPOAuJqtgF8hwxBjrZP80dPQ5g== X-Received: by 2002:a17:902:7b96:b0:188:b0db:cd5d with SMTP id w22-20020a1709027b9600b00188b0dbcd5dmr1455470pll.104.1668810543328; Fri, 18 Nov 2022 14:29:03 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f26-20020aa7969a000000b00571dda13fafsm3646997pfk.163.2022.11.18.14.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 14:29:02 -0800 (PST) Date: Fri, 18 Nov 2022 14:29:02 -0800 From: Kees Cook To: Peter Zijlstra Cc: Linus Torvalds , David Hildenbrand , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Oleg Nesterov , Richard Henderson , Ivan Kokshaysky , Matt Turner , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Richard Weinberger , Anton Ivanov , Johannes Berg , Eric Biederman , Alexander Viro , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kentaro Takeda , Tetsuo Handa , Paul Moore , James Morris , "Serge E. Hallyn" Subject: Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE Message-ID: <202211181427.4D1C3132FE@keescook> References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-21-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668810544; a=rsa-sha256; cv=none; b=1xSe8CPRJ/oQahsS7Tx1Y1BntES/y4quiPi80f9weLrH77PKKSn0unvpgs26h613OdnKUc x5ZhtfFXlj/Lusk8tbBHWOvxtHIeDqtUpuzZYf4vYzcMc6QJl7A5RQl51j4Tb0J0eAp9tK ITgWfLg9B3pJ/A1065Xm/S2gh90YhdA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=An8R27hB; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668810544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UbBsvDU//DL6nEBTfVogOGw4gtrIt5cEgoWU7wg0yqE=; b=lOGAQpf0GPErNgROlRBFOYk4Tl3y0/31++qwcFG9riMfNg2sS0J/3V+JpF46XwEme5woKn u9uacm3hHfjOc745asusTn7apkFS9V57lBaMX7MGAgx5JLvJb4fpLKq0r4IIIIU50pIGvz 4EX8oKVcGifwM+tKD0WisuEsKyDEf4c= X-Stat-Signature: 4ms7ojh1b68n7o4shkn6k36gm4p6xf3h X-Rspamd-Queue-Id: 65A3AA000E Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=An8R27hB; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1668810544-493209 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 18, 2022 at 12:09:02PM +0100, Peter Zijlstra wrote: > On Wed, Nov 16, 2022 at 10:16:34AM -0800, Linus Torvalds wrote: > > Following the history of it is a big of a mess, because there's a > > number of renamings and re-organizations, but it seems to go back to > > 2007 and commit b6a2fea39318 ("mm: variable length argument support"). > > I went back and read parts of the discussions with Ollie, and the > .force=1 thing just magically appeared one day when we were sending > work-in-progress patches back and forth without mention of where it came > from :-/ > > And I certainly can't remember now.. > > Looking at it now, I have the same reaction as both you and Kees had, it > seems entirely superflous. So I'm all for trying to remove it. Thanks for digging through the history! I've pushed the change to -next: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/execve&id=cd57e443831d8eeb083c7165bce195d886e216d4 -- Kees Cook